)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"667dcdedb0bb98f8c5419bce0897f489289aa723","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"@pick_context_manager_reader"},{"line_number":677,"context_line":"def compute_node_get_by_uuid(context, compute_uuid):"},{"line_number":678,"context_line":"    result \u003d model_query(context, models.ComputeNode).\\"},{"line_number":679,"context_line":"            filter_by(uuid\u003dcompute_uuid).first()"},{"line_number":680,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_c4d69950","line":677,"updated":"2017-05-04 14:32:43.000000000","message":"FWIW, we have a ComputeNodeList.get_all_by_uuids() method which directly uses the ORM, I\u0027m not sure we really need this DB API method...\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L440","commit_id":"8433467c3770fa2dbdeff25dde4d42b53e8a3e30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56c063569a441f8dccf1c31edd5a6d0781416ab5","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"@pick_context_manager_reader"},{"line_number":677,"context_line":"def compute_node_get_by_uuid(context, compute_uuid):"},{"line_number":678,"context_line":"    result \u003d model_query(context, models.ComputeNode).\\"},{"line_number":679,"context_line":"            filter_by(uuid\u003dcompute_uuid).first()"},{"line_number":680,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_692e79a6","line":677,"in_reply_to":"3f044301_69daf917","updated":"2017-05-04 17:23:13.000000000","message":"OK Jay said mysql optimizers should transform a single item IN to a \u003d where and this confirms it:\n\nhttp://stackoverflow.com/questions/9926433/mysql-performance-in-clause-vs-equals-for-a-single-value\n\nSo I\u0027ll drop this DB API change and hide the dirty details in the object code.","commit_id":"8433467c3770fa2dbdeff25dde4d42b53e8a3e30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9dc1f1d9efa135c047a401afb6927aaee8407ff8","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"@pick_context_manager_reader"},{"line_number":677,"context_line":"def compute_node_get_by_uuid(context, compute_uuid):"},{"line_number":678,"context_line":"    result \u003d model_query(context, models.ComputeNode).\\"},{"line_number":679,"context_line":"            filter_by(uuid\u003dcompute_uuid).first()"},{"line_number":680,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_69daf917","line":677,"in_reply_to":"3f044301_c4d69950","updated":"2017-05-04 17:11:46.000000000","message":"Because I don\u0027t want to do:\n\nobjects.ComputeNodeList.get_all_by_uuids(ctxt, [uuid])[0]\n\nI think ^ would be an ugly construct. And it\u0027s using an IN operator in the query, and I\u0027m not sure if that\u0027s a performance hit in any way besides querying for something with a WHERE class on the field \u003d\u003d directly.","commit_id":"8433467c3770fa2dbdeff25dde4d42b53e8a3e30"}]}