)]}'
{"nova/utils.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"e02c274a65dc58ae906b2b08815c8d2e2af5ec93","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"        try:"},{"line_number":1557,"context_line":"            shutil.rmtree(tmpdir)"},{"line_number":1558,"context_line":"        except OSError, e:"},{"line_number":1559,"context_line":"            LOG.debug(_(\u0027Could not remove tmpdir: %s\u0027), str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F1Qs%3D","line":1559,"updated":"2012-02-28 06:29:36.000000000","message":"Always looks weird to me when I see the format arguments as actual separate arguments vs using \u0027%\u0027.  I think we have a mix of this usage, but thought this one was less common.  Just an observation.","commit_id":"f0d5df523b982ef1737dc0ee2e698b13041af64c"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"e02c274a65dc58ae906b2b08815c8d2e2af5ec93","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            \u003cname\u003e%s\u003c/name\u003e"},{"line_number":614,"context_line":"        \u003c/domainsnapshot\u003e"},{"line_number":615,"context_line":"        \"\"\" % snapshot_name"},{"line_number":616,"context_line":"        snapshot_ptr \u003d virt_dom.snapshotCreateXML(snapshot_xml, 0)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        # Find the disk"},{"line_number":619,"context_line":"        xml_desc \u003d virt_dom.XMLDesc(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F1Qo%3D","side":"PARENT","line":616,"updated":"2012-02-28 06:29:36.000000000","message":"Seems like maybe this should be context-managered (yes, that\u0027s a verb now) as well.. which would avoid the try/finally below which cleans up the ptr.  Seems like maybe it should get cleaned up if any of the next couple lines fail as well.  But, I view this as out of scope for this patch.  Again, just an observation.","commit_id":"f01b9b8dd25d763e652259a0f99264d93661b29f"}]}