)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8d8c5c918ae3a0c0595ae46704491fc70e7369aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle uuid in HostAPI._find_service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows looking up a service in the HostAPI by it\u0027s uuid"},{"line_number":10,"context_line":"value to uniquely identify it in a list of cells. A later"},{"line_number":11,"context_line":"REST API microversion change will rely on this to avoid the"},{"line_number":12,"context_line":"ServiceNotUnique scenario."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f013ff3_f456da06","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":55},"updated":"2017-05-15 17:28:20.000000000","message":"s/it\u0027s/its/ (attonit)","commit_id":"604c6b6748db37a796686c1d7ca690d2a95a5e14"}],"nova/tests/unit/compute/test_host_api.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"49d138b1fc5e3c7f23516bbd697e2abb92867ec6","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                               transport_url\u003d\u0027mq://fake2\u0027,"},{"line_number":327,"context_line":"                               database_connection\u003d\u0027db://fake2\u0027)]))"},{"line_number":328,"context_line":"    @mock.patch.object(objects.Service, \u0027get_by_uuid\u0027,"},{"line_number":329,"context_line":"                       return_value\u003dobjects.Service(uuid\u003duuids.service_uuid))"},{"line_number":330,"context_line":"    def test_service_get_by_id_using_uuid(self, service_get_by_uuid,"},{"line_number":331,"context_line":"                                          cell_mappings_get_all):"},{"line_number":332,"context_line":"        \"\"\"Tests that we can lookup a service in the HostAPI using a uuid.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_56d7e3c0","line":329,"range":{"start_line":329,"start_character":36,"end_line":329,"end_character":76},"updated":"2017-05-15 09:01:50.000000000","message":"It will be great if we return NotFound in the first cell, and return service obj in the second cell. That is good for testing the case we continue the loop when the service is not found in the first cell.\n\nAlso worth a case for totally not found?","commit_id":"2c3e5e480e38d9bf768b2a59dfe4245ae4775af9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4402dcb929944fa8d29355ca65d2aa1b7b409bd7","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                               transport_url\u003d\u0027mq://fake2\u0027,"},{"line_number":327,"context_line":"                               database_connection\u003d\u0027db://fake2\u0027)]))"},{"line_number":328,"context_line":"    @mock.patch.object(objects.Service, \u0027get_by_uuid\u0027,"},{"line_number":329,"context_line":"                       return_value\u003dobjects.Service(uuid\u003duuids.service_uuid))"},{"line_number":330,"context_line":"    def test_service_get_by_id_using_uuid(self, service_get_by_uuid,"},{"line_number":331,"context_line":"                                          cell_mappings_get_all):"},{"line_number":332,"context_line":"        \"\"\"Tests that we can lookup a service in the HostAPI using a uuid.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_6802f3b6","line":329,"range":{"start_line":329,"start_character":36,"end_line":329,"end_character":76},"in_reply_to":"1f013ff3_56d7e3c0","updated":"2017-05-15 15:19:34.000000000","message":"\u003e It will be great if we return NotFound in the first cell, and return service obj in the second cell. That is good for testing the case we continue the loop when the service is not found in the first cell.\n\nI can work that into this test I think.\n\n\u003e Also worth a case for totally not found?\n\nThat case is already tested in nova.tests.unit.api.openstack.compute.test_services.ServicesTestV21.test_services_delete_not_found.","commit_id":"2c3e5e480e38d9bf768b2a59dfe4245ae4775af9"}]}