)]}'
{"nova/policies/hide_server_addresses.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ce2f0784b7df2786d8ad657e00c042ba8d4809d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    base.create_rule_default("},{"line_number":23,"context_line":"        BASE_POLICY_NAME,"},{"line_number":24,"context_line":"        \u0027is_admin:False\u0027,"},{"line_number":25,"context_line":"        \"\"\"Hide server\u0027s \u0027addresses\u0027 in the server response.\"\"\","},{"line_number":26,"context_line":"        ["},{"line_number":27,"context_line":"            {"},{"line_number":28,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_07bc7eb9","line":25,"updated":"2017-05-03 09:45:24.000000000","message":"I really think we should mention it only hides the server address when the VM is in a specific set of states as defined in CONF.api.hide_server_address_states, by default only when the server is building is the address hidden.\n\nIts the \"addresses\" key in the server response that is set to an empty dictionary in certain cases. I guess it wasn\u0027t 100% clear thats what you meant here. Maybe include the word \"key\"?\n\nIts a bit nuts, so I think its worth clarifying.\n\nWe should probably kill this craziness, but thats another patch.","commit_id":"cfd8a36581766bae8a86e4f1cd26d10c93db345e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f98e84d4462d4e7fdb71deec446c0a3af75d0b4d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    base.create_rule_default("},{"line_number":23,"context_line":"        BASE_POLICY_NAME,"},{"line_number":24,"context_line":"        \u0027is_admin:False\u0027,"},{"line_number":25,"context_line":"        \"\"\"Hide server\u0027s \u0027addresses\u0027 in the server response.\"\"\","},{"line_number":26,"context_line":"        ["},{"line_number":27,"context_line":"            {"},{"line_number":28,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_b17951fd","line":25,"in_reply_to":"5ff73747_07bc7eb9","updated":"2017-05-17 05:10:33.000000000","message":"Thanks, yea those info should be there.","commit_id":"cfd8a36581766bae8a86e4f1cd26d10c93db345e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c397599a845726322e08cd57d2eb754cbd2f1c38","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    base.create_rule_default("},{"line_number":23,"context_line":"        BASE_POLICY_NAME,"},{"line_number":24,"context_line":"        \u0027is_admin:False\u0027,"},{"line_number":25,"context_line":"        \"\"\"Hide server\u0027s \u0027addresses\u0027 key in the server response."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This set the \u0027addresses\u0027 key in the server response to an empty dictionary"},{"line_number":28,"context_line":"when the server is in a specific set of states as defined in"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_2fbe96b3","line":25,"updated":"2017-05-24 06:59:01.000000000","message":"Should we say this policy rule is deprecated? Since the cfg opt CONF.api.hide_server_address_states is deprecated already.","commit_id":"62c24f6edaa91834d4a7b2a3f9b99b8b96322230"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d5519121a374db9b6688f65ce39bdcd7598a02c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    base.create_rule_default("},{"line_number":23,"context_line":"        BASE_POLICY_NAME,"},{"line_number":24,"context_line":"        \u0027is_admin:False\u0027,"},{"line_number":25,"context_line":"        \"\"\"Hide server\u0027s \u0027addresses\u0027 key in the server response."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This set the \u0027addresses\u0027 key in the server response to an empty dictionary"},{"line_number":28,"context_line":"when the server is in a specific set of states as defined in"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e2fd08b2","line":25,"in_reply_to":"ff0f0b1f_2fbe96b3","updated":"2017-05-26 05:18:55.000000000","message":"as discussed on api meeting, cfg is not yet deprecated, old name was deprecated. and will go with spec to deprecated the cfg and this policy as well with default behavior. \n\nhttps://github.com/openstack/nova/blob/master/nova/conf/api.py#L281","commit_id":"62c24f6edaa91834d4a7b2a3f9b99b8b96322230"}]}