)]}'
{"nova/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"478a5ff1707f91fedfa4eb529d60bfc596c509f0","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"                consumer_id\u003d\u0027consumer%d\u0027 % x,"},{"line_number":2054,"context_line":"                used\u003d512,"},{"line_number":2055,"context_line":"            )"},{"line_number":2056,"context_line":"            alloc_list \u003d objects.AllocationList("},{"line_number":2057,"context_line":"                self.context,"},{"line_number":2058,"context_line":"                objects\u003d[memory_mb_alloc]"},{"line_number":2059,"context_line":"            )"},{"line_number":2060,"context_line":"            alloc_list.create_all()"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"        got_rps \u003d rp_obj._get_all_with_shared("},{"line_number":2063,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_e993935b","line":2060,"range":{"start_line":2056,"start_character":0,"end_line":2060,"end_character":35},"updated":"2017-05-03 18:42:49.000000000","message":"nit: create the three allocations, then create the list outside of the loop. One call to create_all() instead of 3.","commit_id":"b73597cf535e065ea55b979c96a3c5f05664c81d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6d13c34eb1214dd117f32b00740b6303aff97ab6","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"                consumer_id\u003d\u0027consumer%d\u0027 % x,"},{"line_number":2054,"context_line":"                used\u003d512,"},{"line_number":2055,"context_line":"            )"},{"line_number":2056,"context_line":"            alloc_list \u003d objects.AllocationList("},{"line_number":2057,"context_line":"                self.context,"},{"line_number":2058,"context_line":"                objects\u003d[memory_mb_alloc]"},{"line_number":2059,"context_line":"            )"},{"line_number":2060,"context_line":"            alloc_list.create_all()"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"        got_rps \u003d rp_obj._get_all_with_shared("},{"line_number":2063,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_49473d4d","line":2060,"range":{"start_line":2056,"start_character":0,"end_line":2060,"end_character":35},"in_reply_to":"5ff73747_e993935b","updated":"2017-05-04 17:00:08.000000000","message":"No, I need to create 3 separate allocations for three different consumers.","commit_id":"b73597cf535e065ea55b979c96a3c5f05664c81d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0c1e3c41e4fe6b042e42a774220336b02a226ec","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"            resources,"},{"line_number":2065,"context_line":"        )"},{"line_number":2066,"context_line":"        got_ids \u003d [rp.id for rp in got_rps]"},{"line_number":2067,"context_line":"        self.assertEqual([cn1.id], got_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_44f5e9ca","line":2067,"updated":"2017-05-04 14:35:43.000000000","message":"cn3 should be in this list too right?","commit_id":"b73597cf535e065ea55b979c96a3c5f05664c81d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5f3eb91596a74e777b01a503ea391b3a25677ba3","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"            resources,"},{"line_number":2065,"context_line":"        )"},{"line_number":2066,"context_line":"        got_ids \u003d [rp.id for rp in got_rps]"},{"line_number":2067,"context_line":"        self.assertEqual([cn1.id], got_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_a6aeeee4","line":2067,"in_reply_to":"3f044301_44f5e9ca","updated":"2017-05-04 16:40:45.000000000","message":"No, because we\u0027ve exhausted cn3 at this point (in the last patch).","commit_id":"b73597cf535e065ea55b979c96a3c5f05664c81d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6d13c34eb1214dd117f32b00740b6303aff97ab6","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"            resources,"},{"line_number":2065,"context_line":"        )"},{"line_number":2066,"context_line":"        got_ids \u003d [rp.id for rp in got_rps]"},{"line_number":2067,"context_line":"        self.assertEqual([cn1.id], got_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_8938a5d3","line":2067,"in_reply_to":"3f044301_a6aeeee4","updated":"2017-05-04 17:00:08.000000000","message":"Correct.","commit_id":"b73597cf535e065ea55b979c96a3c5f05664c81d"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"f8acf066508a32a81c73747530b2caf03753646b","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"            memory_mb_alloc \u003d objects.Allocation("},{"line_number":2066,"context_line":"                resource_provider\u003dcn2,"},{"line_number":2067,"context_line":"                resource_class\u003dfields.ResourceClass.MEMORY_MB,"},{"line_number":2068,"context_line":"                consumer_id\u003d\u0027consumer%d\u0027 % x,"},{"line_number":2069,"context_line":"                used\u003d512,"},{"line_number":2070,"context_line":"            )"},{"line_number":2071,"context_line":"            alloc_list \u003d objects.AllocationList("}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_6a3b10d1","line":2068,"updated":"2017-05-15 11:02:54.000000000","message":"this should be uuid field, it generates a warning and will be broken some time","commit_id":"7301f5553017aaafc1a3ff8ee794b9782757bd1b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"881efb9b0a1f756f0bf6cf7c6dd2d86c70455f6b","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"            memory_mb_alloc \u003d objects.Allocation("},{"line_number":2066,"context_line":"                resource_provider\u003dcn2,"},{"line_number":2067,"context_line":"                resource_class\u003dfields.ResourceClass.MEMORY_MB,"},{"line_number":2068,"context_line":"                consumer_id\u003d\u0027consumer%d\u0027 % x,"},{"line_number":2069,"context_line":"                used\u003d512,"},{"line_number":2070,"context_line":"            )"},{"line_number":2071,"context_line":"            alloc_list \u003d objects.AllocationList("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_59c43f91","line":2068,"in_reply_to":"1f013ff3_6a3b10d1","updated":"2017-05-22 13:35:56.000000000","message":"Done","commit_id":"7301f5553017aaafc1a3ff8ee794b9782757bd1b"}]}