)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a698aff92ade62a08d56d77e1bccaffc864eb850","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"placement: test for agg association not sharing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds yet another functional test scenario that demonstrates an environment with"},{"line_number":10,"context_line":"a set of compute nodes with no local disk connected to a shared storage"},{"line_number":11,"context_line":"provider via an aggregate and a set of compute nodes with no local disk"},{"line_number":12,"context_line":"associated to an aggregate with a provider having DISK_GB inventory but not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"df140735_42034d74","line":9,"updated":"2017-05-31 19:14:50.000000000","message":"I had to scroll left and right to read this, which made me angry. Can you wrap these please?","commit_id":"fc872c3ad73e2d06babe93040d889f9b5a98155c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b31e6275db0fb2292bd9ad56768c802ee2e5d7cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"placement: test for agg association not sharing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds yet another functional test scenario that demonstrates an environment with"},{"line_number":10,"context_line":"a set of compute nodes with no local disk connected to a shared storage"},{"line_number":11,"context_line":"provider via an aggregate and a set of compute nodes with no local disk"},{"line_number":12,"context_line":"associated to an aggregate with a provider having DISK_GB inventory but not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"df140735_0c822350","line":9,"in_reply_to":"df140735_42034d74","updated":"2017-06-01 00:32:40.000000000","message":"Done","commit_id":"fc872c3ad73e2d06babe93040d889f9b5a98155c"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a698aff92ade62a08d56d77e1bccaffc864eb850","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                    it.c.resource_provider_id !\u003d sa.null(),"},{"line_number":1026,"context_line":"                    usage_cond,"},{"line_number":1027,"context_line":"                ),"},{"line_number":1028,"context_line":"                sharing.c.resource_provider_id !\u003d sa.null(),"},{"line_number":1029,"context_line":"            )"},{"line_number":1030,"context_line":"            where_conds.append(cond)"},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_62009168","line":1028,"updated":"2017-05-31 19:14:50.000000000","message":"This is a functional test, but your commit message says it\u0027s just adding a test. Sounds like this is now a fix and a regression test instead of just a straight test add?","commit_id":"fc872c3ad73e2d06babe93040d889f9b5a98155c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b31e6275db0fb2292bd9ad56768c802ee2e5d7cd","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                    it.c.resource_provider_id !\u003d sa.null(),"},{"line_number":1026,"context_line":"                    usage_cond,"},{"line_number":1027,"context_line":"                ),"},{"line_number":1028,"context_line":"                sharing.c.resource_provider_id !\u003d sa.null(),"},{"line_number":1029,"context_line":"            )"},{"line_number":1030,"context_line":"            where_conds.append(cond)"},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_2c7167aa","line":1028,"in_reply_to":"df140735_62009168","updated":"2017-06-01 00:32:40.000000000","message":"Done","commit_id":"fc872c3ad73e2d06babe93040d889f9b5a98155c"}],"nova/tests/functional/db/test_resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"48a9eaa74667561feca6093cc3702232ab717b95","unresolved":false,"context_lines":[{"line_number":2067,"context_line":"        self.assertEqual([cn1.id], got_ids)"},{"line_number":2068,"context_line":""},{"line_number":2069,"context_line":"        # Create another two compute node providers having no local disk"},{"line_number":2070,"context_line":"        # inventory and associated with a different aggregate. The created a"},{"line_number":2071,"context_line":"        # storage provider but do NOT decorate that provider with the"},{"line_number":2072,"context_line":"        # MISC_SHARES_VIA_AGGREGATE trait and verify that neither of the new"},{"line_number":2073,"context_line":"        # compute node providers are returned by _get_all_with_shared()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_8bd0a452","line":2070,"updated":"2017-05-04 13:20:14.000000000","message":"Then create a","commit_id":"46e8661f8ec150211119fceb114277b3b77cc336"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d1c6229aea00f05886613ae4f46517da38db09a0","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"        self.assertEqual([cn1.id], got_ids)"},{"line_number":2083,"context_line":""},{"line_number":2084,"context_line":"        # Create another two compute node providers having no local disk"},{"line_number":2085,"context_line":"        # inventory and associated with a different aggregate. The created a"},{"line_number":2086,"context_line":"        # storage provider but do NOT decorate that provider with the"},{"line_number":2087,"context_line":"        # MISC_SHARES_VIA_AGGREGATE trait and verify that neither of the new"},{"line_number":2088,"context_line":"        # compute node providers are returned by _get_all_with_shared()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_aba56c06","line":2085,"updated":"2017-05-16 19:04:45.000000000","message":"Then create","commit_id":"ff6703e24049122e9afe6c0e380797fc869d9070"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b31c15471fa2dd9ee13574ba6a330aaf45c374be","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"        self.assertEqual([cn1.id], got_ids)"},{"line_number":2083,"context_line":""},{"line_number":2084,"context_line":"        # Create another two compute node providers having no local disk"},{"line_number":2085,"context_line":"        # inventory and associated with a different aggregate. The created a"},{"line_number":2086,"context_line":"        # storage provider but do NOT decorate that provider with the"},{"line_number":2087,"context_line":"        # MISC_SHARES_VIA_AGGREGATE trait and verify that neither of the new"},{"line_number":2088,"context_line":"        # compute node providers are returned by _get_all_with_shared()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_58dd8a40","line":2085,"in_reply_to":"1f013ff3_aba56c06","updated":"2017-05-17 07:46:59.000000000","message":"Done","commit_id":"ff6703e24049122e9afe6c0e380797fc869d9070"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d1c6229aea00f05886613ae4f46517da38db09a0","unresolved":false,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"        # Ensure neither cn4 nor cn5 are in the returned providers list,"},{"line_number":2156,"context_line":"        # because neither has DISK_GB inventory and although they are"},{"line_number":2157,"context_line":"        # associated with an aggregate that has a storage provider with DISK_GB"},{"line_number":2158,"context_line":"        # inventory, that storage provider is not marked as sharing that"},{"line_number":2159,"context_line":"        # DISK_GB inventory with anybody."},{"line_number":2160,"context_line":"        got_rps \u003d rp_obj._get_all_with_shared("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_abcc4cbc","line":2157,"updated":"2017-05-16 19:04:45.000000000","message":"As far as I can see none of cn4, cn5 or ns are part of any aggregate so this test doesn\u0027t seem to be testing what it claims to be testing.","commit_id":"ff6703e24049122e9afe6c0e380797fc869d9070"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b31c15471fa2dd9ee13574ba6a330aaf45c374be","unresolved":false,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"        # Ensure neither cn4 nor cn5 are in the returned providers list,"},{"line_number":2156,"context_line":"        # because neither has DISK_GB inventory and although they are"},{"line_number":2157,"context_line":"        # associated with an aggregate that has a storage provider with DISK_GB"},{"line_number":2158,"context_line":"        # inventory, that storage provider is not marked as sharing that"},{"line_number":2159,"context_line":"        # DISK_GB inventory with anybody."},{"line_number":2160,"context_line":"        got_rps \u003d rp_obj._get_all_with_shared("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_b8c48e60","line":2157,"in_reply_to":"1f013ff3_abcc4cbc","updated":"2017-05-17 07:46:59.000000000","message":"Excellent catch. I\u0027ll update the test accordingly.","commit_id":"ff6703e24049122e9afe6c0e380797fc869d9070"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"71fc6264136de3cec3382888217de5a4e25506c4","unresolved":false,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"        # Ensure neither cn4 nor cn5 are in the returned providers list,"},{"line_number":2156,"context_line":"        # because neither has DISK_GB inventory and although they are"},{"line_number":2157,"context_line":"        # associated with an aggregate that has a storage provider with DISK_GB"},{"line_number":2158,"context_line":"        # inventory, that storage provider is not marked as sharing that"},{"line_number":2159,"context_line":"        # DISK_GB inventory with anybody."},{"line_number":2160,"context_line":"        got_rps \u003d rp_obj._get_all_with_shared("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_d31cdd6b","line":2157,"in_reply_to":"1f013ff3_b8c48e60","updated":"2017-05-17 08:02:31.000000000","message":"Chris, thanks much for alerting me to this. It was actually a bug in the join code. I\u0027ve fixed in the latest patch.","commit_id":"ff6703e24049122e9afe6c0e380797fc869d9070"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9c86fb2eac0e626b0c98df797ae9ecb61d7b4ae5","unresolved":false,"context_lines":[{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"        # Associate the new no-local-disk compute nodes and the non-shared"},{"line_number":2156,"context_line":"        # storage provider with an aggregate that is different from the"},{"line_number":2157,"context_line":"        # aggregate associating the shared storage provider with compute nodes"},{"line_number":2158,"context_line":"        agg2_uuid \u003d uuidsentinel.agg2"},{"line_number":2159,"context_line":"        cn4.set_aggregates([agg2_uuid])"},{"line_number":2160,"context_line":"        cn5.set_aggregates([agg2_uuid])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_6eb689dc","line":2157,"updated":"2017-05-17 19:39:45.000000000","message":"You can avoid some of the wandering in this comment by saying:\n\nAssociate the new no-local-disk compute nodes and the non-shared storage provider with a new aggregate.\n\nTalking about the other aggregate and \"compute nodes\" is confusing, especially if you don\u0027t say the \"other\" or \"earlier\" compute nodes.","commit_id":"10a41a8397a298b0ca4ecfb993203f50ca2e0bee"}]}