)]}'
{"nova/tests/unit/test_utils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46a280f4b7fb0d9f43448f45241349cf5d096aeb","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        instance \u003d instance_obj.Instance()"},{"line_number":249,"context_line":"        instance.display_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":250,"context_line":"        self.assertIs(str, type(repr(instance)))"},{"line_number":251,"context_line":"        if six.PY3:"},{"line_number":252,"context_line":"            expected_type \u003d str"},{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            expected_type \u003d unicode"},{"line_number":255,"context_line":"        self.assertIs(expected_type,"},{"line_number":256,"context_line":"                      type(utils.get_obj_repr_unicode(instance)))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def test_use_rootwrap(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_2ba3e551","line":255,"range":{"start_line":251,"start_character":8,"end_line":255,"end_character":36},"updated":"2017-05-03 22:40:28.000000000","message":"Just use six.text_type.","commit_id":"24214b124d4f2cf9fdad6839ac906c90e4e9cc5e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fecdaf15a2a89807837a75172dd7f4cc27cbd8e7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        instance.display_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":250,"context_line":"        # should be a bytes string if python2 before conversion"},{"line_number":251,"context_line":"        self.assertIs(str, type(repr(instance)))"},{"line_number":252,"context_line":"        self.assertIs(six.text_type,"},{"line_number":253,"context_line":"                      type(utils.get_obj_repr_unicode(instance)))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_use_rootwrap(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_d690a498","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":21},"updated":"2017-05-03 22:51:16.000000000","message":"Should this be assertIsInstance?\n\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIs","commit_id":"564958dba6c280eb8e11ae9bbc819c7da6e204bd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62d6e09f67ba0f9a6544055f0d0937f25764d483","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        instance.display_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":250,"context_line":"        # should be a bytes string if python2 before conversion"},{"line_number":251,"context_line":"        self.assertIs(str, type(repr(instance)))"},{"line_number":252,"context_line":"        self.assertIs(six.text_type,"},{"line_number":253,"context_line":"                      type(utils.get_obj_repr_unicode(instance)))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_use_rootwrap(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_16c5ec8e","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":21},"in_reply_to":"3f044301_d690a498","updated":"2017-05-03 22:51:56.000000000","message":"oh huh\n\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIsInstance","commit_id":"564958dba6c280eb8e11ae9bbc819c7da6e204bd"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b2bdc5d58e6e4acf3f7243cf7b600a22fd02e4c","unresolved":false,"context_lines":[{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        LOG.debug(\u0027vif_type\u003d%(vif_type)s instance\u003d%(instance)s \u0027"},{"line_number":960,"context_line":"                  \u0027vif\u003d%(vif)s\u0027,"},{"line_number":961,"context_line":"                  {\u0027vif_type\u0027: vif_type, \u0027instance\u0027: six.text_type(instance),"},{"line_number":962,"context_line":"                   \u0027vif\u0027: vif})"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        if vif_type is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_65bb4872","line":961,"updated":"2017-05-03 00:17:54.000000000","message":"Looks like this doesn\u0027t help:\n\nhttp://logs.openstack.org/12/461912/2/check/gate-tempest-dsvm-cells-ubuntu-xenial/e9cb3fc/logs/screen-n-cpu.txt.gz?level\u003dTRACE\n\nBut the test doesn\u0027t always fail, probably because the server is being deleted and tempest doesn\u0027t care if it errors out.","commit_id":"5a7958a6353cb36ff2023dd3e56d9fecbab0d658"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0a92150492c4508adeaff7772298f36d62666163","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        # instance.display_name could be unicode"},{"line_number":527,"context_line":"        instance_str \u003d repr(instance)"},{"line_number":528,"context_line":"        if six.PY2:"},{"line_number":529,"context_line":"            six.text_type(instance_str, \u0027utf-8\u0027)"},{"line_number":530,"context_line":"        LOG.debug(\u0027vif_type\u003d%(vif_type)s instance\u003d%(instance)s \u0027"},{"line_number":531,"context_line":"                  \u0027vif\u003d%(vif)s virt_type\u003d%(virt_type)s\u0027,"},{"line_number":532,"context_line":"                  {\u0027vif_type\u0027: vif_type, \u0027instance\u0027: instance_str,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_a39c955d","line":529,"updated":"2017-05-03 13:44:54.000000000","message":"Sigh ... forgot to assign it to instance_str","commit_id":"9919efa32d4a4a6316ca2d1c3d6561902dce8bde"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ae5e7d24660d764833e6badadc638e73ee8be10","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        vif_type \u003d vif[\u0027type\u0027]"},{"line_number":524,"context_line":"        vnic_type \u003d vif[\u0027vnic_type\u0027]"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        # instance.display_name could be unicode"},{"line_number":527,"context_line":"        instance_repr \u003d repr(instance)"},{"line_number":528,"context_line":"        if six.PY2:"},{"line_number":529,"context_line":"            instance_repr \u003d six.text_type(instance_repr, \u0027utf-8\u0027)"},{"line_number":530,"context_line":"        LOG.debug(\u0027vif_type\u003d%(vif_type)s instance\u003d%(instance)s \u0027"},{"line_number":531,"context_line":"                  \u0027vif\u003d%(vif)s virt_type\u003d%(virt_type)s\u0027,"},{"line_number":532,"context_line":"                  {\u0027vif_type\u0027: vif_type, \u0027instance\u0027: instance_repr,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_e5688c22","line":529,"range":{"start_line":526,"start_character":8,"end_line":529,"end_character":65},"updated":"2017-05-03 21:12:25.000000000","message":"nit: we could make a little utility method for this in nova.utils or something and then just re-use that in all 4 cases in this patch.\n\nLike, nova.utils.encoded_instance_repr or something.","commit_id":"96d586ee0c114696baaa3ba3117dc7f787cb4458"}]}