)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e0fe273a6be236ea1dacd5ca4664f2a6320d894a","unresolved":false,"context_lines":[{"line_number":3932,"context_line":"@require_admin_context"},{"line_number":3933,"context_line":"def migration_update(context, id, values):"},{"line_number":3934,"context_line":"    session \u003d get_session()"},{"line_number":3935,"context_line":"    migration \u003d None"},{"line_number":3936,"context_line":"    with session.begin():"},{"line_number":3937,"context_line":"        migration \u003d _migration_get(context, id, session\u003dsession)"},{"line_number":3938,"context_line":"        migration.update(values)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F%2F9U%3D","line":3935,"updated":"2013-09-14 18:30:32.000000000","message":"I think that it is enough here just to remove save(session)","commit_id":"028268014c767b5a98ff95106fca80961280f203"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"e4bdd77636bd1dd6d8aa19692782bdaee44623ef","unresolved":false,"context_lines":[{"line_number":3932,"context_line":"@require_admin_context"},{"line_number":3933,"context_line":"def migration_update(context, id, values):"},{"line_number":3934,"context_line":"    session \u003d get_session()"},{"line_number":3935,"context_line":"    migration \u003d None"},{"line_number":3936,"context_line":"    with session.begin():"},{"line_number":3937,"context_line":"        migration \u003d _migration_get(context, id, session\u003dsession)"},{"line_number":3938,"context_line":"        migration.update(values)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F%2FuU%3D","line":3935,"in_reply_to":"AAAAS3%2F%2F%2F9U%3D","updated":"2013-09-15 03:02:49.000000000","message":"Yes , you are right .\nDone","commit_id":"028268014c767b5a98ff95106fca80961280f203"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e0fe273a6be236ea1dacd5ca4664f2a6320d894a","unresolved":false,"context_lines":[{"line_number":5021,"context_line":"                                   aggregate_id,"},{"line_number":5022,"context_line":"                                   values.pop(\u0027metadata\u0027),"},{"line_number":5023,"context_line":"                                   set_delete\u003dset_delete)"},{"line_number":5024,"context_line":"        with session.begin():"},{"line_number":5025,"context_line":"            aggregate.update(values)"},{"line_number":5026,"context_line":""},{"line_number":5027,"context_line":"        values[\u0027metadata\u0027] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F%2F9M%3D","line":5024,"updated":"2013-09-14 18:30:32.000000000","message":"Imho here we are doing only 1 request in 1 transaction, so more clear syntax will be:\njust to remove session.begin()\n\nand have:\naggregate.update(values)\naggregate.save(session\u003dsession)","commit_id":"028268014c767b5a98ff95106fca80961280f203"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"e4bdd77636bd1dd6d8aa19692782bdaee44623ef","unresolved":false,"context_lines":[{"line_number":5021,"context_line":"                                   aggregate_id,"},{"line_number":5022,"context_line":"                                   values.pop(\u0027metadata\u0027),"},{"line_number":5023,"context_line":"                                   set_delete\u003dset_delete)"},{"line_number":5024,"context_line":"        with session.begin():"},{"line_number":5025,"context_line":"            aggregate.update(values)"},{"line_number":5026,"context_line":""},{"line_number":5027,"context_line":"        values[\u0027metadata\u0027] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F%2FuQ%3D","line":5024,"in_reply_to":"AAAAS3%2F%2F%2F9M%3D","updated":"2013-09-15 03:02:49.000000000","message":"Done","commit_id":"028268014c767b5a98ff95106fca80961280f203"}]}