)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import base64"},{"line_number":25,"context_line":"import copy"},{"line_number":26,"context_line":"import os"},{"line_number":27,"context_line":"import threading"},{"line_number":28,"context_line":"import time"},{"line_number":29,"context_line":"import urllib"},{"line_number":30,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBYk%3D","line":27,"updated":"2013-09-13 11:11:14.000000000","message":"Would it be possible to leverage code in https://github.com/openstack/nova/blob/master/nova/openstack/common/lockutils.py or https://github.com/openstack/nova/blob/master/nova/openstack/common/threadgroup.py?","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"ce56a26a371af3ea489ac23e7d55df26dddf71a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import base64"},{"line_number":25,"context_line":"import copy"},{"line_number":26,"context_line":"import os"},{"line_number":27,"context_line":"import threading"},{"line_number":28,"context_line":"import time"},{"line_number":29,"context_line":"import urllib"},{"line_number":30,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FA6w%3D","line":27,"in_reply_to":"AAAASn%2F%2FBYk%3D","updated":"2013-09-13 14:42:57.000000000","message":"I looked at lockutils but it really doesn\u0027t do what i need.  I need to stop all threads on a particular condition (concurrent upload) at a particular time (before the file_exists block starts).  These utilities are not as fine grained as the control i need for this purpose.","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                                          data_store_name,"},{"line_number":393,"context_line":"                                          upload_folder,"},{"line_number":394,"context_line":"                                          upload_name)"},{"line_number":395,"context_line":"            LOG.debug(_(\"Checking for concurrent upload of %(file_name)s\") %"},{"line_number":396,"context_line":"                      {\"file_name\": name})"},{"line_number":397,"context_line":"            need_to_wait \u003d False"},{"line_number":398,"context_line":"            file_exists \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBYc%3D","line":395,"updated":"2013-09-13 11:11:14.000000000","message":"if there is one parameter you do not need to pass a dictionary as a parameter.","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            lockme \u003d threading.Condition()"},{"line_number":403,"context_line":"            with lockme:"},{"line_number":404,"context_line":"                current_upload \u003d self._current_upload_list.get(name)"},{"line_number":405,"context_line":"                if current_upload is not None:"},{"line_number":406,"context_line":"                    # The file is being uploaded, block until it\u0027s done after"},{"line_number":407,"context_line":"                    # releasing lockme"},{"line_number":408,"context_line":"                    need_to_wait \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBYU%3D","line":405,"updated":"2013-09-13 11:11:14.000000000","message":"if current_upload:","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                        # It\u0027s not there, so take out a lock for other threads"},{"line_number":417,"context_line":"                        # to wait on until the upload is complete"},{"line_number":418,"context_line":"                        LOG.debug(_(\"Locking out other threads for upload of\""},{"line_number":419,"context_line":"                                    \" %s(file_name)s\") %"},{"line_number":420,"context_line":"                                    {\"file_name\": name})"},{"line_number":421,"context_line":"                        self._current_upload_list[name] \u003d threading.Event()"},{"line_number":422,"context_line":"                        self._current_upload_list[name].clear()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBYQ%3D","line":419,"updated":"2013-09-13 11:11:14.000000000","message":"ditto","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            # Here lockme is released so other threads are not blocked while we"},{"line_number":425,"context_line":"            # wait for the upload to complete"},{"line_number":426,"context_line":"            if need_to_wait:"},{"line_number":427,"context_line":"                LOG.debug(_(\"Waiting on upload of %(file_name)s\") %"},{"line_number":428,"context_line":"                          {\"file_name\": name})"},{"line_number":429,"context_line":"                self._current_upload_list[name].wait()"},{"line_number":430,"context_line":"                file_exists \u003d self._check_if_folder_file_exists("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBYI%3D","line":427,"updated":"2013-09-13 11:11:14.000000000","message":"ditto","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            lockme \u003d threading.Condition()"},{"line_number":442,"context_line":"            with lockme:"},{"line_number":443,"context_line":"                mylock \u003d self._current_upload_list.get(name)"},{"line_number":444,"context_line":"                if mylock is not None:"},{"line_number":445,"context_line":"                    self._current_upload_list.pop(name)"},{"line_number":446,"context_line":"            if mylock is not None:"},{"line_number":447,"context_line":"                LOG.debug(_(\"Releasing all concurrent upload locks for \""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBXw%3D","line":444,"updated":"2013-09-13 11:11:14.000000000","message":"if mylock:","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                mylock \u003d self._current_upload_list.get(name)"},{"line_number":444,"context_line":"                if mylock is not None:"},{"line_number":445,"context_line":"                    self._current_upload_list.pop(name)"},{"line_number":446,"context_line":"            if mylock is not None:"},{"line_number":447,"context_line":"                LOG.debug(_(\"Releasing all concurrent upload locks for \""},{"line_number":448,"context_line":"                        \"%(file_name)s\") % {\u0027file_name\u0027: name})"},{"line_number":449,"context_line":"                mylock.set()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBXs%3D","line":446,"updated":"2013-09-13 11:11:14.000000000","message":"if mylock:","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                    self._current_upload_list.pop(name)"},{"line_number":446,"context_line":"            if mylock is not None:"},{"line_number":447,"context_line":"                LOG.debug(_(\"Releasing all concurrent upload locks for \""},{"line_number":448,"context_line":"                        \"%(file_name)s\") % {\u0027file_name\u0027: name})"},{"line_number":449,"context_line":"                mylock.set()"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBXk%3D","line":448,"updated":"2013-09-13 11:11:14.000000000","message":"no need for dict","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"            else:"},{"line_number":452,"context_line":"                LOG.error(_(\"Unable to find concurrent upload lock for \""},{"line_number":453,"context_line":"                        \"%(file_name)s\") % {\u0027file_name\u0027: name})"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        ebs_root \u003d block_device.volume_in_mapping("},{"line_number":456,"context_line":"                self._default_root_device, block_device_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBXg%3D","line":453,"updated":"2013-09-13 11:11:14.000000000","message":"ditto","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3faf0406b652013d48baa66ad5eba0ef5d0ff281","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"                time.sleep(2)"},{"line_number":1523,"context_line":"                continue"},{"line_number":1524,"context_line":"            break"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"        if task_info.state \u003d\u003d \"error\":"},{"line_number":1527,"context_line":"            return False, False"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FBXQ%3D","line":1525,"updated":"2013-09-13 11:11:14.000000000","message":"do we need this change?","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"ce56a26a371af3ea489ac23e7d55df26dddf71a4","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"                time.sleep(2)"},{"line_number":1523,"context_line":"                continue"},{"line_number":1524,"context_line":"            break"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"        if task_info.state \u003d\u003d \"error\":"},{"line_number":1527,"context_line":"            return False, False"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAASn%2F%2FA8M%3D","line":1525,"in_reply_to":"AAAASn%2F%2FBXQ%3D","updated":"2013-09-13 14:42:57.000000000","message":"There is nothing there.  I did not touch that line at all.  I went over and over it and have no idea why gerrit is reporting this changed….","commit_id":"38fd4839e4f62dcf31139b87915ced72701ad5df"}]}
