)]}'
{"nova/tests/functional/test_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c675cd94e1329f1b595173ec234725e8ce872ea2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":56,"context_line":"        # self.start_service(\u0027consoleauth\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Configure a minimal filter scheduler setup."},{"line_number":59,"context_line":"        self.flags(enabled_filters\u003d[\u0027ComputeFilter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_8b564729","line":56,"updated":"2017-05-16 07:23:13.000000000","message":"You can delete this","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"57c2dc573bae0be83a51f1efe1114287f2f70465","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":56,"context_line":"        # self.start_service(\u0027consoleauth\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Configure a minimal filter scheduler setup."},{"line_number":59,"context_line":"        self.flags(enabled_filters\u003d[\u0027ComputeFilter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_4051100e","line":56,"in_reply_to":"1f013ff3_8b564729","updated":"2017-05-17 09:38:17.000000000","message":"Done","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c675cd94e1329f1b595173ec234725e8ce872ea2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # self.start_service(\u0027consoleauth\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Configure a minimal filter scheduler setup."},{"line_number":59,"context_line":"        self.flags(enabled_filters\u003d[\u0027ComputeFilter\u0027,"},{"line_number":60,"context_line":"                                    \u0027RetryFilter\u0027,"},{"line_number":61,"context_line":"                                    \u0027AggregateMultiTenancyIsolation\u0027],"},{"line_number":62,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":63,"context_line":"        self.start_service(\u0027scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_cb0a0f25","line":60,"range":{"start_line":59,"start_character":36,"end_line":60,"end_character":50},"updated":"2017-05-16 07:23:13.000000000","message":"Is there a specific reason the test needs ComputFilter and RetryFilter to test the behavior of AggregateMultiTenancyIsolation ?","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"57c2dc573bae0be83a51f1efe1114287f2f70465","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # self.start_service(\u0027consoleauth\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Configure a minimal filter scheduler setup."},{"line_number":59,"context_line":"        self.flags(enabled_filters\u003d[\u0027ComputeFilter\u0027,"},{"line_number":60,"context_line":"                                    \u0027RetryFilter\u0027,"},{"line_number":61,"context_line":"                                    \u0027AggregateMultiTenancyIsolation\u0027],"},{"line_number":62,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":63,"context_line":"        self.start_service(\u0027scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_005b082e","line":60,"range":{"start_line":59,"start_character":36,"end_line":60,"end_character":50},"in_reply_to":"1f013ff3_cb0a0f25","updated":"2017-05-17 09:38:17.000000000","message":"Done","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c675cd94e1329f1b595173ec234725e8ce872ea2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            name\u003dname,"},{"line_number":80,"context_line":"            imageRef\u003dself.image_id,"},{"line_number":81,"context_line":"            flavorRef\u003dself.flavor_id)"},{"line_number":82,"context_line":"        server \u003d self.admin_api.post_server({\u0027server\u0027: server_details})"},{"line_number":83,"context_line":"        self.addCleanup(self.admin_api.delete_server, server[\u0027id\u0027])"},{"line_number":84,"context_line":"        if wait_for_status is not None:"},{"line_number":85,"context_line":"            server \u003d self._wait_for_instance_status(server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_2609aa2b","line":82,"range":{"start_line":82,"start_character":22,"end_line":82,"end_character":31},"updated":"2017-05-16 07:23:13.000000000","message":"do we need admin api for booting the server?","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"57c2dc573bae0be83a51f1efe1114287f2f70465","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            name\u003dname,"},{"line_number":80,"context_line":"            imageRef\u003dself.image_id,"},{"line_number":81,"context_line":"            flavorRef\u003dself.flavor_id)"},{"line_number":82,"context_line":"        server \u003d self.admin_api.post_server({\u0027server\u0027: server_details})"},{"line_number":83,"context_line":"        self.addCleanup(self.admin_api.delete_server, server[\u0027id\u0027])"},{"line_number":84,"context_line":"        if wait_for_status is not None:"},{"line_number":85,"context_line":"            server \u003d self._wait_for_instance_status(server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_2023a4aa","line":82,"range":{"start_line":82,"start_character":22,"end_line":82,"end_character":31},"in_reply_to":"1f013ff3_2609aa2b","updated":"2017-05-17 09:38:17.000000000","message":"No","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c675cd94e1329f1b595173ec234725e8ce872ea2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                    wait_for_status)"},{"line_number":87,"context_line":"        return server"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _wait_for_instance_status(self, server_id, status):"},{"line_number":90,"context_line":"        timeout \u003d 0.0"},{"line_number":91,"context_line":"        server \u003d self.admin_api.get_server(server_id)"},{"line_number":92,"context_line":"        while server[\u0027status\u0027] !\u003d status and timeout \u003c 10.0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_0627ceb5","line":89,"updated":"2017-05-16 07:23:13.000000000","message":"We have similar function already written in nova.tests.functional.integrated_helpers.InstanceHelperMixin can we reuse that?","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"57c2dc573bae0be83a51f1efe1114287f2f70465","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                    wait_for_status)"},{"line_number":87,"context_line":"        return server"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _wait_for_instance_status(self, server_id, status):"},{"line_number":90,"context_line":"        timeout \u003d 0.0"},{"line_number":91,"context_line":"        server \u003d self.admin_api.get_server(server_id)"},{"line_number":92,"context_line":"        while server[\u0027status\u0027] !\u003d status and timeout \u003c 10.0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_808ef8cd","line":89,"in_reply_to":"1f013ff3_0627ceb5","updated":"2017-05-17 09:38:17.000000000","message":"Done","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c675cd94e1329f1b595173ec234725e8ce872ea2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.addCleanup(self._remove_host_from_aggregate, aggregate_id, host)"},{"line_number":119,"context_line":"        return self.admin_api.api_post(\u0027/os-aggregates/%s/action\u0027 %"},{"line_number":120,"context_line":"                                       aggregate_id,"},{"line_number":121,"context_line":"                                       add_host_request).body[\u0027aggregate\u0027]"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_86475e4c","line":119,"updated":"2017-05-16 07:23:13.000000000","message":"I suggest to add aggregate action method to the client nova.tests.functional.api.client.TestOpenStackClient","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"},{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"57c2dc573bae0be83a51f1efe1114287f2f70465","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.addCleanup(self._remove_host_from_aggregate, aggregate_id, host)"},{"line_number":119,"context_line":"        return self.admin_api.api_post(\u0027/os-aggregates/%s/action\u0027 %"},{"line_number":120,"context_line":"                                       aggregate_id,"},{"line_number":121,"context_line":"                                       add_host_request).body[\u0027aggregate\u0027]"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_e0137c5b","line":119,"in_reply_to":"1f013ff3_86475e4c","updated":"2017-05-17 09:38:17.000000000","message":"Done","commit_id":"7580bc35fd7ad68d8d8d7ee757e576c2fb77b53e"}]}