)]}'
{"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"1c5e39f66e4a739de6a55ab6ecb0c0bd48634b8c","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    \u003csecret type\u003d\u0027passphrase\u0027 uuid\u003d\u0027a4dccc1a\u0027/\u003e"},{"line_number":837,"context_line":"  \u003c/encryption\u003e"},{"line_number":838,"context_line":"\u003c/disk\u003e\"\"\""},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        xmldoc \u003d etree.fromstring(xml)"},{"line_number":841,"context_line":"        d \u003d config.LibvirtConfigGuestDisk()"},{"line_number":842,"context_line":"        d.parse_dom(xmldoc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_74940545","line":839,"updated":"2017-05-30 10:17:17.000000000","message":"nit: It\u0027s better to align this.","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2e23972f63fd85451ee9dea08485b5a0818cc676","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    \u003csecret type\u003d\u0027passphrase\u0027 uuid\u003d\u0027a4dccc1a\u0027/\u003e"},{"line_number":837,"context_line":"  \u003c/encryption\u003e"},{"line_number":838,"context_line":"\u003c/disk\u003e\"\"\""},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        xmldoc \u003d etree.fromstring(xml)"},{"line_number":841,"context_line":"        d \u003d config.LibvirtConfigGuestDisk()"},{"line_number":842,"context_line":"        d.parse_dom(xmldoc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_f2c265e9","line":839,"in_reply_to":"df140735_74940545","updated":"2017-05-30 12:08:11.000000000","message":"I don\u0027t think there was room to align it but I\u0027ll check when I respin.","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"978338755189e3a468ba3ccb587cd8ec45d6f0d0","unresolved":false,"context_lines":[{"line_number":803,"context_line":"        d.source_path \u003d \"/tmp/hello.qcow2\""},{"line_number":804,"context_line":"        d.target_dev \u003d \"/dev/hda\""},{"line_number":805,"context_line":"        d.target_bus \u003d \"ide\""},{"line_number":806,"context_line":"        d.serial \u003d \"7a97c4a3-6f59-41d4-bf47-191d7f97f8e9\""},{"line_number":807,"context_line":"        d.boot_order \u003d \"1\""},{"line_number":808,"context_line":"        e.format \u003d \"luks\""},{"line_number":809,"context_line":"        s.type \u003d \"passphrase\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_4b4249ad","line":806,"range":{"start_line":806,"start_character":0,"end_line":806,"end_character":57},"updated":"2017-12-18 11:49:24.000000000","message":"Thought: Could use a uuid sentinel here? Not sure it\u0027s worth it, though, given the syntactic klunkiness of embedding it in the XML below.","commit_id":"940d3568234ad503ad5effbe30247c185085460d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"eb0e1280c4511eb96690ae1d5f19008bdef77fd4","unresolved":false,"context_lines":[{"line_number":803,"context_line":"        d.source_path \u003d \"/tmp/hello.qcow2\""},{"line_number":804,"context_line":"        d.target_dev \u003d \"/dev/hda\""},{"line_number":805,"context_line":"        d.target_bus \u003d \"ide\""},{"line_number":806,"context_line":"        d.serial \u003d \"7a97c4a3-6f59-41d4-bf47-191d7f97f8e9\""},{"line_number":807,"context_line":"        d.boot_order \u003d \"1\""},{"line_number":808,"context_line":"        e.format \u003d \"luks\""},{"line_number":809,"context_line":"        s.type \u003d \"passphrase\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_00d877ec","line":806,"range":{"start_line":806,"start_character":0,"end_line":806,"end_character":57},"in_reply_to":"df87a7cf_4b4249ad","updated":"2017-12-19 20:16:12.000000000","message":"There\u0027s precedent [1], but yeah, it\u0027d he hard to make it pretty.\n\n[1] https://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_neutronv2.py#L1211-L1212","commit_id":"940d3568234ad503ad5effbe30247c185085460d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"978338755189e3a468ba3ccb587cd8ec45d6f0d0","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        d.boot_order \u003d \"1\""},{"line_number":808,"context_line":"        e.format \u003d \"luks\""},{"line_number":809,"context_line":"        s.type \u003d \"passphrase\""},{"line_number":810,"context_line":"        s.uuid \u003d \"a4dccc1a\""},{"line_number":811,"context_line":"        e.secret \u003d s"},{"line_number":812,"context_line":"        d.encryption \u003d e"},{"line_number":813,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_ab31955b","line":810,"range":{"start_line":810,"start_character":0,"end_line":810,"end_character":27},"updated":"2017-12-18 11:49:24.000000000","message":"That\u0027s not a uuid. This is fairly trivial, but we\u0027ve been cleaning these up for a while.","commit_id":"940d3568234ad503ad5effbe30247c185085460d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"978338755189e3a468ba3ccb587cd8ec45d6f0d0","unresolved":false,"context_lines":[{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        self.assertEqual(d.encryption.format, \"luks\")"},{"line_number":845,"context_line":"        self.assertEqual(d.encryption.secret.type, \"passphrase\")"},{"line_number":846,"context_line":"        self.assertEqual(d.encryption.secret.uuid, \"a4dccc1a\")"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def test_config_boot_order_parse(self):"},{"line_number":849,"context_line":"        xml \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_ab0af575","line":846,"range":{"start_line":846,"start_character":52,"end_line":846,"end_character":60},"updated":"2017-12-18 11:49:24.000000000","message":"Ditto.","commit_id":"940d3568234ad503ad5effbe30247c185085460d"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"55d9af254851faf0325f9b511d5133204e416950","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1118,"context_line":"        super(LibvirtConfigGuestDiskEncryptionSecret, self).__init__(**kwargs)"},{"line_number":1119,"context_line":"        self.type \u003d None"},{"line_number":1120,"context_line":"        self.uuid \u003d None"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1123,"context_line":"        self.type \u003d xmldoc.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_0a02c33d","line":1120,"updated":"2017-05-11 15:31:06.000000000","message":"Can this be used with keys stored in Barbican? It seems like as it is currently implemented in this patch, it cannot.","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2e23972f63fd85451ee9dea08485b5a0818cc676","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1118,"context_line":"        super(LibvirtConfigGuestDiskEncryptionSecret, self).__init__(**kwargs)"},{"line_number":1119,"context_line":"        self.type \u003d None"},{"line_number":1120,"context_line":"        self.uuid \u003d None"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1123,"context_line":"        self.type \u003d xmldoc.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_7273f5e8","line":1120,"in_reply_to":"3f044301_0a02c33d","updated":"2017-05-30 12:08:11.000000000","message":"Coming back to this point, I\u0027ve raised a post on the ML around the fact that cinder is associating symmetric keys with encrypted volumes, if you have anytime I\u0027d appreciate your input on that thread.","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"1c5e39f66e4a739de6a55ab6ecb0c0bd48634b8c","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1137,"context_line":"        super(LibvirtConfigGuestDiskEncryption, self).__init__(**kwargs)"},{"line_number":1138,"context_line":"        self.format \u003d None"},{"line_number":1139,"context_line":"        self.secret \u003d None"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1142,"context_line":"        self.format \u003d xmldoc.get(\u0027format\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_74a2c59c","line":1139,"updated":"2017-05-30 10:17:17.000000000","message":"Honestly, I don\u0027t know how but it would be great to describe the relationship between classes/tags. \nI mean that LibvirtConfigGuestDiskEncryption.secret is LibvirtConfigGuestDiskEncryptionSecret\nxml example maybe?","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2e23972f63fd85451ee9dea08485b5a0818cc676","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1137,"context_line":"        super(LibvirtConfigGuestDiskEncryption, self).__init__(**kwargs)"},{"line_number":1138,"context_line":"        self.format \u003d None"},{"line_number":1139,"context_line":"        self.secret \u003d None"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1142,"context_line":"        self.format \u003d xmldoc.get(\u0027format\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_d2452172","line":1139,"in_reply_to":"df140735_74a2c59c","updated":"2017-05-30 12:08:11.000000000","message":"I\u0027ll add a comment here detailing it.","commit_id":"a549d00bd7dc3c03cfb2ad6180a599a8566e8428"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"eb0e1280c4511eb96690ae1d5f19008bdef77fd4","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1120,"context_line":"        super(LibvirtConfigGuestDiskEncryptionSecret, self).__init__(**kwargs)"},{"line_number":1121,"context_line":"        self.type \u003d None"},{"line_number":1122,"context_line":"        self.uuid \u003d None"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1125,"context_line":"        self.type \u003d xmldoc.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_c027efc6","line":1122,"updated":"2017-12-19 20:16:12.000000000","message":"Do we care about specifying the cipher at all? Can we ever get into a situation where there\u0027s a difference between the encryption actually used on the volume and what the libvirt defaults are?","commit_id":"940d3568234ad503ad5effbe30247c185085460d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"272529aec74746a1dfabf093c8dcf33699fc42ed","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"    def __init__(self, **kwargs):"},{"line_number":1120,"context_line":"        super(LibvirtConfigGuestDiskEncryptionSecret, self).__init__(**kwargs)"},{"line_number":1121,"context_line":"        self.type \u003d None"},{"line_number":1122,"context_line":"        self.uuid \u003d None"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    def parse_dom(self, xmldoc):"},{"line_number":1125,"context_line":"        self.type \u003d xmldoc.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_7beed622","line":1122,"in_reply_to":"df87a7cf_c027efc6","updated":"2017-12-20 08:35:28.000000000","message":"The cipher options are only used for volume creation when using storage pools, we don\u0027t use these at present:\n\nhttps://libvirt.org/formatstorageencryption.html#StorageEncryptionLuks","commit_id":"940d3568234ad503ad5effbe30247c185085460d"}]}