)]}'
{"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d01fd03d0dca53e4199072949d8093fbe2f8e53","unresolved":false,"context_lines":[{"line_number":3241,"context_line":"                self.context, instance, clean_shutdown\u003dTrue)"},{"line_number":3242,"context_line":""},{"line_number":3243,"context_line":"    @mock.patch.object(objects.Instance, \u0027save\u0027)"},{"line_number":3244,"context_line":"    def test_get_block_device_info_with_root_device_name(self, mock_save):"},{"line_number":3245,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":3246,"context_line":"        block_device_mapping \u003d []"},{"line_number":3247,"context_line":"        instance.root_device_name \u003d \u0027/dev/vda\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_487e01e5","line":3244,"range":{"start_line":3244,"start_character":0,"end_line":3244,"end_character":74},"updated":"2017-06-12 13:58:52.000000000","message":"Could we get a docstring for these tests to explain the intention of the test?","commit_id":"70d536b0d7fc539daebd562c9e6ac030673124c0"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"e8c7ed41d1ec06cf78ce78592c00ab6b9e7dad81","unresolved":false,"context_lines":[{"line_number":3247,"context_line":"        # in its return value."},{"line_number":3248,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":3249,"context_line":"        block_device_mapping \u003d []"},{"line_number":3250,"context_line":"        instance.root_device_name \u003d \u0027/dev/vda\u0027"},{"line_number":3251,"context_line":"        instance.save()"},{"line_number":3252,"context_line":"        block_device_info \u003d self.compute._prep_block_device(self.context,"},{"line_number":3253,"context_line":"                                         instance,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_c9cf3754","line":3250,"range":{"start_line":3250,"start_character":8,"end_line":3250,"end_character":46},"updated":"2017-11-25 05:37:47.000000000","message":"do we maybe want to use an unusual name to emphasize the purpose of the testcase?","commit_id":"8051033b3fbfb6ad4d2cee6e13d4dee72233a5df"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"e8c7ed41d1ec06cf78ce78592c00ab6b9e7dad81","unresolved":false,"context_lines":[{"line_number":3257,"context_line":""},{"line_number":3258,"context_line":"    @mock.patch.object(objects.Instance, \u0027save\u0027)"},{"line_number":3259,"context_line":"    def test_get_block_device_info_with_no_root_device_name(self, mock_save):"},{"line_number":3260,"context_line":"        # Tests that if clear the root_device_name in instance will lead"},{"line_number":3261,"context_line":"        # to set the root_device_name to None in the _prep_block_device"},{"line_number":3262,"context_line":"        # function return value."},{"line_number":3263,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":3264,"context_line":"        block_device_mapping \u003d []"},{"line_number":3265,"context_line":"        instance.root_device_name \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_292d83fd","line":3262,"range":{"start_line":3260,"start_character":9,"end_line":3262,"end_character":32},"updated":"2017-11-25 05:37:47.000000000","message":"it would be more effective to have it be *not* None originally, and then clear the root device name in the instance and call _prep_block_device() and have it be None.  If that\u0027s too hard to implement then don\u0027t worry about it. :)","commit_id":"8051033b3fbfb6ad4d2cee6e13d4dee72233a5df"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d01fd03d0dca53e4199072949d8093fbe2f8e53","unresolved":false,"context_lines":[{"line_number":3299,"context_line":"        self.assertIsInstance(cfg.devices[2],"},{"line_number":3300,"context_line":"                              vconfig.LibvirtConfigGuestConsole)"},{"line_number":3301,"context_line":""},{"line_number":3302,"context_line":"    def test_get_guest_config_with_img_disk_bus_and_root_device_name(self):"},{"line_number":3303,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3304,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":3305,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f231b9d_a82115fe","line":3302,"range":{"start_line":3302,"start_character":0,"end_line":3302,"end_character":75},"updated":"2017-06-12 13:58:52.000000000","message":"Could we get a docstring for each of these tests to explain the intention of the test?","commit_id":"70d536b0d7fc539daebd562c9e6ac030673124c0"},{"author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"change_message_id":"87c6309630f581fe1807d38c790e6be24e2d6954","unresolved":false,"context_lines":[{"line_number":3321,"context_line":"        self.assertEqual(cfg.devices[0].target_dev, \u0027vda\u0027)"},{"line_number":3322,"context_line":"        self.assertEqual(cfg.devices[0].target_bus, \u0027virtio\u0027)"},{"line_number":3323,"context_line":""},{"line_number":3324,"context_line":"    def test_get_guest_config_with_img_disk_bus_and_no_root_device_name(self):"},{"line_number":3325,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3326,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":3327,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_2d7a7c87","line":3324,"range":{"start_line":3324,"start_character":8,"end_line":3324,"end_character":71},"updated":"2017-06-23 09:47:51.000000000","message":"shall we add doctoring here and remove the first test (def test_get_guest_config_with_img_disk_bus_and_root_device_name(self))\n\nthe first test says \"even if we change disk bus, but the result get_guest_config is still wrong\". \nActually what we do in this fix is to limit the root_divice_name to None if disk_bus is  different. \nSo the first test_get_guest_config_with_img_disk_bus_and_root_device_name is not a meaningful test in my point","commit_id":"70d536b0d7fc539daebd562c9e6ac030673124c0"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"e8c7ed41d1ec06cf78ce78592c00ab6b9e7dad81","unresolved":false,"context_lines":[{"line_number":3301,"context_line":""},{"line_number":3302,"context_line":"    def test_get_guest_config_with_img_disk_bus_and_root_device_name(self):"},{"line_number":3303,"context_line":"        # Tests that if have the root_device_name in block_device_info,"},{"line_number":3304,"context_line":"        # the image defined disk bus type will be ignored, maybe set a"},{"line_number":3305,"context_line":"        # wrong disk bus type."},{"line_number":3306,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":3307,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":3308,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_e9323b5e","line":3305,"range":{"start_line":3304,"start_character":45,"end_line":3305,"end_character":30},"updated":"2017-11-25 05:37:47.000000000","message":"the phrase \"...will be ignored, maybe set a wrong disk bus type\" is not clear.  Did you intend to say \"...will be ignored, since it might set the wrong disk bus type\"?","commit_id":"8051033b3fbfb6ad4d2cee6e13d4dee72233a5df"}]}