)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"92203322919ca2cb5f63b76957b969a37b9704fa","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"            compute_utils.notify_about_resize_instance("},{"line_number":3791,"context_line":"                context, instance, self.host,"},{"line_number":3792,"context_line":"                action\u003dfields.NotificationAction.RESIZE_PREP,"},{"line_number":3793,"context_line":"                phase\u003dfields.NotificationPhase.START)"},{"line_number":3794,"context_line":"            try:"},{"line_number":3795,"context_line":"                self._prep_resize(context, image, instance,"},{"line_number":3796,"context_line":"                                  instance_type, quotas,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_655a4683","line":3793,"range":{"start_line":3793,"start_character":52,"end_line":3793,"end_character":53},"updated":"2017-05-25 08:32:36.000000000","message":"new_flavor\u003dinstance_type should be added.","commit_id":"7537a524b93f2c8ebe2c08eb7440a306a467a0ad"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"3a1f20fde1a901f47ef5f5a340da518517af7178","unresolved":false,"context_lines":[{"line_number":3790,"context_line":"            compute_utils.notify_about_resize_instance("},{"line_number":3791,"context_line":"                context, instance, self.host,"},{"line_number":3792,"context_line":"                action\u003dfields.NotificationAction.RESIZE_PREP,"},{"line_number":3793,"context_line":"                phase\u003dfields.NotificationPhase.START)"},{"line_number":3794,"context_line":"            try:"},{"line_number":3795,"context_line":"                self._prep_resize(context, image, instance,"},{"line_number":3796,"context_line":"                                  instance_type, quotas,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_701fa66b","line":3793,"range":{"start_line":3793,"start_character":52,"end_line":3793,"end_character":53},"in_reply_to":"ff0f0b1f_655a4683","updated":"2017-05-25 09:12:08.000000000","message":"I think it would cause inconsistency with the legacy notification.","commit_id":"7537a524b93f2c8ebe2c08eb7440a306a467a0ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"335cb11033bdbe7a1d96aec6641d3da121181120","unresolved":false,"context_lines":[{"line_number":3772,"context_line":"                        new_instance_type\u003dinstance_type.name,"},{"line_number":3773,"context_line":"                        new_instance_type_id\u003dinstance_type.id)"},{"line_number":3774,"context_line":""},{"line_number":3775,"context_line":"                self._notify_about_instance_usage("},{"line_number":3776,"context_line":"                    context, instance, \"resize.prep.end\","},{"line_number":3777,"context_line":"                    extra_usage_info\u003dextra_usage_info)"},{"line_number":3778,"context_line":"                compute_utils.notify_about_resize_instance("},{"line_number":3779,"context_line":"                    context, instance, self.host,"},{"line_number":3780,"context_line":"                    phase\u003dfields.NotificationPhase.END,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7f287b81_1ab5d7cd","line":3777,"range":{"start_line":3775,"start_character":0,"end_line":3777,"end_character":54},"updated":"2017-08-24 15:53:49.000000000","message":"Are these supposed to be here still?","commit_id":"75f76cc74e9b2395b8a05798d4970f67f20d1480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3750cd59dddf9d3706c43e56336f97afbe5c8b74","unresolved":false,"context_lines":[{"line_number":4134,"context_line":"                        exc_info, instance_type, request_spec,"},{"line_number":4135,"context_line":"                        filter_properties)"},{"line_number":4136,"context_line":"            finally:"},{"line_number":4137,"context_line":"                extra_usage_info \u003d dict("},{"line_number":4138,"context_line":"                        new_instance_type\u003dinstance_type.name,"},{"line_number":4139,"context_line":"                        new_instance_type_id\u003dinstance_type.id)"},{"line_number":4140,"context_line":""},{"line_number":4141,"context_line":"                self._notify_about_instance_usage("},{"line_number":4142,"context_line":"                    context, instance, \"resize.prep.end\","}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_4d32c0f3","line":4139,"range":{"start_line":4137,"start_character":16,"end_line":4139,"end_character":62},"updated":"2018-01-25 17:34:03.000000000","message":"Yeah I guess I missed this before.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4a3d6670f9b8a3e5282084f740b634bf7e2a55bf","unresolved":false,"context_lines":[{"line_number":4228,"context_line":"            instance.task_state \u003d task_states.RESIZE_MIGRATING"},{"line_number":4229,"context_line":"            instance.save(expected_task_state\u003dtask_states.RESIZE_PREP)"},{"line_number":4230,"context_line":""},{"line_number":4231,"context_line":"            self._notify_about_instance_usage("},{"line_number":4232,"context_line":"                context, instance, \"resize.start\", network_info\u003dnetwork_info)"},{"line_number":4233,"context_line":""},{"line_number":4234,"context_line":"            bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4235,"context_line":"                    context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_0bf91c7f","line":4232,"range":{"start_line":4231,"start_character":0,"end_line":4232,"end_character":77},"updated":"2018-01-25 00:49:07.000000000","message":"In old notifications, flavor information is not included in other resize actions.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b25b63310c9910cbd7e50a5144a5501f3e4a20da","unresolved":false,"context_lines":[{"line_number":4234,"context_line":"            bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4235,"context_line":"                    context, instance.uuid)"},{"line_number":4236,"context_line":""},{"line_number":4237,"context_line":"            compute_utils.notify_about_instance_action(context, instance,"},{"line_number":4238,"context_line":"                   self.host, action\u003dfields.NotificationAction.RESIZE,"},{"line_number":4239,"context_line":"                   phase\u003dfields.NotificationPhase.START, bdms\u003dbdms)"},{"line_number":4240,"context_line":""},{"line_number":4241,"context_line":"            block_device_info \u003d self._get_instance_block_device_info("},{"line_number":4242,"context_line":"                                context, instance, bdms\u003dbdms)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_5287e2d8","line":4239,"range":{"start_line":4237,"start_character":12,"end_line":4239,"end_character":67},"updated":"2018-01-24 19:38:19.000000000","message":"Now that I look at this, it seems odd that we have a specific payload for resize_prep which includes the new_flavor but we don\u0027t have that for the other resize payloads.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b4eaa911b7c899e23e0afcc7eb34a31508d3467a","unresolved":false,"context_lines":[{"line_number":4234,"context_line":"            bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4235,"context_line":"                    context, instance.uuid)"},{"line_number":4236,"context_line":""},{"line_number":4237,"context_line":"            compute_utils.notify_about_instance_action(context, instance,"},{"line_number":4238,"context_line":"                   self.host, action\u003dfields.NotificationAction.RESIZE,"},{"line_number":4239,"context_line":"                   phase\u003dfields.NotificationPhase.START, bdms\u003dbdms)"},{"line_number":4240,"context_line":""},{"line_number":4241,"context_line":"            block_device_info \u003d self._get_instance_block_device_info("},{"line_number":4242,"context_line":"                                context, instance, bdms\u003dbdms)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_ea506035","line":4239,"range":{"start_line":4237,"start_character":12,"end_line":4239,"end_character":67},"in_reply_to":"5f93b717_5287e2d8","updated":"2018-01-25 09:04:31.000000000","message":"Yeah, as Takashi pointed out, these transformation follows the legacy notification pattern about what to include. I think we can discuss separately to normalize some of the notifications.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"}],"nova/compute/utils.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dfb8262bcdea68e82c4bc15af106f69edd0960ac","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        fault\u003dfault,"},{"line_number":449,"context_line":"        new_flavor\u003dnew_flavor)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    print(\u0027KAPA\u0027, str(payload))"},{"line_number":452,"context_line":"    print(\u0027CAPA\u0027, str(new_flavor))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    instance_notification.InstanceActionResizeNotification("},{"line_number":455,"context_line":"        context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_1d0ed43a","line":452,"range":{"start_line":451,"start_character":0,"end_line":452,"end_character":34},"updated":"2017-05-17 07:40:27.000000000","message":"These lines should be removed.","commit_id":"dd30a0e57cc57422eb128cc5a4d9ae5a7892c5ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c9806d363da5b028935ef100ddc05517c77750cd","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"def notify_about_resize_instance(context, instance, host, action, phase,"},{"line_number":432,"context_line":"                                 new_flavor\u003dNone, exception\u003dNone):"},{"line_number":433,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":434,"context_line":"       on the instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_2a8b4e6e","line":431,"range":{"start_line":431,"start_character":58,"end_line":431,"end_character":64},"updated":"2017-06-15 08:50:37.000000000","message":"Will this function be used for just the prep_resize or for other resize action as well? if this is just for the prep_resize then we don\u0027t need to pass action in as that can be hardcoded.","commit_id":"1f6be1cdbf2a7c4724e2ba875df13bb1cab76082"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c9806d363da5b028935ef100ddc05517c77750cd","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"def notify_about_resize_instance(context, instance, host, action, phase,"},{"line_number":432,"context_line":"                                 new_flavor\u003dNone, exception\u003dNone):"},{"line_number":433,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":434,"context_line":"       on the instance"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_2aa22efe","line":432,"range":{"start_line":432,"start_character":50,"end_line":432,"end_character":64},"updated":"2017-06-15 08:50:37.000000000","message":"as there is no pre_resize.error notification this functions is never called with any exception","commit_id":"1f6be1cdbf2a7c4724e2ba875df13bb1cab76082"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c9806d363da5b028935ef100ddc05517c77750cd","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    :param exception: an exception"},{"line_number":443,"context_line":"    \"\"\""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    fault, priority \u003d _get_fault_and_priority_from_exc(exception)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    new_flavor_payload \u003d None"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_eaa7960a","line":445,"updated":"2017-06-15 08:50:37.000000000","message":"we can just hardcode priority to INFO as there is no error notification","commit_id":"1f6be1cdbf2a7c4724e2ba875df13bb1cab76082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3fc95d52951f96a6b834d2c1caa80dd48f41af85","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    :param instance: the instance which the action performed on"},{"line_number":486,"context_line":"    :param host: the host emitting the notification"},{"line_number":487,"context_line":"    :param phase: the phase of the action"},{"line_number":488,"context_line":"    :param new_flavor: new flavor if exists"},{"line_number":489,"context_line":"    \"\"\""},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    new_flavor_payload \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_5fafbee2","line":488,"range":{"start_line":488,"start_character":4,"end_line":488,"end_character":43},"updated":"2017-06-22 14:07:54.000000000","message":"Out of curiosity, when would this/wouldn\u0027t this be set?","commit_id":"5fd57882c15da368eb658e575489e12675467b9b"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"52a880d11ece3779c08f3f3a6471cd045e726e74","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    :param instance: the instance which the action performed on"},{"line_number":486,"context_line":"    :param host: the host emitting the notification"},{"line_number":487,"context_line":"    :param phase: the phase of the action"},{"line_number":488,"context_line":"    :param new_flavor: new flavor if exists"},{"line_number":489,"context_line":"    \"\"\""},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    new_flavor_payload \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f1d235d_e0448b1d","line":488,"range":{"start_line":488,"start_character":4,"end_line":488,"end_character":43},"in_reply_to":"5f201791_5fafbee2","updated":"2017-07-03 15:56:12.000000000","message":"On line 3831 in nova/compute/manager.py, when resize_prep is starting, we do not set it. This is because of the legacy notification did it the same way, and in this patchset, I just converted the legacy behavior to the versioned notification framework. Enhancing the behavior is not intended in this patchset.","commit_id":"5fd57882c15da368eb658e575489e12675467b9b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e3d3ea0af38b97645bca4e27a0c8e0bfbc54cbf3","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        context\u003dcontext,"},{"line_number":520,"context_line":"        priority\u003dfields.NotificationPriority.INFO,"},{"line_number":521,"context_line":"        publisher\u003dnotification_base.NotificationPublisher("},{"line_number":522,"context_line":"            host\u003dhost, binary\u003d\u0027nova-compute\u0027),"},{"line_number":523,"context_line":"        event_type\u003dnotification_base.EventType("},{"line_number":524,"context_line":"            object\u003d\u0027instance\u0027,"},{"line_number":525,"context_line":"            action\u003dfields.NotificationAction.RESIZE_PREP,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f287b81_237195df","line":522,"range":{"start_line":522,"start_character":23,"end_line":522,"end_character":29},"updated":"2017-09-05 03:00:56.000000000","message":"It should be \u0027source\u0027.\n\u0027binary\u0027 has been changed to \u0027source\u0027 since the following patch.\n\nhttps://review.openstack.org/#/c/487126/","commit_id":"e8496c61108c7ee76bbad5807d3dc921a2ef17ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b25b63310c9910cbd7e50a5144a5501f3e4a20da","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def notify_about_resize_instance(context, instance, host, phase, new_flavor):"},{"line_number":566,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":567,"context_line":"       on the instance"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_32ffb668","line":565,"range":{"start_line":565,"start_character":17,"end_line":565,"end_character":23},"updated":"2018-01-24 19:38:19.000000000","message":"Should we call this \"resize_prep\" to be specific? There are several phases to a resize operation.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b25b63310c9910cbd7e50a5144a5501f3e4a20da","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def notify_about_resize_instance(context, instance, host, phase, new_flavor):"},{"line_number":566,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":567,"context_line":"       on the instance"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_d2d692f2","line":565,"updated":"2018-01-24 19:38:19.000000000","message":"This needs the @rpc.if_notifications_enabled decorator.","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4a3d6670f9b8a3e5282084f740b634bf7e2a55bf","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def notify_about_resize_instance(context, instance, host, phase, new_flavor):"},{"line_number":566,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":567,"context_line":"       on the instance"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_8b276cb7","line":565,"range":{"start_line":565,"start_character":17,"end_line":565,"end_character":23},"in_reply_to":"5f93b717_32ffb668","updated":"2018-01-25 00:49:07.000000000","message":"Done","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b4eaa911b7c899e23e0afcc7eb34a31508d3467a","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def notify_about_resize_instance(context, instance, host, phase, new_flavor):"},{"line_number":566,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":567,"context_line":"       on the instance"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_6a5c504b","line":565,"in_reply_to":"5f93b717_d2d692f2","updated":"2018-01-25 09:04:31.000000000","message":"+1 good catch","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4a3d6670f9b8a3e5282084f740b634bf7e2a55bf","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        payload\u003dpayload).emit(context)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def notify_about_resize_instance(context, instance, host, phase, new_flavor):"},{"line_number":566,"context_line":"    \"\"\"Send versioned notification about the instance resize action"},{"line_number":567,"context_line":"       on the instance"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_ab2ca899","line":565,"in_reply_to":"5f93b717_d2d692f2","updated":"2018-01-25 00:49:07.000000000","message":"Done","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"10b0512d195f084220db58cd9aa08b9dbd8e8765","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        context\u003dcontext,"},{"line_number":585,"context_line":"        priority\u003dfields.NotificationPriority.INFO,"},{"line_number":586,"context_line":"        publisher\u003dnotification_base.NotificationPublisher("},{"line_number":587,"context_line":"            host\u003dhost, source\u003dfields.NotificationSource.COMPUTE),"},{"line_number":588,"context_line":"        event_type\u003dnotification_base.EventType("},{"line_number":589,"context_line":"            object\u003d\u0027instance\u0027,"},{"line_number":590,"context_line":"            action\u003dfields.NotificationAction.RESIZE_PREP,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f93b717_27cc3a34","line":587,"range":{"start_line":587,"start_character":24,"end_line":587,"end_character":63},"updated":"2018-01-25 13:33:29.000000000","message":"i think this hard coded is ok as compute only does resize","commit_id":"d775dd7066af165c01be68a211acafddc3c5b3f1"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6264575920dc5645c3e95c6b8c79081a2f2dd29d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                tags\u003dtags)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class InstanceActionResizePayload(InstanceActionPayload):"},{"line_number":197,"context_line":"    # No SCHEMA as all the additional fields are calculated"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_238798da","line":196,"updated":"2017-05-17 12:47:21.000000000","message":"You have to add @nova_base.NovaObjectRegistry.register_notification decorator to the payload class to make the ovo inheritance work","commit_id":"dd30a0e57cc57422eb128cc5a4d9ae5a7892c5ea"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"92203322919ca2cb5f63b76957b969a37b9704fa","unresolved":false,"context_lines":[{"line_number":196,"context_line":"@nova_base.NovaObjectRegistry.register_notification"},{"line_number":197,"context_line":"class InstanceActionResizePayload(InstanceActionPayload):"},{"line_number":198,"context_line":"    # No SCHEMA as all the additional fields are calculated"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":201,"context_line":"    fields \u003d {"},{"line_number":202,"context_line":"        \u0027new_flavor\u0027: fields.ObjectField(\u0027FlavorPayload\u0027, nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_05714a76","line":199,"updated":"2017-05-25 08:32:36.000000000","message":"nit: Add the following comment.\n\n# Version 1.0: Initial version","commit_id":"7537a524b93f2c8ebe2c08eb7440a306a467a0ad"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a45abf2fa8395d5ef5eb353481133bbaeb6df380","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        super(InstanceActionResizePayload, self).__init__("},{"line_number":197,"context_line":"                instance\u003dinstance,"},{"line_number":198,"context_line":"                fault\u003dfault,"},{"line_number":199,"context_line":"                new_flavor\u003dnew_flavor)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_15bf15fc","line":199,"range":{"start_line":199,"start_character":15,"end_line":199,"end_character":37},"updated":"2017-06-12 04:33:05.000000000","message":"Remove this argument.\nAdd the following line.\n\nself.new_flavor \u003d new_flavor","commit_id":"d3ad93b7a76cc8a0973ee79185ff8d581d8625dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b25b63310c9910cbd7e50a5144a5501f3e4a20da","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"@nova_base.NovaObjectRegistry.register_notification"},{"line_number":219,"context_line":"class InstanceActionResizePayload(InstanceActionPayload):"},{"line_number":220,"context_line":"    # No SCHEMA as all the additional fields are calculated"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_521282b3","line":219,"range":{"start_line":219,"start_character":20,"end_line":219,"end_character":26},"updated":"2018-01-24 19:38:19.000000000","message":"How about \"ResizePrepPayload\"? The reason I\u0027m asking is because we already have a resize.start/end notification and that doesn\u0027t include a new_flavor in it, but this one does. Did we mess up the other resize.start/end payload by omitting the new_flavor?","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4a3d6670f9b8a3e5282084f740b634bf7e2a55bf","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"@nova_base.NovaObjectRegistry.register_notification"},{"line_number":219,"context_line":"class InstanceActionResizePayload(InstanceActionPayload):"},{"line_number":220,"context_line":"    # No SCHEMA as all the additional fields are calculated"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_b0c2d9e8","line":219,"range":{"start_line":219,"start_character":20,"end_line":219,"end_character":26},"in_reply_to":"5f93b717_521282b3","updated":"2018-01-25 00:49:07.000000000","message":"Done","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b25b63310c9910cbd7e50a5144a5501f3e4a20da","unresolved":false,"context_lines":[{"line_number":551,"context_line":"@base.notification_sample(\u0027instance-resize_prep-start.json\u0027)"},{"line_number":552,"context_line":"@base.notification_sample(\u0027instance-resize_prep-end.json\u0027)"},{"line_number":553,"context_line":"@nova_base.NovaObjectRegistry.register_notification"},{"line_number":554,"context_line":"class InstanceActionResizeNotification(base.NotificationBase):"},{"line_number":555,"context_line":"    # Version 1.0: Initial version"},{"line_number":556,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_f2262e17","line":554,"range":{"start_line":554,"start_character":20,"end_line":554,"end_character":26},"updated":"2018-01-24 19:38:19.000000000","message":"ResizePrep?","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4a3d6670f9b8a3e5282084f740b634bf7e2a55bf","unresolved":false,"context_lines":[{"line_number":551,"context_line":"@base.notification_sample(\u0027instance-resize_prep-start.json\u0027)"},{"line_number":552,"context_line":"@base.notification_sample(\u0027instance-resize_prep-end.json\u0027)"},{"line_number":553,"context_line":"@nova_base.NovaObjectRegistry.register_notification"},{"line_number":554,"context_line":"class InstanceActionResizeNotification(base.NotificationBase):"},{"line_number":555,"context_line":"    # Version 1.0: Initial version"},{"line_number":556,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":557,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f93b717_10762dda","line":554,"range":{"start_line":554,"start_character":20,"end_line":554,"end_character":26},"in_reply_to":"5f93b717_f2262e17","updated":"2018-01-25 00:49:07.000000000","message":"Done","commit_id":"49917c3066f97e698dc58d894f948efe3c31fa07"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dfb8262bcdea68e82c4bc15af106f69edd0960ac","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self._wait_for_state_change(self.api, server, \u0027VERIFY_RESIZE\u0027)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # mostmar 6 jon, innen folytatni!!"},{"line_number":526,"context_line":"        print(fake_notifier.VERSIONED_NOTIFICATIONS)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        self.assertEqual(6, len(fake_notifier.VERSIONED_NOTIFICATIONS))"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_78796691","line":526,"range":{"start_line":526,"start_character":0,"end_line":526,"end_character":52},"updated":"2017-05-17 07:40:27.000000000","message":"It should be removed.","commit_id":"dd30a0e57cc57422eb128cc5a4d9ae5a7892c5ea"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3fc95d52951f96a6b834d2c1caa80dd48f41af85","unresolved":false,"context_lines":[{"line_number":5093,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {}, {},"},{"line_number":5094,"context_line":"                                            block_device_mapping\u003d[])"},{"line_number":5095,"context_line":"        time_fixture.advance_time_delta(cur_time - old_time)"},{"line_number":5096,"context_line":"        fake_notifier.NOTIFICATIONS \u003d []"},{"line_number":5097,"context_line":""},{"line_number":5098,"context_line":"        instance.host \u003d \u0027foo\u0027"},{"line_number":5099,"context_line":"        instance.task_state \u003d task_states.RESIZE_PREP"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_5f98debe","line":5096,"range":{"start_line":5096,"start_character":8,"end_line":5096,"end_character":40},"updated":"2017-06-22 14:07:54.000000000","message":"Is this still necessary, given that we\u0027re mocking out the notifier above?","commit_id":"5fd57882c15da368eb658e575489e12675467b9b"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"52a880d11ece3779c08f3f3a6471cd045e726e74","unresolved":false,"context_lines":[{"line_number":5093,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {}, {},"},{"line_number":5094,"context_line":"                                            block_device_mapping\u003d[])"},{"line_number":5095,"context_line":"        time_fixture.advance_time_delta(cur_time - old_time)"},{"line_number":5096,"context_line":"        fake_notifier.NOTIFICATIONS \u003d []"},{"line_number":5097,"context_line":""},{"line_number":5098,"context_line":"        instance.host \u003d \u0027foo\u0027"},{"line_number":5099,"context_line":"        instance.task_state \u003d task_states.RESIZE_PREP"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f1d235d_a0aa13cf","line":5096,"range":{"start_line":5096,"start_character":8,"end_line":5096,"end_character":40},"in_reply_to":"5f201791_5f98debe","updated":"2017-07-03 15:56:12.000000000","message":"Yes, I think it is still necessary as we only mock our versioned notifier method. So other methods (legacy notifier for example) are also using fake_notifier, and generates notifications which we want to reset.\n\nI just quickly looked at it, and for example instance creation generates some notifications. To be future proof, after starting an instance we reset the notifier so we just rely on the number of notifications we send. So I think leaving this here is valid.","commit_id":"5fd57882c15da368eb658e575489e12675467b9b"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dfb8262bcdea68e82c4bc15af106f69edd0960ac","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    \u0027InstanceActionVolumeSwapNotification\u0027:"},{"line_number":364,"context_line":"    \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":365,"context_line":"    \u0027InstanceActionVolumeSwapPayload\u0027: \u00271.2-d7925b763e0795f8e5c1aa0e95bd67bd\u0027,"},{"line_number":366,"context_line":"    \u0027InstanceActionResizeNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":367,"context_line":"    \u0027InstanceActionResizePayload\u0027: \u00271.0-5a47c36bbe135796630770a73859288d\u0027,"},{"line_number":368,"context_line":"    \u0027InstancePayload\u0027: \u00271.2-a1988f6fe728bd4b478353a85c48ad55\u0027,"},{"line_number":369,"context_line":"    \u0027InstanceStateUpdatePayload\u0027: \u00271.0-07e111c0fa0f6db0f79b0726d593e3da\u0027,"},{"line_number":370,"context_line":"    \u0027InstanceUpdateNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_f83b36c5","line":367,"range":{"start_line":366,"start_character":0,"end_line":367,"end_character":74},"updated":"2017-05-17 07:40:27.000000000","message":"In alphabetical order, they should be just after \u0027InstanceActionPayload\u0027 (line 360).","commit_id":"dd30a0e57cc57422eb128cc5a4d9ae5a7892c5ea"}]}