)]}'
{"nova/policies/networks.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"836765e81c1a5f0cda5910ddaa5316fb27a92ad0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"This policy checks permission on security groups related APIs."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":30,"context_line":"deprecated.\"\"\","},{"line_number":31,"context_line":"        ["},{"line_number":32,"context_line":"            {"},{"line_number":33,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_197719d7","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":10},"updated":"2017-05-19 14:11:57.000000000","message":"It looks like most (maybe all?) of these only worked with nova-network? Was looking at the implemention for things like disassociate in the neturon network_api, for example.","commit_id":"b9baf3ef9fc123bf1799396bdbf7b823fb152af8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ea04e3e218afca434b99dbf09c027dfeeb787d5c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"This policy checks permission on security groups related APIs."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":30,"context_line":"deprecated.\"\"\","},{"line_number":31,"context_line":"        ["},{"line_number":32,"context_line":"            {"},{"line_number":33,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_4a12915a","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":10},"in_reply_to":"ff0f0b1f_197719d7","updated":"2017-05-29 08:18:06.000000000","message":"yes, that true. only GET is something works with neutron enabled.","commit_id":"b9baf3ef9fc123bf1799396bdbf7b823fb152af8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"052f89ce2c1ba98f95175a01680c73c5571909e6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    base.create_rule_default("},{"line_number":25,"context_line":"        BASE_POLICY_NAME,"},{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"This policy checks permission on security groups related APIs."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are only available with nova-network which is deprecated.\"\"\","},{"line_number":30,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6a88b51e","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":73},"updated":"2017-05-29 08:42:20.000000000","message":"Can you reword this in the imperative mood and state what the APIs actually do, e.g.:\n\n    Create, list, and delete security groups.\n\n??","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed85d286db64990701b97c6f38624329657e07de","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    base.create_rule_default("},{"line_number":25,"context_line":"        BASE_POLICY_NAME,"},{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"This policy checks permission on security groups related APIs."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are only available with nova-network which is deprecated.\"\"\","},{"line_number":30,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_84abecd4","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":73},"in_reply_to":"df140735_6a88b51e","updated":"2017-05-30 05:06:36.000000000","message":"done.","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"052f89ce2c1ba98f95175a01680c73c5571909e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    base.create_rule_default("},{"line_number":49,"context_line":"        POLICY_ROOT % \u0027view\u0027,"},{"line_number":50,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":51,"context_line":"        \"\"\"Lists networks for the project and Show details for a network."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":54,"context_line":"deprecated.\"\"\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_2a7abd23","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":16},"updated":"2017-05-29 08:42:20.000000000","message":"List","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"052f89ce2c1ba98f95175a01680c73c5571909e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    base.create_rule_default("},{"line_number":49,"context_line":"        POLICY_ROOT % \u0027view\u0027,"},{"line_number":50,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":51,"context_line":"        \"\"\"Lists networks for the project and Show details for a network."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":54,"context_line":"deprecated.\"\"\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_ea73a54c","line":51,"range":{"start_line":51,"start_character":46,"end_line":51,"end_character":50},"updated":"2017-05-29 08:42:20.000000000","message":"s/Show/show","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed85d286db64990701b97c6f38624329657e07de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    base.create_rule_default("},{"line_number":49,"context_line":"        POLICY_ROOT % \u0027view\u0027,"},{"line_number":50,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":51,"context_line":"        \"\"\"Lists networks for the project and Show details for a network."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":54,"context_line":"deprecated.\"\"\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_64b8d829","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":16},"in_reply_to":"df140735_2a7abd23","updated":"2017-05-30 05:06:36.000000000","message":"done","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed85d286db64990701b97c6f38624329657e07de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    base.create_rule_default("},{"line_number":49,"context_line":"        POLICY_ROOT % \u0027view\u0027,"},{"line_number":50,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":51,"context_line":"        \"\"\"Lists networks for the project and Show details for a network."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":54,"context_line":"deprecated.\"\"\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_2484205e","line":51,"range":{"start_line":51,"start_character":46,"end_line":51,"end_character":50},"in_reply_to":"df140735_ea73a54c","updated":"2017-05-30 05:06:36.000000000","message":"i think Show should be ok for case matching.","commit_id":"4d40ef71dd25ea9514881c62bf294d3a89ac764e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a8ca925009db60dc5fe5c71395feb92a633d20e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    base.create_rule_default("},{"line_number":25,"context_line":"        BASE_POLICY_NAME,"},{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"Creates, Deletes a network and Adds, Disassociates a network from a project."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are only available with nova-network which is deprecated.\"\"\","},{"line_number":30,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0a9a4313","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":87},"updated":"2017-05-30 08:13:29.000000000","message":"Better, but I still think this needs a further change. How about?\n\n    Create and delete a network, and associate and disassociate a network from a project?\n\nI wouldn\u0027t bother capitalizing words like that - it\u0027s not necessary and looks...off","commit_id":"0cc1daabe4de46e5111f8080e377c4863351b1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"353ce499f8a9f329077b28da01695c54d8746301","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    base.create_rule_default("},{"line_number":25,"context_line":"        BASE_POLICY_NAME,"},{"line_number":26,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":27,"context_line":"        \"\"\"Creates, Deletes a network and Adds, Disassociates a network from a project."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"These APIs are only available with nova-network which is deprecated.\"\"\","},{"line_number":30,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8a0ad323","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":87},"in_reply_to":"df140735_0a9a4313","updated":"2017-05-30 08:21:25.000000000","message":"ok, associate can be confusing with associate to host API.","commit_id":"0cc1daabe4de46e5111f8080e377c4863351b1a4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a8ca925009db60dc5fe5c71395feb92a633d20e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    base.create_rule_default("},{"line_number":49,"context_line":"        POLICY_ROOT % \u0027view\u0027,"},{"line_number":50,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":51,"context_line":"        \"\"\"List networks for the project and Show details for a network."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"These APIs are proxy calls to the Network service. These are all"},{"line_number":54,"context_line":"deprecated.\"\"\","}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_6a4f7fbd","line":51,"range":{"start_line":51,"start_character":45,"end_line":51,"end_character":46},"updated":"2017-05-30 08:13:29.000000000","message":"s","commit_id":"0cc1daabe4de46e5111f8080e377c4863351b1a4"}]}