)]}'
{"nova/policies/server_groups.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bcf41cfc7529ad41dfba45ea28bc0a8b103290b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BASE_POLICY_NAME \u003d \u0027os_compute_api:os-server-groups\u0027"},{"line_number":20,"context_line":"POLICY_ROOT \u003d \u0027os_compute_api:os-server-groups:%s\u0027"},{"line_number":21,"context_line":"BASE_POLICY_RULE \u003d \u0027rule:%s\u0027 % BASE_POLICY_NAME"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"server_groups_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_f1f4a35d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":47},"updated":"2017-05-18 13:40:26.000000000","message":"This can go","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"89195e7c4ebd8a268de9d831b3864447670f00b3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BASE_POLICY_NAME \u003d \u0027os_compute_api:os-server-groups\u0027"},{"line_number":20,"context_line":"POLICY_ROOT \u003d \u0027os_compute_api:os-server-groups:%s\u0027"},{"line_number":21,"context_line":"BASE_POLICY_RULE \u003d \u0027rule:%s\u0027 % BASE_POLICY_NAME"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"server_groups_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_334bf5b0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":47},"in_reply_to":"ff0f0b1f_f1f4a35d","updated":"2017-05-22 05:55:56.000000000","message":"Done","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bcf41cfc7529ad41dfba45ea28bc0a8b103290b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"server_groups_policies \u003d ["},{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":28,"context_line":"        \"Create a new server group\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_51fd8f38","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":33},"updated":"2017-05-18 13:40:26.000000000","message":"I don\u0027t understand what\u0027s happening here. Could you explain?","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"33f80f729e23c398d8dda31d686167ecf56d77ff","unresolved":false,"context_lines":[{"line_number":24,"context_line":"server_groups_policies \u003d ["},{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":28,"context_line":"        \"Create a new server group\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_f0711ae0","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":33},"in_reply_to":"ff0f0b1f_317202e5","updated":"2017-05-19 12:34:10.000000000","message":"ok, if we think it\u0027s not good to remove it and I am fine to deprecate in this cycle and remove it in next cycle\nLooks it\u0027s safer, just need some suggestions, thanks","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9cbae8c1a4e768d1778fb1f27150a3f25ab347a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"server_groups_policies \u003d ["},{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":28,"context_line":"        \"Create a new server group\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_317202e5","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":33},"in_reply_to":"ff0f0b1f_51fd8f38","updated":"2017-05-19 05:47:11.000000000","message":"Actually all those rules were default to old rule which is being removed in this patch. That was done because of smooth upgrade to new rules.\n\nThis is not straight forward or unused rule from starting. it became unused in ocata when new rules for each APIs(create, show etc) were introduced. \nThis old rule was left for backward compatibility for people overridden that.\n\nIts been 1 cycle but m not 100% sure about removal of this ruler as  we did not say that this old rule is deprecated and will be removed in next release - https://docs.openstack.org/releasenotes/nova/ocata.html#new-features\n\nNeed John opinion on this.","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dfcb576ae61fb26c2793715a5495c784b15897cb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"server_groups_policies \u003d ["},{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":28,"context_line":"        \"Create a new server group\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_798df52f","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":33},"in_reply_to":"ff0f0b1f_f0711ae0","updated":"2017-05-19 14:02:23.000000000","message":"Yeah, need a deprecation cycle on that one, its kept here so its backwards compatible.","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"}],"releasenotes/notes/deprecate_unused_policy-d3bf8589aee63eb6.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65f1baa5e713d75657989f4b4d97ee869e478f4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |      "},{"line_number":4,"context_line":"    Some unused policies have been deprecated. These are:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``os_compute_api:os-server-groups``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff0f0b1f_38caac6c","line":3,"range":{"start_line":3,"start_character":5,"end_line":3,"end_character":11},"updated":"2017-05-22 10:34:36.000000000","message":"whitespace","commit_id":"4125195ae55a2d05f893904b1fd0edcecc840674"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"65f1baa5e713d75657989f4b4d97ee869e478f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff0f0b1f_b8ab5c87","line":8,"updated":"2017-05-22 10:34:36.000000000","message":"You should remove these from your policy file(s).","commit_id":"4125195ae55a2d05f893904b1fd0edcecc840674"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a6f3fc1568c46c10f7d9bcbab96e03bbc2ef90c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    * ``os_compute_api:os-server-groups``"},{"line_number":7,"context_line":"    * ``os_compute_api:flavors``"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Please note you should remove these from your policy file(s)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff0f0b1f_8f7fe2a9","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":64},"updated":"2017-05-24 07:14:14.000000000","message":"nit, we don\u0027t support multiple policy files?","commit_id":"a7022af2b5a3e67c46786ea0ffc74185f55dc566"}],"releasenotes/notes/remove_unused_policy-d3bf8589aee63eb6.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bcf41cfc7529ad41dfba45ea28bc0a8b103290b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  remove unused policy from policy doc as them are not used at all"},{"line_number":4,"context_line":"  os_compute_api:os-server-groups"},{"line_number":5,"context_line":"  os_compute_api:flavors"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff0f0b1f_31a8db1d","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":24},"updated":"2017-05-18 13:40:26.000000000","message":"This doesn\u0027t look right. I\u0027m thinking we should be using bullets here same as elsewhere. Also, these policies are removed overall - not just from the doc. Perhaps this would do?\n\n    - |\n      Some unused policies have been removed. These are:\n\n      - ``os_compute_api:os-server-groups``\n      - ``os_compute_api:flavors``","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8e8faeb2e7c804d135d5e0c9cd63a308f36cf238","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  remove unused policy from policy doc as them are not used at all"},{"line_number":4,"context_line":"  os_compute_api:os-server-groups"},{"line_number":5,"context_line":"  os_compute_api:flavors"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff0f0b1f_399c1d5c","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":24},"in_reply_to":"ff0f0b1f_31a8db1d","updated":"2017-05-19 14:02:44.000000000","message":"+1 that","commit_id":"a7cde3eaff6a68f4779b15a6961c1e7d7da0dcdc"}]}