)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"fcfcd10682a24c8d469a724685da9ea5ac4b6975","unresolved":false,"context_lines":[{"line_number":7029,"context_line":"                        process.start()"},{"line_number":7030,"context_line":"                        while process.is_alive():"},{"line_number":7031,"context_line":"                            greenthread.sleep(1)"},{"line_number":7032,"context_line":"                        dk_size \u003d int(os.path.getsize(path))"},{"line_number":7033,"context_line":"                    if dk_size is None:"},{"line_number":7034,"context_line":"                        os.kill(process.pid, signal.SIGKILL)"},{"line_number":7035,"context_line":"                        LOG.error(\"Timed out while getting the size of \u0027%s\u0027\" % path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_9aefe286","line":7032,"range":{"start_line":7032,"start_character":24,"end_line":7032,"end_character":60},"updated":"2017-05-17 16:06:08.000000000","message":"maybe we shall wrap os.path.getsize ?","commit_id":"2e4e9c9ed4714c32a6c7f4940e72e47ef669cf87"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"50e1a097a7126f27edd1955ce632850da1563541","unresolved":false,"context_lines":[{"line_number":7029,"context_line":"                        process.start()"},{"line_number":7030,"context_line":"                        while process.is_alive():"},{"line_number":7031,"context_line":"                            greenthread.sleep(1)"},{"line_number":7032,"context_line":"                        dk_size \u003d int(os.path.getsize(path))"},{"line_number":7033,"context_line":"                    if dk_size is None:"},{"line_number":7034,"context_line":"                        os.kill(process.pid, signal.SIGKILL)"},{"line_number":7035,"context_line":"                        LOG.error(\"Timed out while getting the size of \u0027%s\u0027\" % path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_9cc58991","line":7032,"range":{"start_line":7032,"start_character":24,"end_line":7032,"end_character":60},"in_reply_to":"ff0f0b1f_9aefe286","updated":"2017-05-18 08:01:42.000000000","message":"I don\u0027t think that it is necessary to wrap os.path.getsize.\nWe have wrapped os.path.exists and we wait for it to finish before calling os.path.getsize.\nBecause of this os.path.getsize will only be called when there are no problems accessing the path.","commit_id":"2e4e9c9ed4714c32a6c7f4940e72e47ef669cf87"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"dc83dbb540de56765ccdcc849a7f2a81a410ad81","unresolved":false,"context_lines":[{"line_number":7029,"context_line":"                        process.start()"},{"line_number":7030,"context_line":"                        while process.is_alive():"},{"line_number":7031,"context_line":"                            greenthread.sleep(1)"},{"line_number":7032,"context_line":"                        dk_size \u003d int(os.path.getsize(path))"},{"line_number":7033,"context_line":"                    if dk_size is None:"},{"line_number":7034,"context_line":"                        os.kill(process.pid, signal.SIGKILL)"},{"line_number":7035,"context_line":"                        LOG.error(\"Timed out while getting the size of \u0027%s\u0027\" % path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_fff4775d","line":7032,"range":{"start_line":7032,"start_character":24,"end_line":7032,"end_character":60},"in_reply_to":"ff0f0b1f_9cc58991","updated":"2017-05-18 08:54:42.000000000","message":"Yes, that is the problem, because the filesystem might become unaccessible between checking if the file exists and actually performing some operation on it.","commit_id":"2e4e9c9ed4714c32a6c7f4940e72e47ef669cf87"}]}