)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"20184fdc6a07b7f6d209db117f443d9db3246e30","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            # host."},{"line_number":152,"context_line":"            host_list \u003d [chosen_host]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"            # Now find other hosts in the weighed_hosts that are in the same"},{"line_number":155,"context_line":"            # cell as the chosen host, and append them until we have the number"},{"line_number":156,"context_line":"            # specified in return_count, or we run out of weighed_hosts."},{"line_number":157,"context_line":"            cell_uuid \u003d chosen_host.obj.cell_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3950cfd4","line":154,"updated":"2017-05-26 12:36:10.000000000","message":"I could be reading the surrounding code incorrectly and maybe you are already doing this, but don\u0027t we need to get (and allocate) the \"top level\" host for the entirety of num_instances before we start adding alternate hosts?\n\nOtherwise we can run out of hosts to pull from the filtered and weighed set before we run out of num instances.\n\nThen, if we do that, we need to add the alternate hosts breadth first, not depth first, for the same reason.","commit_id":"355afb531a0e21555fb8a84f25f723c8450a7e3f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"70743c0b6b70986f295c6863ae9baa019acc19c7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            # host."},{"line_number":152,"context_line":"            host_list \u003d [chosen_host]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"            # Now find other hosts in the weighed_hosts that are in the same"},{"line_number":155,"context_line":"            # cell as the chosen host, and append them until we have the number"},{"line_number":156,"context_line":"            # specified in return_count, or we run out of weighed_hosts."},{"line_number":157,"context_line":"            cell_uuid \u003d chosen_host.obj.cell_uuid"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_73d9bbf2","line":154,"in_reply_to":"ff0f0b1f_3950cfd4","updated":"2017-05-26 17:46:51.000000000","message":"Yes, good point on adding the \"top level\" hosts first. I\u0027m not too concerned about the alternates, since they should rarely be used. It will also be more complex logic because we have to take into account the same-cellness of the hosts.","commit_id":"355afb531a0e21555fb8a84f25f723c8450a7e3f"}]}