)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"834dffc32606fc204107ac4f575bd27ba48c11c2","unresolved":false,"context_lines":[{"line_number":2087,"context_line":"        raise NotImplementedError()"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"    def _nw_info_get_ips(self, client, port):"},{"line_number":2090,"context_line":"        # First, do a bulk query for all floating IPs associated with the"},{"line_number":2091,"context_line":"        # given port and it\u0027s fixed IPs. Neutron will convert a filter value"},{"line_number":2092,"context_line":"        # that is a list and OR those together and then AND the port_id."},{"line_number":2093,"context_line":"        fixed_ips \u003d [fixed_ip[\u0027ip_address\u0027] for fixed_ip in port[\u0027fixed_ips\u0027]]"},{"line_number":2094,"context_line":"        floats \u003d self._safe_get_floating_ips("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_a3b70f87","line":2091,"range":{"start_line":2090,"start_character":10,"end_line":2091,"end_character":40},"updated":"2017-05-18 04:10:29.000000000","message":"It would be a bigger win if we could do a bulk query for info about all the *ports* at once.  If possible, it would mean hoisting the bulk query out of this routine and doing it in _build_network_info_model().","commit_id":"12a1191c3012ede9be7a6da778c9086e9ee93bdb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"54f7abf9cadcb24a70fe3057608b3f92ece2b724","unresolved":false,"context_lines":[{"line_number":2087,"context_line":"        raise NotImplementedError()"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"    def _nw_info_get_ips(self, client, port):"},{"line_number":2090,"context_line":"        # First, do a bulk query for all floating IPs associated with the"},{"line_number":2091,"context_line":"        # given port and it\u0027s fixed IPs. Neutron will convert a filter value"},{"line_number":2092,"context_line":"        # that is a list and OR those together and then AND the port_id."},{"line_number":2093,"context_line":"        fixed_ips \u003d [fixed_ip[\u0027ip_address\u0027] for fixed_ip in port[\u0027fixed_ips\u0027]]"},{"line_number":2094,"context_line":"        floats \u003d self._safe_get_floating_ips("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_51022fb6","line":2091,"range":{"start_line":2090,"start_character":10,"end_line":2091,"end_character":40},"in_reply_to":"ff0f0b1f_a3b70f87","updated":"2017-05-18 13:27:26.000000000","message":"Yeah, I\u0027m not sure how many fixed IPs we have on a single port anyway, plus this appears to not be working since there is a tempest test failing on this change. I\u0027ll probably push a change to do it this way and the old way and compare results, and log an error if they are different, meaning this bulk query doesn\u0027t work.","commit_id":"12a1191c3012ede9be7a6da778c9086e9ee93bdb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0dedcf14e2dbda8687d3190bb50529e109253d65","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"        # that is a list and OR those together and then AND the port_id."},{"line_number":2093,"context_line":"        fixed_ips \u003d [fixed_ip[\u0027ip_address\u0027] for fixed_ip in port[\u0027fixed_ips\u0027]]"},{"line_number":2094,"context_line":"        floats \u003d self._safe_get_floating_ips("},{"line_number":2095,"context_line":"            client, fixed_ip_address\u003dfixed_ips, port_id\u003dport,"},{"line_number":2096,"context_line":"            fields\u003d[\u0027fixed_ip_address\u0027, \u0027floating_ip_address\u0027])"},{"line_number":2097,"context_line":""},{"line_number":2098,"context_line":"        # Now map each fixed IP to it\u0027s floating IP(s) (yes you can apparently"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6eb91b77","line":2095,"updated":"2017-05-24 19:20:53.000000000","message":"port_id\u003dport[\u0027id\u0027]","commit_id":"12a1191c3012ede9be7a6da778c9086e9ee93bdb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"209c5711a1cdddce8d92da2d1475cbcff2b617db","unresolved":false,"context_lines":[{"line_number":2091,"context_line":"        # given port and it\u0027s fixed IPs. Neutron will convert a filter value"},{"line_number":2092,"context_line":"        # that is a list and OR those together and then AND the port_id."},{"line_number":2093,"context_line":"        fixed_ips \u003d [fixed_ip[\u0027ip_address\u0027] for fixed_ip in port[\u0027fixed_ips\u0027]]"},{"line_number":2094,"context_line":"        floats \u003d self._safe_get_floating_ips("},{"line_number":2095,"context_line":"            client, fixed_ip_address\u003dfixed_ips, port_id\u003dport[\u0027id\u0027],"},{"line_number":2096,"context_line":"            fields\u003d[\u0027fixed_ip_address\u0027, \u0027floating_ip_address\u0027])"},{"line_number":2097,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_35100b57","line":2094,"updated":"2017-05-25 00:08:23.000000000","message":"This is working now:\n\nhttp://logs.openstack.org/92/465792/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fd0e93f/logs/screen-q-svc.txt.gz#_May_24_20_54_02_457529","commit_id":"a196bdeb73f1e54e8be39a132e20f794b373ba0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d54a5db90f6d40221ec6c921ad8fc406c666f696","unresolved":false,"context_lines":[{"line_number":2830,"context_line":"        \"\"\"Force add a network to the project.\"\"\""},{"line_number":2831,"context_line":"        raise NotImplementedError()"},{"line_number":2832,"context_line":""},{"line_number":2833,"context_line":"    @timeutils.time_it(LOG, enabled\u003dLOG.isEnabledFor(logging.DEBUG))"},{"line_number":2834,"context_line":"    def _nw_info_get_ips(self, client, port):"},{"line_number":2835,"context_line":"        # First, do a bulk query for all floating IPs associated with the"},{"line_number":2836,"context_line":"        # given port and it\u0027s fixed IPs. Neutron will convert a filter value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6e04034b","line":2833,"updated":"2019-10-09 16:14:31.000000000","message":"Some hits for this in n-cpu https://zuul.opendev.org/t/openstack/build/d761059ef74a4b75a07d33b6d5850254/log/controller/logs/screen-n-cpu.txt.gz:\n\nIt took 0.11 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.15 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.12 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.10 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.16 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.19 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.22 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nAnd the API:\n\nIt took 0.14 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.45 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.22 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.10 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.18 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips\n\nIt took 0.10 seconds to run function \u0027nova.network.neutronv2.api.API._nw_info_get_ips","commit_id":"e815e12aa5c44530274c7601c43885bfac9dba4e"}]}
