)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e38323e3707701eedddacd4ef9bcbc54b47949e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45af5f1f_366f9572","updated":"2022-07-18 01:14:06.000000000","message":"recheck","commit_id":"8107e5ced8f3e644e49a2fd1eff51916258c40e7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ad1ac3c4aa897ad78e55a63301545b7eaae26aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"051eb0bf_d23b54b1","updated":"2022-07-12 13:24:59.000000000","message":"recheck unrelated ovh log failure","commit_id":"8107e5ced8f3e644e49a2fd1eff51916258c40e7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b93518552a10d04b39873e1f28aaa65f35e150d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"391e3187_9e96432e","updated":"2022-07-12 09:36:57.000000000","message":"this has been sitting for a long time so I doubt the author will update this so let just proceed with it.\n\nthe ci might reject this based on its age if there have been merge conficlit or other issue since it was written but if that is the case the ci will -1 so I don\u0027t see a need to rebase or recheck this first.\n\nif it can\u0027t apply then a rebase might be need","commit_id":"8107e5ced8f3e644e49a2fd1eff51916258c40e7"}],"nova/virt/interfaces.template":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ea3d8b4c31ac77e1d9893134328a243fb8957645","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    gateway {{ ifc.gateway_v6 }}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if ifc.dns_v6 %}"},{"line_number":40,"context_line":"    dns-nameservers {{ ifc.dns_v6 }}"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_c5b680da","side":"PARENT","line":40,"updated":"2017-05-18 09:38:12.000000000","message":"Not directly related, but why aren\u0027t v6 DNS servers set for lxc?","commit_id":"7280f4fc4c5a2203ac2f59a9df0525488ac2c1ff"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"60a76ca1c3cd8494ce766bce7d33cb391214472e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    gateway {{ ifc.gateway_v6 }}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if ifc.dns_v6 %}"},{"line_number":40,"context_line":"    dns-nameservers {{ ifc.dns_v6 }}"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_62ed4e8a","side":"PARENT","line":40,"in_reply_to":"ff0f0b1f_c5b680da","updated":"2017-05-19 01:42:33.000000000","message":"DNS server makes sense for LXC, I guess we\u0027re not setting this because IP command does not support dns-server set?","commit_id":"7280f4fc4c5a2203ac2f59a9df0525488ac2c1ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ea3d8b4c31ac77e1d9893134328a243fb8957645","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% if use_ipv6 %}"},{"line_number":26,"context_line":"{% if ifc.address_v6 %}"},{"line_number":27,"context_line":"{% if libvirt_virt_type \u003d\u003d \u0027lxc\u0027 %}"},{"line_number":28,"context_line":"iface {{ ifc.name }} inet6 manual"},{"line_number":29,"context_line":"    post-up ip -6 addr add {{ ifc.address_v6 }}/{{ifc.netmask_v6 }} dev ${IFACE}"},{"line_number":30,"context_line":"{% if ifc.gateway_v6 %}"},{"line_number":31,"context_line":"    post-up ip -6 route add default via {{ ifc.gateway_v6 }} dev ${IFACE}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_058fd82a","line":28,"updated":"2017-05-18 09:38:12.000000000","message":"Not sure if this is really needed for lxc, but wouldn\u0027t you also need to set the hwaddr in the v6-only case?","commit_id":"e1770a67ade712bda353bea7f8d32e41ba077249"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"60a76ca1c3cd8494ce766bce7d33cb391214472e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% if use_ipv6 %}"},{"line_number":26,"context_line":"{% if ifc.address_v6 %}"},{"line_number":27,"context_line":"{% if libvirt_virt_type \u003d\u003d \u0027lxc\u0027 %}"},{"line_number":28,"context_line":"iface {{ ifc.name }} inet6 manual"},{"line_number":29,"context_line":"    post-up ip -6 addr add {{ ifc.address_v6 }}/{{ifc.netmask_v6 }} dev ${IFACE}"},{"line_number":30,"context_line":"{% if ifc.gateway_v6 %}"},{"line_number":31,"context_line":"    post-up ip -6 route add default via {{ ifc.gateway_v6 }} dev ${IFACE}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_0277b204","line":28,"in_reply_to":"ff0f0b1f_058fd82a","updated":"2017-05-19 01:42:33.000000000","message":"The original lxc support doesn\u0027t have this line, so I will remove this and keep not changed settings for lxc","commit_id":"e1770a67ade712bda353bea7f8d32e41ba077249"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ea3d8b4c31ac77e1d9893134328a243fb8957645","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{% if ifc.address_v6 %}"},{"line_number":27,"context_line":"{% if libvirt_virt_type \u003d\u003d \u0027lxc\u0027 %}"},{"line_number":28,"context_line":"iface {{ ifc.name }} inet6 manual"},{"line_number":29,"context_line":"    post-up ip -6 addr add {{ ifc.address_v6 }}/{{ifc.netmask_v6 }} dev ${IFACE}"},{"line_number":30,"context_line":"{% if ifc.gateway_v6 %}"},{"line_number":31,"context_line":"    post-up ip -6 route add default via {{ ifc.gateway_v6 }} dev ${IFACE}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_05947836","line":29,"updated":"2017-05-18 09:38:12.000000000","message":"When you have this dedicated iface stanza, why do you still need to set this via a post-up, instead of using the usual \"address\" and \"netmask\" tags?","commit_id":"e1770a67ade712bda353bea7f8d32e41ba077249"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"60a76ca1c3cd8494ce766bce7d33cb391214472e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{% if ifc.address_v6 %}"},{"line_number":27,"context_line":"{% if libvirt_virt_type \u003d\u003d \u0027lxc\u0027 %}"},{"line_number":28,"context_line":"iface {{ ifc.name }} inet6 manual"},{"line_number":29,"context_line":"    post-up ip -6 addr add {{ ifc.address_v6 }}/{{ifc.netmask_v6 }} dev ${IFACE}"},{"line_number":30,"context_line":"{% if ifc.gateway_v6 %}"},{"line_number":31,"context_line":"    post-up ip -6 route add default via {{ ifc.gateway_v6 }} dev ${IFACE}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff0f0b1f_c2f09a6a","line":29,"in_reply_to":"ff0f0b1f_05947836","updated":"2017-05-19 01:42:33.000000000","message":"see https://review.openstack.org/#/c/106171/, which is a workaround for lxc env, so I\u0027ll keep this line and remove the above one.","commit_id":"e1770a67ade712bda353bea7f8d32e41ba077249"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bee5d8a9a01f002ac1697c6ca66d77dbc28fc5cb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% for ifc in interfaces %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"auto {{ ifc.name }}"},{"line_number":12,"context_line":"{% if ifc.address %}"},{"line_number":13,"context_line":"iface {{ ifc.name }} inet static"},{"line_number":14,"context_line":"    hwaddress ether {{ ifc.hwaddress }}"},{"line_number":15,"context_line":"    address {{ ifc.address }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ff82abbf_90d199d0","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":17},"updated":"2017-11-22 11:18:40.000000000","message":"I wish this was called address_v4","commit_id":"4e7ed82034cbf14c63b62818866c1d2321ef8011"}]}