)]}'
{"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"629915e59fb8129cdea8f6cb90a4d6b8c175ab78","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                expected_notifications.append("},{"line_number":169,"context_line":"                    {"},{"line_number":170,"context_line":"                        \u0027event_type\u0027: \u0027instance-update\u0027,"},{"line_number":171,"context_line":"                        \u0027replacements\u0027: copy.deepcopy(replacements)"},{"line_number":172,"context_line":"                    }"},{"line_number":173,"context_line":"                )"},{"line_number":174,"context_line":"            self._verify_notifications(expected_notifications,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_afce527f","line":171,"range":{"start_line":171,"start_character":40,"end_line":171,"end_character":67},"updated":"2017-06-02 12:15:44.000000000","message":"why it is needed?","commit_id":"8d196e997fd803271b30cc3ea1f8264c781f9766"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"b6ef722ff8ee59ad4466f1152dc385897fde6542","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                expected_notifications.append("},{"line_number":169,"context_line":"                    {"},{"line_number":170,"context_line":"                        \u0027event_type\u0027: \u0027instance-update\u0027,"},{"line_number":171,"context_line":"                        \u0027replacements\u0027: copy.deepcopy(replacements)"},{"line_number":172,"context_line":"                    }"},{"line_number":173,"context_line":"                )"},{"line_number":174,"context_line":"            self._verify_notifications(expected_notifications,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_e419ba21","line":171,"range":{"start_line":171,"start_character":40,"end_line":171,"end_character":67},"in_reply_to":"df140735_afce527f","updated":"2017-06-06 11:21:19.000000000","message":"I didn\u0027t found other solution for copy value to parameter. If i just use\n    \u0027replacements\u0027: replacements\n,then pass the reference, which at end of for cycle will be the all replacements, the last replacements state.","commit_id":"8d196e997fd803271b30cc3ea1f8264c781f9766"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b50efd35c1b0c5eb78527a0b52d50bf3659dba67","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        replacements \u003d {}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        def verify_instance_with_steps(self, notifications, steps):"},{"line_number":162,"context_line":"            \"\"\"This inherited function helps the verification of"},{"line_number":163,"context_line":"            multiple notifications. Create a list of expected"},{"line_number":164,"context_line":"            notifications from steps and verify the notifications."},{"line_number":165,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_63b7e1f6","line":162,"range":{"start_line":162,"start_character":15,"end_line":162,"end_character":38},"updated":"2017-06-19 09:18:59.000000000","message":"verify_instance_with_steps is not an inherited function. Do you try to refer to _verify_notifications() here?","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"de81cc6c318de8dddaba2a6d0c32cb46af63a445","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        replacements \u003d {}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        def verify_instance_with_steps(self, notifications, steps):"},{"line_number":162,"context_line":"            \"\"\"This inherited function helps the verification of"},{"line_number":163,"context_line":"            multiple notifications. Create a list of expected"},{"line_number":164,"context_line":"            notifications from steps and verify the notifications."},{"line_number":165,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_5e36fe52","line":162,"range":{"start_line":162,"start_character":15,"end_line":162,"end_character":38},"in_reply_to":"7f231b9d_63b7e1f6","updated":"2017-06-19 10:03:38.000000000","message":"Rightful, this a simple nested method. Fixed.","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b50efd35c1b0c5eb78527a0b52d50bf3659dba67","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            # scheduling -\u003e building"},{"line_number":200,"context_line":"            {"},{"line_number":201,"context_line":"                \u0027state_update.new_task_state\u0027: None,"},{"line_number":202,"context_line":"                \u0027state_update.old_task_state\u0027: \u0027scheduling\u0027,"},{"line_number":203,"context_line":"                \u0027task_state\u0027: None},"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # scheduled"},{"line_number":206,"context_line":"            {\u0027host\u0027: \u0027compute\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_e3c2d152","line":203,"range":{"start_line":201,"start_character":0,"end_line":203,"end_character":36},"updated":"2017-06-19 09:18:59.000000000","message":"There is some indentation change here that might be unnecessary","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"de81cc6c318de8dddaba2a6d0c32cb46af63a445","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            # scheduling -\u003e building"},{"line_number":200,"context_line":"            {"},{"line_number":201,"context_line":"                \u0027state_update.new_task_state\u0027: None,"},{"line_number":202,"context_line":"                \u0027state_update.old_task_state\u0027: \u0027scheduling\u0027,"},{"line_number":203,"context_line":"                \u0027task_state\u0027: None},"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # scheduled"},{"line_number":206,"context_line":"            {\u0027host\u0027: \u0027compute\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_3e6fc22b","line":203,"range":{"start_line":201,"start_character":0,"end_line":203,"end_character":36},"in_reply_to":"7f231b9d_e3c2d152","updated":"2017-06-19 10:03:38.000000000","message":"Right, done","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b50efd35c1b0c5eb78527a0b52d50bf3659dba67","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                     \"label\": \"private-network\","},{"line_number":230,"context_line":"                     \"device_name\": \"tapce531f90-19\""},{"line_number":231,"context_line":"                 }}]"},{"line_number":232,"context_line":"             },"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"            # block_device_mapping -\u003e spawning"},{"line_number":235,"context_line":"            {\u0027state_update.new_task_state\u0027: \u0027spawning\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_83a9dd90","line":232,"updated":"2017-06-19 09:18:59.000000000","message":"Is this indentation change needed?","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"de81cc6c318de8dddaba2a6d0c32cb46af63a445","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                     \"label\": \"private-network\","},{"line_number":230,"context_line":"                     \"device_name\": \"tapce531f90-19\""},{"line_number":231,"context_line":"                 }}]"},{"line_number":232,"context_line":"             },"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"            # block_device_mapping -\u003e spawning"},{"line_number":235,"context_line":"            {\u0027state_update.new_task_state\u0027: \u0027spawning\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_dedd6edd","line":232,"in_reply_to":"7f231b9d_83a9dd90","updated":"2017-06-19 10:03:38.000000000","message":"In the next block have similar solution. I think so more beautiful and more consistent.","commit_id":"09ed436d63aa6f68fbf76c52496a05bc7abf9d1b"}]}