)]}'
{"nova/api/compute_req_id.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"136e88dbd7a5ff23ae9e0471a22126d6d9d97b5c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_middleware import request_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"HTTP_RESP_HEADER_REQUEST_ID \u003d \u0027x-compute-request-id\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_a8570a26","line":29,"updated":"2017-05-25 14:55:07.000000000","message":"I assume you want this change:\n\nI5c5268e8680392395fbe04efe0124575ad8db468\n\nSo shouldn\u0027t we require oslo.middleware\u003e\u003d3.27.0? We currently require oslo.middleware\u003e\u003d3.10.0.","commit_id":"ef5f572e1f9ac7749c4e474001536cb0b499f9b6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03dcb82b335c605458b19358d1322bd72992c831","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class ComputeReqIdMiddleware(request_id.RequestId):"},{"line_number":36,"context_line":"    compat_headers \u003d [HTTP_RESP_HEADER_REQUEST_ID]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_9638bd3d","line":36,"updated":"2017-05-26 18:24:27.000000000","message":"Yup: https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py#L42","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03dcb82b335c605458b19358d1322bd72992c831","unresolved":false,"context_lines":[{"line_number":109,"context_line":"             header in the response for the snapshot image, they now return a"},{"line_number":110,"context_line":"             json dict in the response body with an image_id key and uuid"},{"line_number":111,"context_line":"             value."},{"line_number":112,"context_line":"    * 2.46 - Return ``X-OpenStack-Request-ID`` header on requests."},{"line_number":113,"context_line":"\"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_d61755a3","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":66},"updated":"2017-05-26 18:24:27.000000000","message":"nit: a tad bit confusing, return on requests, was thinking more like handle in requests, return in responses. But I\u0027m splitting hairs.","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e17330bf6265b388a91df0d2fa2376f25fb35f70","unresolved":false,"context_lines":[{"line_number":537,"context_line":"  a ``Location`` header in the response for the snapshot image, they now return"},{"line_number":538,"context_line":"  a json dict in the response body with an ``image_id`` key and uuid value."},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"2.46"},{"line_number":541,"context_line":"----"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"  The request_id created for every inbound request is now returned in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_1ae07dfa","line":540,"updated":"2017-05-25 15:06:28.000000000","message":"We\u0027re going to want a simple spec for this - all microversions are by policy supposed to have a spec.","commit_id":"b2c572fbbef0f06098b62f8968d573374ff3cc5a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4f77af01a26b1d852e96911948c5736313c2b242","unresolved":false,"context_lines":[{"line_number":538,"context_line":"  a json dict in the response body with an ``image_id`` key and uuid value."},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"2.46"},{"line_number":541,"context_line":"----"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"  The request_id created for every inbound request is now returned in"},{"line_number":544,"context_line":"  ``X-OpenStack-Request-ID`` in addition to ``X-Compute-Request-ID``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_4884d2b1","line":541,"updated":"2017-05-26 09:22:01.000000000","message":"we should bump the max version https://github.com/openstack/nova/blob/master/nova/api/openstack/api_version_request.py#L120 ?","commit_id":"a6b2773ef1992b254b75d69ced790c67c81e74e1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f9afa315a95ab786f9424e5d18d01ffdf6723460","unresolved":false,"context_lines":[{"line_number":538,"context_line":"  a json dict in the response body with an ``image_id`` key and uuid value."},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"2.46"},{"line_number":541,"context_line":"----"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"  The request_id created for every inbound request is now returned in"},{"line_number":544,"context_line":"  ``X-OpenStack-Request-ID`` in addition to ``X-Compute-Request-ID``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_de4adc81","line":541,"in_reply_to":"ff0f0b1f_4884d2b1","updated":"2017-05-26 10:36:37.000000000","message":"good catch, thank you","commit_id":"a6b2773ef1992b254b75d69ced790c67c81e74e1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03dcb82b335c605458b19358d1322bd72992c831","unresolved":false,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"  The request_id created for every inbound request is now returned in"},{"line_number":544,"context_line":"  ``X-OpenStack-Request-ID`` in addition to ``X-Compute-Request-ID``"},{"line_number":545,"context_line":"  to be consistent with the rest of OpenStack. This is a signaling"},{"line_number":546,"context_line":"  only microversion, as these header settings happen well before"},{"line_number":547,"context_line":"  microversion processing."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff0f0b1f_5668e51f","line":547,"range":{"start_line":545,"start_character":47,"end_line":547,"end_character":26},"updated":"2017-05-26 18:24:27.000000000","message":"nit: it might be worth expanding / clarifying this with something like, \"i.e. the X-OpenStack-Request-ID header will also come back in a v2.1 through v2.45 microversion also.\"","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"}],"releasenotes/notes/openstack-request-id-95f7bc7e960344a4.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"14752a48f038e6f641aeecb925dfb9a9258a7328","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova now uses oslo.middleware for request_id processing. This"},{"line_number":5,"context_line":"    means that there is now a new ``X-OpenStack-Request-ID`` header"},{"line_number":6,"context_line":"    returned on every request which mirrors the content of the"},{"line_number":7,"context_line":"    existing ``X-Compute-Request-ID``. The expected existance of this"},{"line_number":8,"context_line":"    header is singled by Microversion 2.46. If server version \u003e\u003d 2.46, you"},{"line_number":9,"context_line":"    can expect to see this header in your results (regardless of"},{"line_number":10,"context_line":"    microversion requested)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff0f0b1f_767529cc","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":61},"updated":"2017-05-26 18:30:35.000000000","message":"I think this is misspelled, should be \"existence\"","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03dcb82b335c605458b19358d1322bd72992c831","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    means that there is now a new ``X-OpenStack-Request-ID`` header"},{"line_number":6,"context_line":"    returned on every request which mirrors the content of the"},{"line_number":7,"context_line":"    existing ``X-Compute-Request-ID``. The expected existance of this"},{"line_number":8,"context_line":"    header is singled by Microversion 2.46. If server version \u003e\u003d 2.46, you"},{"line_number":9,"context_line":"    can expect to see this header in your results (regardless of"},{"line_number":10,"context_line":"    microversion requested)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff0f0b1f_96d43dbf","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":61},"updated":"2017-05-26 18:24:27.000000000","message":"I was going to say something about max version here, but the key for max version is literally \u0027version\u0027:\n\nhttps://developer.openstack.org/api-ref/compute/?expanded\u003dlist-all-major-versions-detail#list-all-major-versions\n\nSo this looks good to me.","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03dcb82b335c605458b19358d1322bd72992c831","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    means that there is now a new ``X-OpenStack-Request-ID`` header"},{"line_number":6,"context_line":"    returned on every request which mirrors the content of the"},{"line_number":7,"context_line":"    existing ``X-Compute-Request-ID``. The expected existance of this"},{"line_number":8,"context_line":"    header is singled by Microversion 2.46. If server version \u003e\u003d 2.46, you"},{"line_number":9,"context_line":"    can expect to see this header in your results (regardless of"},{"line_number":10,"context_line":"    microversion requested)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff0f0b1f_f6601938","line":8,"range":{"start_line":8,"start_character":14,"end_line":8,"end_character":21},"updated":"2017-05-26 18:24:27.000000000","message":"signaled","commit_id":"c7cc949ce8e42d6063c1e57bf2b9a9ff0575da72"}]}