)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4dfaceca75d8f38e7bdc98d1fda0994f9249871e","unresolved":false,"context_lines":[{"line_number":891,"context_line":"                try:"},{"line_number":892,"context_line":"                    inst_mapping \u003d \\"},{"line_number":893,"context_line":"                        objects.InstanceMapping.get_by_instance_uuid("},{"line_number":894,"context_line":"                            cctxt, instance.uuid)"},{"line_number":895,"context_line":"                    inst_mapping.cell_mapping \u003d cell0"},{"line_number":896,"context_line":"                    inst_mapping.save()"},{"line_number":897,"context_line":"                except exception.InstanceMappingNotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_d05d20ea","line":894,"range":{"start_line":894,"start_character":28,"end_line":894,"end_character":33},"updated":"2017-05-26 15:21:54.000000000","message":"Actually, this isn\u0027t quite right. InstanceMapping is in the api cell, so no need to use the targeted context. It\u0027s not wrong, but.. probably not what we want I think.","commit_id":"8d9861a4a4117a764a9fbd77e9e6c5dc57b4c5ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5babf9ff764fd23a0967ea5c730da60728695427","unresolved":false,"context_lines":[{"line_number":891,"context_line":"                try:"},{"line_number":892,"context_line":"                    inst_mapping \u003d \\"},{"line_number":893,"context_line":"                        objects.InstanceMapping.get_by_instance_uuid("},{"line_number":894,"context_line":"                            cctxt, instance.uuid)"},{"line_number":895,"context_line":"                    inst_mapping.cell_mapping \u003d cell0"},{"line_number":896,"context_line":"                    inst_mapping.save()"},{"line_number":897,"context_line":"                except exception.InstanceMappingNotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_f026e468","line":894,"range":{"start_line":894,"start_character":28,"end_line":894,"end_character":33},"in_reply_to":"ff0f0b1f_d05d20ea","updated":"2017-05-26 15:23:56.000000000","message":"I\u0027m pretty sure I asked about this very same type of thing in your same series and you did the same thing.\n\nHere:\n\nhttps://review.openstack.org/#/c/458634/13/nova/objects/host_mapping.py@227","commit_id":"8d9861a4a4117a764a9fbd77e9e6c5dc57b4c5ad"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"924b0f4a2597f715bfc54a2ca93782896a6e11c1","unresolved":false,"context_lines":[{"line_number":891,"context_line":"                try:"},{"line_number":892,"context_line":"                    inst_mapping \u003d \\"},{"line_number":893,"context_line":"                        objects.InstanceMapping.get_by_instance_uuid("},{"line_number":894,"context_line":"                            cctxt, instance.uuid)"},{"line_number":895,"context_line":"                    inst_mapping.cell_mapping \u003d cell0"},{"line_number":896,"context_line":"                    inst_mapping.save()"},{"line_number":897,"context_line":"                except exception.InstanceMappingNotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_9051e865","line":894,"range":{"start_line":894,"start_character":28,"end_line":894,"end_character":33},"in_reply_to":"ff0f0b1f_f026e468","updated":"2017-05-26 15:34:14.000000000","message":"it\u0027s different because that method talks to the cell db as well, and at the time of that patch, we were will switching the shared context.","commit_id":"8d9861a4a4117a764a9fbd77e9e6c5dc57b4c5ad"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5e39b2fbacd574d7a2164082e5a2868f36198be0","unresolved":false,"context_lines":[{"line_number":890,"context_line":"                self._set_vm_state_and_notify("},{"line_number":891,"context_line":"                    cctxt, instance.uuid, \u0027build_instances\u0027, updates,"},{"line_number":892,"context_line":"                    exc, legacy_spec)"},{"line_number":893,"context_line":"                try:"},{"line_number":894,"context_line":"                    # We don\u0027t need the cell0-targeted context here because the"},{"line_number":895,"context_line":"                    # instance mapping is in the API DB."},{"line_number":896,"context_line":"                    inst_mapping \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a0f6d7f8","line":893,"updated":"2017-05-26 17:04:23.000000000","message":"This try block could be outside the target_cell context manager too, which might make it even clearer that it\u0027s unrelated.","commit_id":"5fac17ae960d36eeb7a642725a37f82e8ca95ec1"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9359ef7b7c0c33c136f13499609b150acb0eeb0f","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"                                             \u0027limits\u0027: None}]"},{"line_number":1587,"context_line":"        targeted_context \u003d mock.MagicMock("},{"line_number":1588,"context_line":"            autospec\u003d\u0027nova.context.RequestContext\u0027)"},{"line_number":1589,"context_line":"        target_cell.return_value.__enter__.return_value \u003d targeted_context"},{"line_number":1590,"context_line":"        self.conductor.schedule_and_build_instances(**self.params)"},{"line_number":1591,"context_line":"        self.assertFalse(build_and_run.called)"},{"line_number":1592,"context_line":"        self.assertFalse(bury.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_d02520ad","line":1589,"updated":"2017-05-26 15:11:27.000000000","message":"We probably need to figure out a better pattern for this at some point.","commit_id":"8d9861a4a4117a764a9fbd77e9e6c5dc57b4c5ad"}]}