)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5e592b6ec28e801d83f05b2e6b9836e506c61833","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Because this changes the error message, but not the error response"},{"line_number":22,"context_line":"code, this does not violate the api interoperability guidelines[1],"},{"line_number":23,"context_line":"so I\u0027m willing to say this doesn\u0027t require a microversion, and thus"},{"line_number":24,"context_line":"does not require a spec."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] http://specs.openstack.org/openstack/api-wg/guidelines/api_interoperability.html"},{"line_number":27,"context_line":"If we do think this is a violation, then the guideline should be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_3a9fa251","line":24,"updated":"2017-05-29 17:45:37.000000000","message":"This is probably up for debate. If people want a microversion version and a spec, that\u0027s fine, let me know.","commit_id":"c564eb5e0ff1d47a230c90c9de19b891820893a8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"80870229d4b5bc7bbae1648636c5e5380fd166a4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Because this changes the error message, but not the error response"},{"line_number":22,"context_line":"code, this does not violate the api interoperability guidelines[1],"},{"line_number":23,"context_line":"so I\u0027m willing to say this doesn\u0027t require a microversion, and thus"},{"line_number":24,"context_line":"does not require a spec."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] http://specs.openstack.org/openstack/api-wg/guidelines/api_interoperability.html"},{"line_number":27,"context_line":"If we do think this is a violation, then the guideline should be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_f59cc76a","line":24,"updated":"2017-08-16 17:55:38.000000000","message":"yeah, I agree. It seems overkill to require microversion for this case.","commit_id":"863f0ce0b543631cf13b3d5d6491659931e2697e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b55bbadc270a4e91c4c4c13966fc050e909000a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Because this changes the error message, but not the error response"},{"line_number":22,"context_line":"code, this does not violate the api interoperability guidelines[1],"},{"line_number":23,"context_line":"so I\u0027m willing to say this doesn\u0027t require a microversion, and thus"},{"line_number":24,"context_line":"does not require a spec."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] http://specs.openstack.org/openstack/api-wg/guidelines/api_interoperability.html"},{"line_number":27,"context_line":"If we do think this is a violation, then the guideline should be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_6aad1087","line":24,"in_reply_to":"9f436f4f_f59cc76a","updated":"2017-08-25 09:54:10.000000000","message":"agreed.","commit_id":"863f0ce0b543631cf13b3d5d6491659931e2697e"}],"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"0cd36fbbbb083b876b0cd3ccbc76498068bdd88b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        # of both fields being duplicates) appears to be database"},{"line_number":189,"context_line":"        # dependent, so going with the complete solution here."},{"line_number":190,"context_line":"        duplicate \u003d \u0027, \u0027.join([\u0027%s: %s\u0027 % (column, data[column])"},{"line_number":191,"context_line":"                          for column in exc.columns])"},{"line_number":192,"context_line":"        raise webob.exc.HTTPConflict("},{"line_number":193,"context_line":"            _(\u0027Conflicting resource provider %(duplicate)s already exists.\u0027) %"},{"line_number":194,"context_line":"            {\u0027duplicate\u0027: duplicate})"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_6f3c08c8","line":191,"updated":"2017-05-31 11:21:45.000000000","message":"Good catch, probably I see it like a generalization for other DBDuplicateEntry exceptions.","commit_id":"c564eb5e0ff1d47a230c90c9de19b891820893a8"}]}