)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9869eba28fe5cc4248bab5bc222d93d71cfe2a44","unresolved":false,"context_lines":[{"line_number":14,"context_line":"The fix uses vmware.integration_bridge instead of flat_network_"},{"line_number":15,"context_line":"bridge for the network_name."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes: bug #1226425"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I54373e00440e36fce920a1a5f613ff571a63ff91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAS3%2F%2F10w%3D","line":17,"updated":"2013-09-18 12:26:09.000000000","message":"Please add a DocImpact as we need to document this.","commit_id":"cb75e7b3c08ca502e8a692bb1983e13796490774"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cb4ca6ff182a0d16f13b706fb0ed701e7877ee7","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def get_network_ref(session, cluster, vif, is_neutron):"},{"line_number":121,"context_line":"    if is_neutron:"},{"line_number":122,"context_line":"        network_ref \u003d get_neutron_network(session,"},{"line_number":123,"context_line":"                          CONF.vmware.integration_bridge, cluster, vif)"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        create_vlan \u003d vif[\u0027network\u0027].get_meta(\u0027should_create_vlan\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F6Dc%3D","line":122,"updated":"2013-09-17 11:31:46.000000000","message":"Can you please clarify why you changed this? This change will break the neutron functionality with the opaque networks. The vif[\u0027network\u0027][\u0027bridge\u0027] value needs to be checkd to see if it matches the opaque network. If it does not then we revert back to checking the configured value","commit_id":"023dbc221eeee59492c2d7fecc50a4ac77ccb73e"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"3977e37e82385900cc734cb1f14e98b68acf8459","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def get_network_ref(session, cluster, vif, is_neutron):"},{"line_number":121,"context_line":"    if is_neutron:"},{"line_number":122,"context_line":"        network_ref \u003d get_neutron_network(session,"},{"line_number":123,"context_line":"                          CONF.vmware.integration_bridge, cluster, vif)"},{"line_number":124,"context_line":"    else:"},{"line_number":125,"context_line":"        create_vlan \u003d vif[\u0027network\u0027].get_meta(\u0027should_create_vlan\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F4o0%3D","line":122,"in_reply_to":"AAAAS3%2F%2F6Dc%3D","updated":"2013-09-17 18:05:31.000000000","message":"Agreed. I","commit_id":"023dbc221eeee59492c2d7fecc50a4ac77ccb73e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9869eba28fe5cc4248bab5bc222d93d71cfe2a44","unresolved":false,"context_lines":[{"line_number":41,"context_line":"def ensure_vlan_bridge(session, vif, cluster\u003dNone, create_vlan\u003dTrue):"},{"line_number":42,"context_line":"    \"\"\"Create a vlan and bridge unless they already exist.\"\"\""},{"line_number":43,"context_line":"    vlan_num \u003d vif[\u0027network\u0027].get_meta(\u0027vlan\u0027)"},{"line_number":44,"context_line":"    bridge \u003d vif[\u0027network\u0027][\u0027bridge\u0027]"},{"line_number":45,"context_line":"    vlan_interface \u003d CONF.vmware.vlan_interface"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    network_ref \u003d network_util.get_network_with_the_name(session, bridge,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F10E%3D","side":"PARENT","line":44,"updated":"2013-09-18 12:26:09.000000000","message":"i think that we are breaking functionality when this is not flat networking. in the case that we have multiple networks this will not work.\nis there anyway to know what we have a flat network?","commit_id":"f11dc6b3bc315c11fb3a6055f7f53386c8eb888d"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"09aebe2b96b0a43cb021edd16e4f705a20bff924","unresolved":false,"context_lines":[{"line_number":41,"context_line":"def ensure_vlan_bridge(session, vif, cluster\u003dNone, create_vlan\u003dTrue):"},{"line_number":42,"context_line":"    \"\"\"Create a vlan and bridge unless they already exist.\"\"\""},{"line_number":43,"context_line":"    vlan_num \u003d vif[\u0027network\u0027].get_meta(\u0027vlan\u0027)"},{"line_number":44,"context_line":"    bridge \u003d vif[\u0027network\u0027][\u0027bridge\u0027]"},{"line_number":45,"context_line":"    vlan_interface \u003d CONF.vmware.vlan_interface"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    network_ref \u003d network_util.get_network_with_the_name(session, bridge,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F0Jc%3D","side":"PARENT","line":44,"in_reply_to":"AAAAS3%2F%2F10E%3D","updated":"2013-09-18 19:15:14.000000000","message":"Hmm, the issues are two-fold. \n\nWith VLAN Networking, the instance could be connected to different port groups (each with it;s VLAN ID) based on the bridge name. As in VLAN Manager each VLAN will have a separate bridge on the compute node. \n\nwith FLATDHCP Networking, this fix works because there will only be one bridge per compute node. But, I recently learnt about the multi-nic scenario, where the flatdhcp manager can create multiple bridges too. http://docs.openstack.org/developer/nova/devref/multinic.html\n\nLet me take a while and revisit on how not to affect these usecases.","commit_id":"f11dc6b3bc315c11fb3a6055f7f53386c8eb888d"}]}
