)]}'
{"nova/volume/cinder.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e1607cc12d69c4e262ae11ac1c27f4a17cf7a647","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            representing the updated volume attachment."},{"line_number":582,"context_line":"        \"\"\""},{"line_number":583,"context_line":"        try:"},{"line_number":584,"context_line":"            # TODO(mriedem): consider skipping the microversion discovery"},{"line_number":585,"context_line":"            return cinderclient(context, \u00273.27\u0027).attachments.update("},{"line_number":586,"context_line":"                attachment_id, connector)"},{"line_number":587,"context_line":"        except cinder_exception.ClientException as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_620f71e1","line":584,"range":{"start_line":584,"start_character":29,"end_line":584,"end_character":73},"updated":"2017-05-31 19:04:02.000000000","message":"I was thinking about whether there can be a case that we have a new style attachment and still not have the 3.27 or higher microversion available for some reason when we get to _update and _delete. Not sure at this point, but I agree it would make the flow easier if we could skip discovery with this call and the one below.","commit_id":"c2ff6513f9d70c26ebbe6900bf8b10cbfb32b7aa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbeddd1d50bf73e33fffccd67fa35bbb0f1d61ec","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            representing the updated volume attachment."},{"line_number":582,"context_line":"        \"\"\""},{"line_number":583,"context_line":"        try:"},{"line_number":584,"context_line":"            # TODO(mriedem): consider skipping the microversion discovery"},{"line_number":585,"context_line":"            return cinderclient(context, \u00273.27\u0027).attachments.update("},{"line_number":586,"context_line":"                attachment_id, connector)"},{"line_number":587,"context_line":"        except cinder_exception.ClientException as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_e313825b","line":584,"range":{"start_line":584,"start_character":29,"end_line":584,"end_character":73},"in_reply_to":"df140735_620f71e1","updated":"2017-05-31 21:15:35.000000000","message":"If we request update or delete with 3.27 and it\u0027s not available, cinder should fail with a 406 which is going to result in a fault on the nova side. I think it\u0027s something we shouldn\u0027t expect if we\u0027re making attachments with 3.27, i.e. we don\u0027t support someone rolling back their API.","commit_id":"c2ff6513f9d70c26ebbe6900bf8b10cbfb32b7aa"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"fc0399ad074cc244b955b0ff8de103026dafa4b1","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            representing the updated volume attachment."},{"line_number":582,"context_line":"        \"\"\""},{"line_number":583,"context_line":"        try:"},{"line_number":584,"context_line":"            # TODO(mriedem): consider skipping the microversion discovery"},{"line_number":585,"context_line":"            return cinderclient(context, \u00273.27\u0027).attachments.update("},{"line_number":586,"context_line":"                attachment_id, connector)"},{"line_number":587,"context_line":"        except cinder_exception.ClientException as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_0f9ff5b4","line":584,"range":{"start_line":584,"start_character":29,"end_line":584,"end_character":73},"in_reply_to":"df140735_e313825b","updated":"2017-06-07 14:33:34.000000000","message":"Fair enough, just wanted to be sure we\u0027re on the same page. Tnx!","commit_id":"c2ff6513f9d70c26ebbe6900bf8b10cbfb32b7aa"}]}