)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"da09dc60f4ae50d38c105a1744e261f97dc3be47","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete the instance files after revert a resize task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If instance use shared storage, revert a resize task need delete"},{"line_number":10,"context_line":"the instance dir and files on destination host to ensure a smooth"},{"line_number":11,"context_line":"live migration at next time."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_2a13e70f","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":57},"updated":"2017-06-09 18:17:48.000000000","message":"s/need/needs to/","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"da09dc60f4ae50d38c105a1744e261f97dc3be47","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete the instance files after revert a resize task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If instance use shared storage, revert a resize task need delete"},{"line_number":10,"context_line":"the instance dir and files on destination host to ensure a smooth"},{"line_number":11,"context_line":"live migration at next time."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_8a043bc8","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":15},"updated":"2017-06-09 18:17:48.000000000","message":"s/use/uses/","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"da09dc60f4ae50d38c105a1744e261f97dc3be47","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If instance use shared storage, revert a resize task need delete"},{"line_number":10,"context_line":"the instance dir and files on destination host to ensure a smooth"},{"line_number":11,"context_line":"live migration at next time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I868180fc4e87c4dafb1e54b7d31c8437f17e4122"},{"line_number":14,"context_line":"Closes-Bug: #1694913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_2a88871d","line":11,"updated":"2017-06-09 18:17:48.000000000","message":"As the bug report discussion, the root problem has been fixed since https://review.openstack.org/#/c/392643/\n\nTBH, I hesitate to remove these files from compute node because migration operations (including resize) can be failed and operators need to salvage instance info from such files sometimes.","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"},{"author":{"_account_id":24562,"name":"falseuser","email":"falseuser@outlook.com","username":"falseuser"},"change_message_id":"d8e759cc4c5f3d34e5cbd218c03e47dd27fc8bba","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If instance use shared storage, revert a resize task need delete"},{"line_number":10,"context_line":"the instance dir and files on destination host to ensure a smooth"},{"line_number":11,"context_line":"live migration at next time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I868180fc4e87c4dafb1e54b7d31c8437f17e4122"},{"line_number":14,"context_line":"Closes-Bug: #1694913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_3660ed32","line":11,"in_reply_to":"7f231b9d_2a88871d","updated":"2017-06-10 02:07:57.000000000","message":"Thanks for your advice, I saw the above that commit, but I later found that the impact of live migration is not the console.log, but the instance directory, this directory will be checked before live migration and then migration will fail, I updated at bug #1694913.\nIf keep the instance directory, after the instance is deleted, it will still exist because nova does not know the existence of this directory on other host.\nDo we need to keep these directories and files?","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"},{"author":{"_account_id":24562,"name":"falseuser","email":"falseuser@outlook.com","username":"falseuser"},"change_message_id":"2a20776811c005f2806c69ff79ed7eafb3b537e5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If instance use shared storage, revert a resize task need delete"},{"line_number":10,"context_line":"the instance dir and files on destination host to ensure a smooth"},{"line_number":11,"context_line":"live migration at next time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I868180fc4e87c4dafb1e54b7d31c8437f17e4122"},{"line_number":14,"context_line":"Closes-Bug: #1694913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_160df13d","line":11,"in_reply_to":"7f231b9d_3660ed32","updated":"2017-06-10 02:33:17.000000000","message":"When using non-shared storage, directories and files will be deleted after revert on destination host, but with shared storage, they will not be deleted.","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"}],"nova/compute/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"da09dc60f4ae50d38c105a1744e261f97dc3be47","unresolved":false,"context_lines":[{"line_number":3680,"context_line":""},{"line_number":3681,"context_line":"            self._terminate_volume_connections(context, instance, bdms)"},{"line_number":3682,"context_line":""},{"line_number":3683,"context_line":"            # If instance use shared storage, revert resize need delete the"},{"line_number":3684,"context_line":"            # instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_ca0113b2","line":3685,"range":{"start_line":3683,"start_character":12,"end_line":3685,"end_character":42},"updated":"2017-06-09 18:17:48.000000000","message":"the same comments as the commit message.","commit_id":"39317b75148651a6d9fd33be2a758d708d6ade2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a606236d5845798fe94370653367a38a391d412a","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_dc941347","line":3686,"range":{"start_line":3686,"start_character":12,"end_line":3686,"end_character":55},"updated":"2017-06-12 15:28:35.000000000","message":"You\u0027re going to test whether this is called, at a minimum","commit_id":"95f1e4320300d8a2b512c1f4c379b7c8c716edd6"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"ce8c43e787bd99c83c23f55d52906f1c4dd38b83","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_c389f426","line":3686,"updated":"2017-06-20 21:54:06.000000000","message":"How does this work with shared instance path?","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"},{"author":{"_account_id":24562,"name":"falseuser","email":"falseuser@outlook.com","username":"falseuser"},"change_message_id":"917de36390f4a0d1f61bc45ac7c54f203f4da294","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_830e2a8b","line":3686,"in_reply_to":"5f201791_3c56792b","updated":"2017-06-22 09:08:59.000000000","message":"Libvirt with flat/qcow2 backend uses shared network file storage, it is still considered non-shared storage in nova, that is determined by images_type.\nLook https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L360\n\nAnd if destroy_disks flag (L3676) is True, driver.destroy will delete instance files and instance disk, In shared storage like RBD, it should not delete instance disk，so here is just to delete the instance directory.\nLook https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1009","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"f58547750df0e8122842f672d5f85fbeabeb69f0","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_86ae3396","line":3686,"in_reply_to":"5f201791_830e2a8b","updated":"2017-06-22 12:33:05.000000000","message":"self._is_instance_storage_shared returns True in such case (it uses a special additional request to the source node, https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L673). Because that destroy_disks is False (sorry my mistake in the previous comment). As the result driver.destroy does not delete instance files - for shared network file storage.\n\nBut with your changes it does. Maybe it\u0027s right, but it should be proven.","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"359bb04aa9ce54845e066838c0c93766e9593a6e","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_8833c213","line":3686,"in_reply_to":"5f201791_86ae3396","updated":"2017-10-31 23:05:40.000000000","message":"This doesn\u0027t seem correct. As Feodor said, all of this logic is handled at the virt driver layers and for shared storage like rbd, we shouldn\u0027t be deleting the instance files when we move the instance around.","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"15d6bb128051c73e430ce007bf5b30bd01d7d72d","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_3c56792b","line":3686,"in_reply_to":"5f201791_98d6c34f","updated":"2017-06-21 11:32:40.000000000","message":"If libvirt with flat/qcow2 backend uses shared network file storage for instance files, then destroy_disks flag (L3676) is True, and therefore driver.destroy keeps instance files. But here you delete them. Is it correct? How does Nova handles revert_resize after that? And if all is correct, why would not just set destroy_disks flag to True?","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"},{"author":{"_account_id":24562,"name":"falseuser","email":"falseuser@outlook.com","username":"falseuser"},"change_message_id":"bd2717929f379635af59b1730f2c0161afc5b3d7","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"            # If instance uses shared storage, revert resize needs to delete"},{"line_number":3684,"context_line":"            # the instance dir and files on destination host, ensure a smooth"},{"line_number":3685,"context_line":"            # live migration at next time."},{"line_number":3686,"context_line":"            self.driver.delete_instance_files(instance)"},{"line_number":3687,"context_line":""},{"line_number":3688,"context_line":"            migration.status \u003d \u0027reverted\u0027"},{"line_number":3689,"context_line":"            with migration.obj_as_admin():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_98d6c34f","line":3686,"in_reply_to":"5f201791_c389f426","updated":"2017-06-21 04:12:59.000000000","message":"Only libvirt driver implements this function, in libvirt driver, only rbd image backend is shared block storage, but rbd will not have shared instance path, so here will work correctly","commit_id":"d9717f6c218481cb1b643597e97f8801a40e58b4"}]}