)]}'
{"placement-api-ref/source/allocations.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"640df2a375031891063477f443320e98395f1d6a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Response"},{"line_number":78,"context_line":"--------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"No body content is returned on a successful DELETE."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Delete allocations"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5f201791_e62fba85","line":80,"range":{"start_line":80,"start_character":44,"end_line":80,"end_character":50},"updated":"2017-06-27 06:17:27.000000000","message":"PUT","commit_id":"12c2227c6191f5d31952fd808a47118adafc33d9"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7542a54d674fc777f697acf48f935ee7b53245f8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Response"},{"line_number":78,"context_line":"--------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"No body content is returned on a successful DELETE."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Delete allocations"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5f201791_064284ab","line":80,"range":{"start_line":80,"start_character":44,"end_line":80,"end_character":50},"in_reply_to":"5f201791_e62fba85","updated":"2017-06-28 08:53:41.000000000","message":"Done","commit_id":"12c2227c6191f5d31952fd808a47118adafc33d9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a9289fd8027e73445988f4d12129572cdbb536d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Normal Response Codes: 200"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Error response codes: itemNotFound(404)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Request"},{"line_number":23,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_ec9d530a","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":39},"updated":"2017-07-06 02:32:07.000000000","message":"In what case is 404 error returned?\nIt seems that there is no case 404 error is returned.","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"d07cfd9037826cbe36193ee071d2f31a1b92b6b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Normal Response Codes: 200"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Error response codes: itemNotFound(404)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Request"},{"line_number":23,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_278239c9","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":39},"in_reply_to":"3f1d235d_ec9d530a","updated":"2017-07-06 08:58:56.000000000","message":"Yeah, automatically added it looking at consumer_uuid param.\nFixed.","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a9289fd8027e73445988f4d12129572cdbb536d7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - resource_provider: resource_provider_object"},{"line_number":69,"context_line":"  - uuid: resource_provider_uuid"},{"line_number":70,"context_line":"  - project_id: project_id_body"},{"line_number":71,"context_line":"  - user_id: user_id_body"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Request example"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_0672ad7b","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":25},"updated":"2017-07-06 02:32:07.000000000","message":"It is defined as \u0027optional\u0027 in this API reference.\nBut it is defined as \u0027required\u0027 in the schema in nova/api/openstack/placement/handlers/allocation.py.\n\nhttps://github.com/openstack/nova/blob/635e29433cdadd3d1b664ea2354f049125c393fe/nova/api/openstack/placement/handlers/allocation.py#L81","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"d07cfd9037826cbe36193ee071d2f31a1b92b6b1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - resource_provider: resource_provider_object"},{"line_number":69,"context_line":"  - uuid: resource_provider_uuid"},{"line_number":70,"context_line":"  - project_id: project_id_body"},{"line_number":71,"context_line":"  - user_id: user_id_body"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Request example"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_8770ed09","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":25},"in_reply_to":"3f1d235d_0672ad7b","updated":"2017-07-06 08:58:56.000000000","message":"Done","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a9289fd8027e73445988f4d12129572cdbb536d7","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Normal Response Codes: 204"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Error response codes: itemNotFound(404), conflict(409)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request"},{"line_number":97,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_6c7f03ab","line":94,"range":{"start_line":94,"start_character":41,"end_line":94,"end_character":54},"updated":"2017-07-06 02:32:07.000000000","message":"Can it be returned?","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"d07cfd9037826cbe36193ee071d2f31a1b92b6b1","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Normal Response Codes: 204"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Error response codes: itemNotFound(404), conflict(409)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request"},{"line_number":97,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f1d235d_4768951b","line":94,"range":{"start_line":94,"start_character":41,"end_line":94,"end_character":54},"in_reply_to":"3f1d235d_6c7f03ab","updated":"2017-07-06 08:58:56.000000000","message":"Done","commit_id":"6a8f7792e2bcd5e8a0c2328f044fcfe39bfcf780"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bf38bef2f65a760debc3baa79606445691ef22c2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"of a particular resource that has been allocated to a given consumer"},{"line_number":8,"context_line":"of that resource from a particular resource provider."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Show allocations"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"List all allocation records for the consumer identified by"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"3f1d235d_85bd62b8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2017-07-07 03:02:25.000000000","message":"It should be \u0027List\u0027.","commit_id":"9d4d017e74b5ae84c450e153f721d7b7c50ab0e3"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"dbb418f92836331d103e7be6c4cb0f7838548d96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"of a particular resource that has been allocated to a given consumer"},{"line_number":8,"context_line":"of that resource from a particular resource provider."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Show allocations"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"List all allocation records for the consumer identified by"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"3f1d235d_6eba1ac1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"3f1d235d_85bd62b8","updated":"2017-07-07 11:23:21.000000000","message":"Done","commit_id":"9d4d017e74b5ae84c450e153f721d7b7c50ab0e3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"321978721e27392f4c52ade18026d2690e409732","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Update allocations"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creates one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f1d235d_6f5a032b","line":45,"updated":"2017-07-07 22:59:17.000000000","message":"Does this update existing allocation keys and create new entries?\n\nThat question came up here:\n\nhttps://review.openstack.org/#/c/481748/1/specs/pike/approved/custom-resource-classes-in-flavors.rst@110","commit_id":"e3cdb40f9681073b406d5f625f9098de7b7fe6c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d6835fa37da83ad4c35fd678def509632d0baffc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Update allocations"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creates one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f1d235d_0fb70f3d","line":45,"in_reply_to":"3f1d235d_6f5a032b","updated":"2017-07-07 23:03:22.000000000","message":"OK I see:\n\nhttps://github.com/openstack/nova/blob/dcea3ff68793a28cd546805ebcb2c0ae6c9b684d/nova/objects/resource_provider.py#L1810\n\nIt\u0027s a complete overwrite, so it deletes any existing allocations for the given resource provider and consumer, and then inserts whatever is in the request. Maybe we can modify the wording a bit to clarify that?","commit_id":"e3cdb40f9681073b406d5f625f9098de7b7fe6c4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5535b0c8fbc726ee8820f850bcf775e947231eab","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creates one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. rest_method:: PUT /allocations/{consumer_uuid}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f1d235d_9dd435eb","line":47,"updated":"2017-07-11 10:53:34.000000000","message":"Perhaps start with: \"Creates or updates...\" and then add a sentence:\n\nIf allocations already exist for this consumer, they are replaced.\n\nThis is implied by the fact that we use PUT, but since PUT semantics are frequently violated, we can\u0027t rely on the implication and need to be explicit.","commit_id":"e3cdb40f9681073b406d5f625f9098de7b7fe6c4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5c70446eeee4d87661c9765997e928e80a1e22ab","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creates one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. rest_method:: PUT /allocations/{consumer_uuid}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f1d235d_ce531239","line":47,"in_reply_to":"3f1d235d_9dd435eb","updated":"2017-07-11 13:52:36.000000000","message":"++ to cdent\u0027s suggestions above.","commit_id":"e3cdb40f9681073b406d5f625f9098de7b7fe6c4"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"40ea84c6a2f7690a1470eea9c1489bf0bb8ca8c2","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creates one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. rest_method:: PUT /allocations/{consumer_uuid}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"1f1a1f67_02949443","line":47,"in_reply_to":"3f1d235d_9dd435eb","updated":"2017-07-12 10:12:59.000000000","message":"Updated. I used an imperative mood here since it\u0027s used in all similar places including your resource provider api-ref which serves as a reference for me.","commit_id":"e3cdb40f9681073b406d5f625f9098de7b7fe6c4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"81b532f7988299f9fb55bf5b286b0b809f4740a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Normal Response Codes: 204"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* `409 Conflict` if there is no available inventory in any of the resource"},{"line_number":57,"context_line":"  providers for any specified resource classes."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1f1a1f67_077e9418","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":37},"updated":"2017-07-14 06:21:45.000000000","message":"to consist to other patches, we might add reason for this error code?","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"42914152834556a8c7e98b3071661fa3a6e84c8d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Normal Response Codes: 204"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* `409 Conflict` if there is no available inventory in any of the resource"},{"line_number":57,"context_line":"  providers for any specified resource classes."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1f1a1f67_be3fd423","line":54,"in_reply_to":"1f1a1f67_077e9418","updated":"2017-07-14 18:00:31.000000000","message":"We\u0027ve not been covering all the possible error conditions, only those that are \"interesting\"  but I\u0027m not sure on what we\u0027ve been judging \"interesting-ness\".","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b130b0cc665fb4aa43c0a0d860285126741f2514","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Normal Response Codes: 204"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* `409 Conflict` if there is no available inventory in any of the resource"},{"line_number":57,"context_line":"  providers for any specified resource classes."}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1f1a1f67_73724aaf","line":54,"in_reply_to":"1f1a1f67_be3fd423","updated":"2017-07-18 10:15:32.000000000","message":"In this api-ref I\u0027ve not described badRequest since reason is usually simple and can be discovered by looking into params description or by applying a common logic.","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"81b532f7988299f9fb55bf5b286b0b809f4740a6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* `409 Conflict` if there is no available inventory in any of the resource"},{"line_number":57,"context_line":"  providers for any specified resource classes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Request"},{"line_number":60,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1f1a1f67_e7227801","line":57,"range":{"start_line":56,"start_character":16,"end_line":57,"end_character":47},"updated":"2017-07-14 06:21:45.000000000","message":"or concurrent update by \nexception.ConcurrentUpdateDetected\nexception","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b130b0cc665fb4aa43c0a0d860285126741f2514","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* `409 Conflict` if there is no available inventory in any of the resource"},{"line_number":57,"context_line":"  providers for any specified resource classes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Request"},{"line_number":60,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"1f1a1f67_13e2f6a0","line":57,"range":{"start_line":56,"start_character":16,"end_line":57,"end_character":47},"in_reply_to":"1f1a1f67_e7227801","updated":"2017-07-18 10:15:32.000000000","message":"Added \u0027or inventories\n  are updated by another thread while attempting the operation.\u0027","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4384052cd72f4f9cbf184a09587a3df112b349f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Update allocations"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Create or update one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":"If allocations already exist for this consumer, they are replaced."}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df3967d1_9795c835","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":47},"updated":"2017-08-03 16:14:57.000000000","message":"Is this true after https://review.openstack.org/#/c/489273/ ? We should be clear here that the PUT /allocations API is a full overwrite of the existing allocations for the given consumer.","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"135a4558049e7e7aa1353c40a14a0efd2ec341ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Update allocations"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Create or update one or more allocation records representing the consumption of"},{"line_number":46,"context_line":"one or more classes of resources from one or more resource providers by"},{"line_number":47,"context_line":"the consumer identified by `{consumer_uuid}`."},{"line_number":48,"context_line":"If allocations already exist for this consumer, they are replaced."}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df3967d1_2ecd8330","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":47},"in_reply_to":"df3967d1_9795c835","updated":"2017-08-04 15:32:10.000000000","message":"@mriedem: The line below states \"If allocations already exist for this consumer, they are replaced.\"","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d2dd8bd2f7d23da56bb7c54c68cabc9a0ef0bb55","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  - allocations: allocations_array"},{"line_number":67,"context_line":"  - resources: resources"},{"line_number":68,"context_line":"  - resource_provider: resource_provider_object"},{"line_number":69,"context_line":"  - uuid: resource_provider_uuid"},{"line_number":70,"context_line":"  - project_id: project_id_body"},{"line_number":71,"context_line":"  - user_id: user_id_body"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df3967d1_17f8b878","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":8},"updated":"2017-08-03 16:18:19.000000000","message":"Since this is nested under the resource_provider dict, it should be named in the format of resource_provider.uuid I think, that\u0027s the convention we\u0027re trying to use in the compute REST API anyway.\n\nMaybe we haven\u0027t done that nested naming format anywhere else in the placement API reference though.","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"c452f56160576fe257bb7ce20302c911f4538709","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  - allocations: allocations_array"},{"line_number":67,"context_line":"  - resources: resources"},{"line_number":68,"context_line":"  - resource_provider: resource_provider_object"},{"line_number":69,"context_line":"  - uuid: resource_provider_uuid"},{"line_number":70,"context_line":"  - project_id: project_id_body"},{"line_number":71,"context_line":"  - user_id: user_id_body"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":16,"id":"df3967d1_92a156fb","line":69,"in_reply_to":"df3967d1_17f8b878","updated":"2017-08-03 16:31:34.000000000","message":"That convention came along after the placement ref started, and I don\u0027t think it caught on here. We could do it, but it\u0027ll require going back to some of the already merged stuff.","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"}],"placement-api-ref/source/index.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"640df2a375031891063477f443320e98395f1d6a","unresolved":false,"context_lines":[{"line_number":21,"context_line":".. include:: inventory.inc"},{"line_number":22,"context_line":".. include:: aggregates.inc"},{"line_number":23,"context_line":".. include:: traits.inc"},{"line_number":24,"context_line":".. include:: resource_provider_traits.inc"},{"line_number":25,"context_line":".. include:: allocations.inc"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f201791_4642ee3f","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":41},"updated":"2017-06-27 06:17:27.000000000","message":"This file is not added.\nWrong file name?","commit_id":"12c2227c6191f5d31952fd808a47118adafc33d9"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7542a54d674fc777f697acf48f935ee7b53245f8","unresolved":false,"context_lines":[{"line_number":21,"context_line":".. include:: inventory.inc"},{"line_number":22,"context_line":".. include:: aggregates.inc"},{"line_number":23,"context_line":".. include:: traits.inc"},{"line_number":24,"context_line":".. include:: resource_provider_traits.inc"},{"line_number":25,"context_line":".. include:: allocations.inc"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f201791_46251c08","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":41},"in_reply_to":"5f201791_4642ee3f","updated":"2017-06-28 08:53:41.000000000","message":"yeah, messed with rebase.","commit_id":"12c2227c6191f5d31952fd808a47118adafc33d9"}],"placement-api-ref/source/parameters.yaml":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"81b532f7988299f9fb55bf5b286b0b809f4740a6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"user_id: \u0026user_id"},{"line_number":82,"context_line":"  type: string"},{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_a7dfe0d4","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":17},"updated":"2017-07-14 06:21:45.000000000","message":"just curious, the output didn\u0027t show it\u0027s optional ,should some changes need in the doc template to show it? \n\nhttp://docs-draft.openstack.org/33/470933/13/check/gate-placement-api-ref-nv/3744bba//placement-api-ref/build/html/?expanded\u003dlist-allocations-detail,update-allocations-detail,delete-allocations-detail\n\nproject_id \tbody \tstring \t\n\nThe uuid of a project.\n\nNew in version 1.8\nuser_id \tbody \tstring \t\n\nThe uuid of a user.\n\nNew in version 1.8","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"42914152834556a8c7e98b3071661fa3a6e84c8d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"user_id: \u0026user_id"},{"line_number":82,"context_line":"  type: string"},{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_feeaec72","line":84,"in_reply_to":"1f1a1f67_a7dfe0d4","updated":"2017-07-14 18:00:31.000000000","message":"\"just curious, the output didn\u0027t show it\u0027s optional ,should some changes need in the doc template to show it?\"\n\nGood question, I\u0027ve wondered about that too.","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b130b0cc665fb4aa43c0a0d860285126741f2514","unresolved":false,"context_lines":[{"line_number":81,"context_line":"user_id: \u0026user_id"},{"line_number":82,"context_line":"  type: string"},{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_53406ea5","line":84,"in_reply_to":"1f1a1f67_feeaec72","updated":"2017-07-18 10:15:32.000000000","message":"That user_id is for usages, but I defined it in one place to avoid duplication. Those which are in body are required.","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"81b532f7988299f9fb55bf5b286b0b809f4740a6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# variables in body"},{"line_number":89,"context_line":"aggregates:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_c74f7cbb","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":17},"updated":"2017-07-14 06:21:45.000000000","message":"an","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b130b0cc665fb4aa43c0a0d860285126741f2514","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# variables in body"},{"line_number":89,"context_line":"aggregates:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_b368e21c","line":86,"in_reply_to":"1f1a1f67_7e937cfb","updated":"2017-07-18 10:15:32.000000000","message":"In addition to the Chris answer, as user sounds like \"yu..\" we use a, not an here.","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"42914152834556a8c7e98b3071661fa3a6e84c8d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  in: query"},{"line_number":84,"context_line":"  required: false"},{"line_number":85,"context_line":"  description: \u003e"},{"line_number":86,"context_line":"    The uuid of a user."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# variables in body"},{"line_number":89,"context_line":"aggregates:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_7e937cfb","line":86,"in_reply_to":"1f1a1f67_c74f7cbb","updated":"2017-07-14 18:00:31.000000000","message":"The is okay in this case because we\u0027re talking about a specific user and a specific uuid and since uuid is an acronym (even though we use it lower case) it expands as:\n\nThe universally unique identififer of a user","commit_id":"1f2013aa4e92f18e214023e40759b9d9b01068ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b4384052cd72f4f9cbf184a09587a3df112b349f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"allocation_ratio_opt:"},{"line_number":111,"context_line":"  \u003c\u003c: *allocation_ratio"},{"line_number":112,"context_line":"  required: false"},{"line_number":113,"context_line":"allocations_array:"},{"line_number":114,"context_line":"  type: array"},{"line_number":115,"context_line":"  in: body"},{"line_number":116,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df3967d1_9790284c","line":113,"updated":"2017-08-03 16:14:57.000000000","message":"Given https://review.openstack.org/#/c/490195/ should we mention that at least one entry is required?","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"135a4558049e7e7aa1353c40a14a0efd2ec341ec","unresolved":false,"context_lines":[{"line_number":110,"context_line":"allocation_ratio_opt:"},{"line_number":111,"context_line":"  \u003c\u003c: *allocation_ratio"},{"line_number":112,"context_line":"  required: false"},{"line_number":113,"context_line":"allocations_array:"},{"line_number":114,"context_line":"  type: array"},{"line_number":115,"context_line":"  in: body"},{"line_number":116,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df3967d1_8ee34fa4","line":113,"in_reply_to":"df3967d1_9790284c","updated":"2017-08-04 15:32:10.000000000","message":"We can add later, I think?","commit_id":"64ae6832db2bea4c06d666695958ee64728d42d8"}]}