)]}'
{"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d387415d59d9adc8ecb73ef7f59f3b07eb2a16e3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"},{"line_number":73,"context_line":"                          \u0027secret_uuid value.\u0027)"},{"line_number":74,"context_line":"                conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_b65f610d","line":73,"updated":"2017-06-09 13:11:19.000000000","message":"It\u0027ll add a lot of logs if Cinder is not correctly configured, but LGTM.","commit_id":"f2d27f6a8afb62815fb6a885bd4f8ae4ed287fd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a8c86a3689fbf333b2b70d51db75c278aac645b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.warning(_LW(\u0027Falling back to Nova configuration values for \u0027"},{"line_number":85,"context_line":"                            \u0027RBD authentication. Cinder should be configured \u0027"},{"line_number":86,"context_line":"                            \u0027for auth with Ceph volumes. This fallback will \u0027"},{"line_number":87,"context_line":"                            \u0027be dropped in the Nova 16.0.0 Pike release.\u0027))"},{"line_number":88,"context_line":"            # use the nova config values"},{"line_number":89,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":90,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_bdaaa716","line":87,"range":{"start_line":87,"start_character":47,"end_line":87,"end_character":63},"updated":"2017-06-09 08:33:11.000000000","message":"Is this still a valid timeline?","commit_id":"f2d27f6a8afb62815fb6a885bd4f8ae4ed287fd3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b7b318a2c5a81c6eb6cb171ee716b4ce5c46286","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.warning(_LW(\u0027Falling back to Nova configuration values for \u0027"},{"line_number":85,"context_line":"                            \u0027RBD authentication. Cinder should be configured \u0027"},{"line_number":86,"context_line":"                            \u0027for auth with Ceph volumes. This fallback will \u0027"},{"line_number":87,"context_line":"                            \u0027be dropped in the Nova 16.0.0 Pike release.\u0027))"},{"line_number":88,"context_line":"            # use the nova config values"},{"line_number":89,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":90,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_16b16d90","line":87,"range":{"start_line":87,"start_character":47,"end_line":87,"end_character":63},"in_reply_to":"9f0e0f27_4c5bdb86","updated":"2017-06-09 13:40:07.000000000","message":"I think the warning is fine for getting deployments over to the new cinder-preferred way of doing this. The new note above is just so we don\u0027t remove it before we have the migration path sorted out.","commit_id":"f2d27f6a8afb62815fb6a885bd4f8ae4ed287fd3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d56e9fd9acd89972cade0a0cb29e44e2f778225b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.warning(_LW(\u0027Falling back to Nova configuration values for \u0027"},{"line_number":85,"context_line":"                            \u0027RBD authentication. Cinder should be configured \u0027"},{"line_number":86,"context_line":"                            \u0027for auth with Ceph volumes. This fallback will \u0027"},{"line_number":87,"context_line":"                            \u0027be dropped in the Nova 16.0.0 Pike release.\u0027))"},{"line_number":88,"context_line":"            # use the nova config values"},{"line_number":89,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":90,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_4c5bdb86","line":87,"range":{"start_line":87,"start_character":47,"end_line":87,"end_character":63},"in_reply_to":"9f0e0f27_bdaaa716","updated":"2017-06-09 11:34:19.000000000","message":"good question, I think what this has demonstrated is that this is *also* going to need a db migration before this can be dropped.\n\nThat being said, this is a real issue impacting users, we should get this in and backported.","commit_id":"f2d27f6a8afb62815fb6a885bd4f8ae4ed287fd3"}]}