)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"252ef693dedef2cd97e69d4d9772b923443bff57","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"                    objects.InstanceNUMATopology, \"get_by_instance_uuid\","},{"line_number":2852,"context_line":"                    return_value\u003dinstance_topology),"},{"line_number":2853,"context_line":"                mock.patch.object(host.Host, \u0027has_min_version\u0027,"},{"line_number":2854,"context_line":"                                  side_effect\u003d[True, True, True, True, True,"},{"line_number":2855,"context_line":"                                               False,  # libvirt hard_limit"},{"line_number":2856,"context_line":"                                               True, True]),"},{"line_number":2857,"context_line":"                mock.patch.object(host.Host, \"get_capabilities\","},{"line_number":2858,"context_line":"                                  return_value\u003dcaps),"},{"line_number":2859,"context_line":"                mock.patch.object("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_2be72043","line":2856,"range":{"start_line":2854,"start_character":34,"end_line":2856,"end_character":58},"updated":"2017-06-22 15:44:56.000000000","message":"See comments on the next page - I don\u0027t think we should do this (it\u0027s way too error prone)","commit_id":"53fbc8bfde9fad8652105863ce39bc124fc9c4a5"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f739e9ee6b17f77b5c2e5c12b26d8e44814bb08","unresolved":false,"context_lines":[{"line_number":302,"context_line":"# for its own use, so our only way out is to remove the limit"},{"line_number":303,"context_line":"# altogether. Use with extreme care."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"# TODO(sahid): Remove this and code associated when"},{"line_number":306,"context_line":"# MIN_LIBVIRT_VERSION \u003e\u003d 3.1.0."},{"line_number":307,"context_line":"HARD_LIMIT_UNLIMITED \u003d sys.maxint \u003e\u003e 10"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_f96b931c","line":306,"range":{"start_line":305,"start_character":0,"end_line":306,"end_character":31},"updated":"2017-06-09 15:59:31.000000000","message":"What happens in 3.1.0? Can you document this in the commit message?","commit_id":"b4e9c3ba607556f9c5644538bf9e13058b547cda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f739e9ee6b17f77b5c2e5c12b26d8e44814bb08","unresolved":false,"context_lines":[{"line_number":4748,"context_line":"            instance.numa_topology,"},{"line_number":4749,"context_line":"            guest_numa_config.numatune,"},{"line_number":4750,"context_line":"            flavor)"},{"line_number":4751,"context_line":"        if guest.membacking and guest.membacking.locked:"},{"line_number":4752,"context_line":"            guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":4753,"context_line":"            guest.memtune.hard_limit \u003d HARD_LIMIT_UNLIMITED"},{"line_number":4754,"context_line":""},{"line_number":4755,"context_line":"        guest.metadata.append(self._get_guest_config_meta(instance))"},{"line_number":4756,"context_line":"        guest.idmaps \u003d self._get_guest_idmaps()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_592f27f6","line":4753,"range":{"start_line":4751,"start_character":0,"end_line":4753,"end_character":59},"updated":"2017-06-09 15:59:31.000000000","message":"can we move this to the \u0027_get_guest_memory_backing_config\u0027 function. Also, can you only do this if libvirt \u003c 3.10.0, given the risk you\u0027ve mentioned above","commit_id":"b4e9c3ba607556f9c5644538bf9e13058b547cda"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"252ef693dedef2cd97e69d4d9772b923443bff57","unresolved":false,"context_lines":[{"line_number":4769,"context_line":"            instance.numa_topology,"},{"line_number":4770,"context_line":"            guest_numa_config.numatune,"},{"line_number":4771,"context_line":"            flavor)"},{"line_number":4772,"context_line":"        if guest.membacking and guest.membacking.locked:"},{"line_number":4773,"context_line":"            if not self._host.has_min_version("},{"line_number":4774,"context_line":"                    MIN_LIBVIRT_AUTO_HARD_LIMIT_SUPPORT):"},{"line_number":4775,"context_line":"                guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":4776,"context_line":"                guest.memtune.hard_limit \u003d HARD_LIMIT_UNLIMITED"},{"line_number":4777,"context_line":""},{"line_number":4778,"context_line":"        guest.metadata.append(self._get_guest_config_meta(instance))"},{"line_number":4779,"context_line":"        guest.idmaps \u003d self._get_guest_idmaps()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_cb630cb1","line":4776,"range":{"start_line":4772,"start_character":0,"end_line":4776,"end_character":63},"updated":"2017-06-22 15:44:56.000000000","message":"You might drag this out to another function - the way that you\u0027re testing on the previous page seems pretty unmaintainable (anyone that adds a new call to \u0027has_min_version\u0027 would need to modify that test).\n\nPerhaps a \u0027_get_guest_memory_tuning\u0027 function would do?","commit_id":"53fbc8bfde9fad8652105863ce39bc124fc9c4a5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"65aabf8632d3f843c4196e4d73c3e4a4c78a3803","unresolved":false,"context_lines":[{"line_number":4773,"context_line":"            if not self._host.has_min_version("},{"line_number":4774,"context_line":"                    MIN_LIBVIRT_AUTO_HARD_LIMIT_SUPPORT):"},{"line_number":4775,"context_line":"                guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":4776,"context_line":"                guest.memtune.hard_limit \u003d HARD_LIMIT_UNLIMITED"},{"line_number":4777,"context_line":""},{"line_number":4778,"context_line":"        guest.metadata.append(self._get_guest_config_meta(instance))"},{"line_number":4779,"context_line":"        guest.idmaps \u003d self._get_guest_idmaps()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_33d256d2","line":4776,"in_reply_to":"5f201791_830c73ec","updated":"2017-06-28 15:18:11.000000000","message":"Not sure ot understand which single call will be mocked.\n\nCould you write me how do you see the test?","commit_id":"53fbc8bfde9fad8652105863ce39bc124fc9c4a5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50ed52d549cb22db9343c9388be9ab6cc67b4d57","unresolved":false,"context_lines":[{"line_number":4773,"context_line":"            if not self._host.has_min_version("},{"line_number":4774,"context_line":"                    MIN_LIBVIRT_AUTO_HARD_LIMIT_SUPPORT):"},{"line_number":4775,"context_line":"                guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":4776,"context_line":"                guest.memtune.hard_limit \u003d HARD_LIMIT_UNLIMITED"},{"line_number":4777,"context_line":""},{"line_number":4778,"context_line":"        guest.metadata.append(self._get_guest_config_meta(instance))"},{"line_number":4779,"context_line":"        guest.idmaps \u003d self._get_guest_idmaps()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_830c73ec","line":4776,"in_reply_to":"5f201791_99cacd4b","updated":"2017-06-27 08:37:43.000000000","message":"Very true, but there\u0027d only be a single call to mock. That might be a better choice?","commit_id":"53fbc8bfde9fad8652105863ce39bc124fc9c4a5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"80453a6db272d062ca1d02f3c6b1f6325086548c","unresolved":false,"context_lines":[{"line_number":4773,"context_line":"            if not self._host.has_min_version("},{"line_number":4774,"context_line":"                    MIN_LIBVIRT_AUTO_HARD_LIMIT_SUPPORT):"},{"line_number":4775,"context_line":"                guest.memtune \u003d vconfig.LibvirtConfigGuestMemoryTune()"},{"line_number":4776,"context_line":"                guest.memtune.hard_limit \u003d HARD_LIMIT_UNLIMITED"},{"line_number":4777,"context_line":""},{"line_number":4778,"context_line":"        guest.metadata.append(self._get_guest_config_meta(instance))"},{"line_number":4779,"context_line":"        guest.idmaps \u003d self._get_guest_idmaps()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_99cacd4b","line":4776,"in_reply_to":"5f201791_cb630cb1","updated":"2017-06-26 07:58:02.000000000","message":"I can put it to a seperate function but having that is not going to help I will still have to mock the returned value of has_min_version to False","commit_id":"53fbc8bfde9fad8652105863ce39bc124fc9c4a5"}]}