)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8b40896ae4f1c7efc7b796bd8d727da9edfb77d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Garbutt \u003cjohn@johngarbutt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-09 12:19:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Use oslo.polcy DocumentedRuleDefault"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove the in tree hack of create_rule_default, and call through"},{"line_number":10,"context_line":"to the offical oslo implementation of either DocumentedRuleDefault"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f201791_3e9e8d07","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":19},"updated":"2017-06-20 14:41:09.000000000","message":"policy","commit_id":"e19acaf728ad16c06ca9a29b653a5154f6dbd738"}],"nova/policies/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a90070e190ddc5060ced979c274f796003c145b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def create_rule_default(name, check_str, description, operations):"},{"line_number":49,"context_line":"    # TODO(sneti): use DocumentedRuleDefault instead of RuleDefault when"},{"line_number":50,"context_line":"    # oslo.policy library is bumped to 1.21.0. The formatted_description hack"},{"line_number":51,"context_line":"    # can be removed then."},{"line_number":52,"context_line":"    ops \u003d \"\""},{"line_number":53,"context_line":"    for operation in operations:"},{"line_number":54,"context_line":"            ops +\u003d (\u0027%(method)s %(path)s\\n\u0027 %"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_5bb59bcc","side":"PARENT","line":51,"range":{"start_line":49,"start_character":4,"end_line":51,"end_character":26},"updated":"2017-07-13 16:54:56.000000000","message":"And this is fine since DocumentedRuleDefault was released in oslo.policy 1.21.0 and we require oslo.policy\u003e\u003d1.23.0\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L142","commit_id":"768d7cc0a632e1a880f00c5840c1ec8051e161be"}],"nova/policies/cells_scheduler.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"70d8b87179ddcdb28897549e2fee31736ce37b22","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cells_scheduler_policies \u003d ["},{"line_number":23,"context_line":"    policy.RuleDefault("},{"line_number":24,"context_line":"        POLICY_ROOT % \u0027DifferentCellFilter\u0027,"},{"line_number":25,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":26,"context_line":"        \"\"\"Different cell filter to route a build away from a particular cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_19af6f95","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":23},"updated":"2017-06-09 15:48:22.000000000","message":"why is this different? Looks like only the \u0027ops\u0027 argument is missing, but I don\u0027t know why. Perhaps we could keep \u0027create_rule_default\u0027 as a \"no ops -\u003e RuleDefault\", \"some ops -\u003e DocumentedRuleDefault\" mapping abstraction?","commit_id":"e19acaf728ad16c06ca9a29b653a5154f6dbd738"}],"nova/tests/unit/test_policy.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a90070e190ddc5060ced979c274f796003c145b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                          self.context, action, self.target)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class PolicyDocsTestCase(test.NoDBTestCase):"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_create_rule_default(self):"},{"line_number":242,"context_line":"        rule_default \u003d base.create_rule_default("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_1b9e0354","side":"PARENT","line":239,"range":{"start_line":239,"start_character":6,"end_line":239,"end_character":24},"updated":"2017-07-13 16:54:56.000000000","message":"OK so even though we have the create_rule_default method as a proxy to oslo.policy DocumentedRuleDefault, we don\u0027t want to unit test it since it would be testing the internals of oslo.policy which could break us, so yeah this is fine.","commit_id":"768d7cc0a632e1a880f00c5840c1ec8051e161be"}]}