)]}'
{"nova/image/glance.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"de5d589d215d29ecc262c30b74ced85de8db2f59","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        # glanceclient will fail later when trying to connect."},{"line_number":122,"context_line":"        return api_servers"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    for api_server in CONF.glance.api_servers:"},{"line_number":125,"context_line":"        if \u0027//\u0027 not in api_server:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f0e0f27_99836e57","line":122,"updated":"2017-06-09 13:49:26.000000000","message":"I would just throw an exception here, because otherwise all that\u0027s going to happen is a really clear different exception later as none of the code can handle this not returning a real server.","commit_id":"2f10d271d8f2374a4eab141601684d2909798a37"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aaa15d95046ce75e8956046771d137d322e3194c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    if not CONF.glance.api_servers:"},{"line_number":117,"context_line":"        # FIXME(sbauza): Use the ServiceCatalog if the operator hasn\u0027t provided"},{"line_number":118,"context_line":"        # directly the glance endpoints."},{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        raise exception.GlanceNotConfigured(reason\u003d\u0027api_servers is unset\u0027)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_440f212e","line":119,"range":{"start_line":119,"start_character":18,"end_line":119,"end_character":22},"updated":"2017-06-12 01:00:12.000000000","message":"It is unnecessary. Remove it.","commit_id":"698c07a94f1e413d0e68e5bf7d763de461563f29"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"29d9a1d0d2ac55e69bcd6b157da0e783c6f0863d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    if not CONF.glance.api_servers:"},{"line_number":117,"context_line":"        # FIXME(sbauza): Use the ServiceCatalog if the operator hasn\u0027t provided"},{"line_number":118,"context_line":"        # directly the glance endpoints."},{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        raise exception.GlanceNotConfigured(reason\u003d\u0027api_servers is unset\u0027)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_ddb1c3e3","line":119,"range":{"start_line":119,"start_character":18,"end_line":119,"end_character":22},"in_reply_to":"7f231b9d_440f212e","updated":"2017-06-12 07:37:12.000000000","message":"agree","commit_id":"698c07a94f1e413d0e68e5bf7d763de461563f29"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aaa15d95046ce75e8956046771d137d322e3194c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # directly the glance endpoints."},{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        raise exception.GlanceNotConfigured(reason\u003d\u0027api_servers is unset\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    for api_server in CONF.glance.api_servers:"},{"line_number":124,"context_line":"        if \u0027//\u0027 not in api_server:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_04192978","line":121,"range":{"start_line":121,"start_character":51,"end_line":121,"end_character":73},"updated":"2017-06-12 01:00:12.000000000","message":"_(\u0027api_servers is unset\u0027)","commit_id":"698c07a94f1e413d0e68e5bf7d763de461563f29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"758fb503a9bf080c6bb71f9f436004ba20e5062c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # directly the glance endpoints."},{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        raise exception.GlanceNotConfigured(reason\u003d\u0027api_servers is unset\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    for api_server in CONF.glance.api_servers:"},{"line_number":124,"context_line":"        if \u0027//\u0027 not in api_server:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_434c803e","line":121,"range":{"start_line":121,"start_character":51,"end_line":121,"end_character":73},"in_reply_to":"3fa7e38b_83d8387f","updated":"2019-11-15 18:39:40.000000000","message":"I guess this new exception is still going to be an error 500, but with a better explanation, so strictly speaking better than what we had before, but...","commit_id":"698c07a94f1e413d0e68e5bf7d763de461563f29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"0ff5668d2e2e502929001090f2dd0043192570fe","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # directly the glance endpoints."},{"line_number":119,"context_line":"        LOG.error(_LE(\u0027Configuration option [glance]/api_servers not correctly\u0027"},{"line_number":120,"context_line":"                      \u0027 configured, please set it.\u0027))"},{"line_number":121,"context_line":"        raise exception.GlanceNotConfigured(reason\u003d\u0027api_servers is unset\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    for api_server in CONF.glance.api_servers:"},{"line_number":124,"context_line":"        if \u0027//\u0027 not in api_server:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_83d8387f","line":121,"range":{"start_line":121,"start_character":51,"end_line":121,"end_character":73},"in_reply_to":"7f231b9d_04192978","updated":"2019-11-15 18:32:26.000000000","message":"Can this exception bubble up to the API? I assume so, because the associated bug is an error 500 if we get a TypeError here.\n\nSo, what would be the correct error code here for such an exception? It\u0027s not anything the user can fix, so not 4xx. I almost want to say 500 was the correct thing to do in this case.\n\nWhich means just raising a different exception is not the solution. Until we get logic in here to use the service catalog, looks like CONF.glance.api_servers is mandatory and we shouldn\u0027t start nova-api if it\u0027s not set? I realize how extreme that sounds, so someone please spot a flaw in the logic that lead me here.","commit_id":"698c07a94f1e413d0e68e5bf7d763de461563f29"}]}