)]}'
{"nova/virt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da2372b404448831d9da4b795d72c84ab7c01905","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"    def _autoset_host_enabled(self, enabled, reason\u003dNone):"},{"line_number":1172,"context_line":"        \"\"\"Enables / Disables the compute service on this host."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"           This doesn\u0027t override non-automatic disablement with an automatic"},{"line_number":1175,"context_line":"           setting; thereby permitting operators to keep otherwise"},{"line_number":1176,"context_line":"           healthy hosts out of rotation."},{"line_number":1177,"context_line":"        \"\"\""},{"line_number":1178,"context_line":"        if enabled:"},{"line_number":1179,"context_line":"            if self._is_auto_disabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_9eae882c","line":1176,"range":{"start_line":1174,"start_character":0,"end_line":1176,"end_character":41},"updated":"2017-06-12 20:14:00.000000000","message":"outdent","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"a57a1c7332ba66062fdc7d78db1a46b483340af6","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"    def _autoset_host_enabled(self, enabled, reason\u003dNone):"},{"line_number":1172,"context_line":"        \"\"\"Enables / Disables the compute service on this host."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"           This doesn\u0027t override non-automatic disablement with an automatic"},{"line_number":1175,"context_line":"           setting; thereby permitting operators to keep otherwise"},{"line_number":1176,"context_line":"           healthy hosts out of rotation."},{"line_number":1177,"context_line":"        \"\"\""},{"line_number":1178,"context_line":"        if enabled:"},{"line_number":1179,"context_line":"            if self._is_auto_disabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_d67475d1","line":1176,"range":{"start_line":1174,"start_character":0,"end_line":1176,"end_character":41},"in_reply_to":"7f231b9d_9eae882c","updated":"2017-06-15 18:47:17.000000000","message":"Done","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da2372b404448831d9da4b795d72c84ab7c01905","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        LOG.info(\"Connection event \u0027%(enabled)d\u0027 reason \u0027%(reason)s\u0027\","},{"line_number":446,"context_line":"                 {\u0027enabled\u0027: enabled, \u0027reason\u0027: reason})"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            self._autoset_host_enabled(enabled, DISABLE_PREFIX + reason)"},{"line_number":449,"context_line":"        except exception.ComputeHostNotFound:"},{"line_number":450,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":451,"context_line":"                        \u0027since it is not registered.\u0027, CONF.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_fe133c65","line":448,"range":{"start_line":448,"start_character":65,"end_line":448,"end_character":71},"updated":"2017-06-12 20:14:00.000000000","message":"str(reason) in case reason is None.","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"a57a1c7332ba66062fdc7d78db1a46b483340af6","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        LOG.info(\"Connection event \u0027%(enabled)d\u0027 reason \u0027%(reason)s\u0027\","},{"line_number":446,"context_line":"                 {\u0027enabled\u0027: enabled, \u0027reason\u0027: reason})"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            self._autoset_host_enabled(enabled, DISABLE_PREFIX + reason)"},{"line_number":449,"context_line":"        except exception.ComputeHostNotFound:"},{"line_number":450,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":451,"context_line":"                        \u0027since it is not registered.\u0027, CONF.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_56374500","line":448,"range":{"start_line":448,"start_character":65,"end_line":448,"end_character":71},"in_reply_to":"7f231b9d_fe133c65","updated":"2017-06-15 18:47:17.000000000","message":"I\u0027d just copied this from below, but sure, I can fix that while we\u0027re in here. Done.","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da2372b404448831d9da4b795d72c84ab7c01905","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":451,"context_line":"                        \u0027since it is not registered.\u0027, CONF.host)"},{"line_number":452,"context_line":"        except Exception:"},{"line_number":453,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":454,"context_line":"                        \u0027due to an unexpected exception.\u0027, CONF.host,"},{"line_number":455,"context_line":"                        exc_info\u003dTrue)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_f908f628","line":453,"range":{"start_line":453,"start_character":16,"end_line":453,"end_character":23},"updated":"2017-06-12 20:14:00.000000000","message":"Consider LOG.exception here.\n\n[Later] Oh, copied/pasted from below.  Well, the suggestion stands ;-)","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"a57a1c7332ba66062fdc7d78db1a46b483340af6","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":451,"context_line":"                        \u0027since it is not registered.\u0027, CONF.host)"},{"line_number":452,"context_line":"        except Exception:"},{"line_number":453,"context_line":"            LOG.warning(\u0027Cannot update service status on host \"%s\" \u0027"},{"line_number":454,"context_line":"                        \u0027due to an unexpected exception.\u0027, CONF.host,"},{"line_number":455,"context_line":"                        exc_info\u003dTrue)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_562065ac","line":453,"range":{"start_line":453,"start_character":16,"end_line":453,"end_character":23},"in_reply_to":"7f231b9d_f908f628","updated":"2017-06-15 18:47:17.000000000","message":"Done","commit_id":"e0c0ca863ac8ec287c51cb453b99e0f51b60fb50"}]}
