)]}'
{"nova/virt/libvirt/connection.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"90aba61d949368fae4d4d0e7f10822ec1b2cabe9","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        \"\"\""},{"line_number":663,"context_line":"        dom \u003d self._lookup_by_name(instance.name)"},{"line_number":664,"context_line":"        dom.shutdown()"},{"line_number":665,"context_line":"        # NOTE(vish): this doesn\u0027t actually could take slighty longer"},{"line_number":666,"context_line":"        #             than the FLAG defines depending on how long the"},{"line_number":667,"context_line":"        #             get_info call takes to return."},{"line_number":668,"context_line":"        for x in xrange(FLAGS.libvirt_wait_reboot_seconds):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fz4A%3D","line":665,"updated":"2012-03-01 16:30:06.000000000","message":"s/doesn\u0027t //","commit_id":"945e961b5aa4eda86b132b1ca9004e9d204ea2fe"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"61e3e35406d2ee2e004fd96f4ca246509eec9585","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        reboot happens, as the guest OS cannot ignore this action."},{"line_number":685,"context_line":"        \"\"\""},{"line_number":686,"context_line":"        if reboot_type !\u003d \u0027HARD\u0027:"},{"line_number":687,"context_line":"            # NOTE(vish): this will attempt to do a graceful shutedown/restart"},{"line_number":688,"context_line":"            if self._soft_reboot(instance):"},{"line_number":689,"context_line":"                LOG.info(_(\"Instance soft rebooted successfully.\"),"},{"line_number":690,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fz3Q%3D","line":687,"updated":"2012-03-01 16:49:57.000000000","message":"typo... s/shutedown/shutdown/","commit_id":"945e961b5aa4eda86b132b1ca9004e9d204ea2fe"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"90aba61d949368fae4d4d0e7f10822ec1b2cabe9","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        # NOTE(itoumsn): self.shutdown() and wait instead of self.destroy() is"},{"line_number":704,"context_line":"        # better because we cannot ensure flushing dirty buffers"},{"line_number":705,"context_line":"        # in the guest OS. But, in case of KVM, shutdown() does not work..."},{"line_number":706,"context_line":"        self._destroy(instance, network_info, cleanup\u003dFalse)"},{"line_number":707,"context_line":"        self.unplug_vifs(instance, network_info)"},{"line_number":708,"context_line":"        self.plug_vifs(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fz34%3D","line":705,"updated":"2012-03-01 16:30:06.000000000","message":"should this comment be adjusted now.\nThere is no point to the new code if shutdown() _does_ not work\nI would mention that something like acpid needs to be installed on the\nguests for shutdown() to work. In fact I\u0027d probably move the comment from here\nup to the _soft_reboot() function itself","commit_id":"945e961b5aa4eda86b132b1ca9004e9d204ea2fe"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6ed4a79283d83c1e8ca99cb2776042969c9b5e2b","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                snapshot_ptr.delete(0)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    @exception.wrap_exception()"},{"line_number":652,"context_line":"    def reboot(self, instance, network_info, reboot_type\u003dNone, xml\u003dNone):"},{"line_number":653,"context_line":"        \"\"\"Reboot a virtual machine, given an instance reference."},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        This method actually destroys and re-creates the domain to ensure the"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2Fz2A%3D","side":"PARENT","line":652,"updated":"2012-03-01 17:26:39.000000000","message":"Why not just default reboot_type to \u0027HARD\u0027? You can avoid making extra changes in rescue/unrescue if you do.","commit_id":"29d021ba9063a9db16b29a327af9581b58a8e2f7"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6ed4a79283d83c1e8ca99cb2776042969c9b5e2b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"               help\u003d\u0027Override the default disk prefix for the devices attached\u0027"},{"line_number":152,"context_line":"                    \u0027 to a server, which is dependent on libvirt_type. \u0027"},{"line_number":153,"context_line":"                    \u0027(valid options are: sd, xvd, uvd, vd)\u0027),"},{"line_number":154,"context_line":"    cfg.IntOpt(\u0027libvirt_wait_reboot_seconds\u0027,"},{"line_number":155,"context_line":"               default\u003d20,"},{"line_number":156,"context_line":"               help\u003d\u0027Number of seconds to wait for a soft reboot before \u0027"},{"line_number":157,"context_line":"                    \u0027switching to a hard reboot.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2Fz1w%3D","line":154,"updated":"2012-03-01 17:26:39.000000000","message":"In response to your last comment, I think the \u0027wait\u0027 here is fine, no need to change to \u0027attempts\u0027. But it would be nice to throw a \u0027soft\u0027 in there.","commit_id":"2b0de74ca1b240397a2668f121506309eee886b9"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6ed4a79283d83c1e8ca99cb2776042969c9b5e2b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                    \u0027(valid options are: sd, xvd, uvd, vd)\u0027),"},{"line_number":154,"context_line":"    cfg.IntOpt(\u0027libvirt_wait_reboot_seconds\u0027,"},{"line_number":155,"context_line":"               default\u003d20,"},{"line_number":156,"context_line":"               help\u003d\u0027Number of seconds to wait for a soft reboot before \u0027"},{"line_number":157,"context_line":"                    \u0027switching to a hard reboot.\u0027),"},{"line_number":158,"context_line":"    ]"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2Fz10%3D","line":156,"updated":"2012-03-01 17:26:39.000000000","message":"Can you rephrase this to better reflect how we\u0027re using it? Something like this might work:\n\nNumber of seconds to wait for instance to shut down after soft reboot request is made. Fall back to hard reboot if instance does not shutdown within this window.","commit_id":"2b0de74ca1b240397a2668f121506309eee886b9"}]}