)]}'
{"id":"openstack%2Fnova~4747","triplet_id":"openstack%2Fnova~master~I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef","project":"openstack/nova","branch":"master","topic":"bug/939557","hashtags":[],"change_id":"I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef","subject":"Adds soft-reboot support to libvirt","status":"MERGED","created":"2012-03-01 16:08:48.000000000","updated":"2012-03-03 00:52:59.000000000","submitted":"2012-03-03 00:52:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"618a06ad078356a2e0a6f1c0bad7688879481aeb","_number":4747,"virtual_id_number":4747,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-03-03 00:52:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"all":[{"value":2,"date":"2012-03-02 16:37:41.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":1,"date":"2012-03-02 14:57:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":2,"date":"2012-03-02 23:28:30.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-03-03 00:52:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"date":"2012-03-02 16:37:41.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":1,"date":"2012-03-02 23:28:30.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-01 16:49:57.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2012-03-01 18:28:00.000000000","updated_by":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"reviewer":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"state":"REVIEWER"},{"updated":"2012-03-01 21:16:52.000000000","updated_by":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"reviewer":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"state":"REVIEWER"},{"updated":"2012-03-02 14:57:07.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-03-02 16:37:41.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-03-03 00:52:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"90aba61d949368fae4d4d0e7f10822ec1b2cabe9","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-03-01 16:30:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nThis is an important one.\n\nIs 20s enough? I\u0027d have thought at least 30.\nA couple of suggested comment tweaks are inline","accounts_in_message":[],"_revision_number":1},{"id":"61e3e35406d2ee2e004fd96f4ca246509eec9585","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-03-01 16:49:57.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nSmall typo inline... but code looks good overall.","accounts_in_message":[],"_revision_number":1},{"id":"a3b3610f04edc44ce846b14883fb052d5d754d33","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:12:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"625e4acaf1fd15f67c348fbc54ab509889c69f95","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:12:44.000000000","message":"Patch Set 2:\n\nThanks for the input guys. I fixed the comments.","accounts_in_message":[],"_revision_number":2},{"id":"7cec6aad8f40d458b6736c43e6eae54b9416f6ef","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:17:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3d0ef33f0e7449d521dc7451d47c3ea6eccca591","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:19:52.000000000","message":"Patch Set 3:\n\nadded a test to force the soft reboot to fallback to a hard reboot.  I\u0027m not totally in love with the libvirt_wait_reboot_seconds name for the flag since it is actually implemented as a series of attempts with a 1 second delay. Should it be libvirt_shutdown_check_attempts or something?","accounts_in_message":[],"_revision_number":3},{"id":"6ed4a79283d83c1e8ca99cb2776042969c9b5e2b","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-03-01 17:26:39.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d4d7bac98a5014170ade89f19e85afca9865df4c","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:41:10.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"bdf37fed79abbb80f34108f4f4cec07ecb60f0cd","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 17:44:11.000000000","message":"Patch Set 4:\n\nupdated flag.\n\nBrian: Defaulting to \u0027HARD\u0027 seems wrong since the corresponding method in the manager defaults to \u0027SOFT\u0027.  I also think it is nasty for rescue/unrescue to use be using the public method and passing in an extra xml parameter.  I cleaned it up by pulling out into an internal _hard_reboot method and letting rescue and unrescue use that. I think this makes the interaction much clearer.","accounts_in_message":[],"_revision_number":4},{"id":"fe5490c790b235ba9b6adc1043655d57f5b4e3e7","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-03-01 17:45:54.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nI like this a lot, Vish. The refactoring had occurred to me but I didn\u0027t want to ask you to do it for the scope of this bug. Thanks for doing it!","accounts_in_message":[],"_revision_number":4},{"id":"5381ba45ba274b466777bef34c157f1c4d21dda8","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-03-01 18:13:08.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nnice one. cheers","accounts_in_message":[],"_revision_number":4},{"id":"4e9e4558a48a4b207d9b3c4b38ead4f2fb390474","author":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"date":"2012-03-01 18:28:00.000000000","message":"Patch Set 4:\n\nLooks great.  Some apps e.g. databases can take a very long time to shutdown, because they have to flush dirty buffers to disk (i.e. write close to 16GB of data on a 16GB instance), and so you\u0027d have to pick a very big allowed shutdown time window.  As an API caller, I\u0027m going to have my own timing logic anyway, and so for that use case ideally a soft reboot would never become hard.  However, I can see why you want the timing logic, because otherwise machines could get stuck in the shutdown state (though I thought we had code that would restart them?).\n\nI don\u0027t think there\u0027s a clean answer here, so instead this behavior should be very clearly documented, so that users know e.g. to tell their database to flush to disk, before sending the soft reboot command, so that the soft shutdown will succeed inside the allowed window.","accounts_in_message":[],"_revision_number":4},{"id":"263096944513316659d4acd04bb84cde66da9731","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 18:36:24.000000000","message":"Patch Set 4:\n\nHonestly, I think our api decisions might be a little off here.  I would think that there should be two separate commands instead of needing to fallback.  That is a more extensive change though, so in the meantime, should we increase the timeout to 60 seconds+\n\nI would think that if a user is going in to flush buffers etc. anyway, it probably would be easier to just issue a reboot command from the guest.","accounts_in_message":[],"_revision_number":4},{"id":"ba76664e2a9977bc78a6cf22ef5294640d4bb95f","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 18:37:18.000000000","message":"Patch Set 4:\n\nthat was a question: should we increase the timeout to 60 seconds?","accounts_in_message":[],"_revision_number":4},{"id":"22f1dab4276b146d7d51c5985be4ee20e628d1ac","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2012-03-01 18:43:33.000000000","message":"Patch Set 4:\n\nAt least. I\u0027m not-so-firmly in the camp of \"No Fallback\". From a customer\u0027s perspective (using the OSAPI) they\u0027ll issue a soft reboot and the state will be REBOOT while the reboot signal is sent until the server is powered off.\n\nIt would make sense for the server to be stuck in REBOOT IMO and after a while if still unsuccessful the user could send a hard_reboot action to put the server in HARD_REBOOT state.\n\nIt\u0027s a nice feature to have, but I\u0027d be much more comfortable with it at least being optional.\n\nCode looks fine for current feature-set.\n\n+1 on 60 seconds or more for default","accounts_in_message":[],"_revision_number":4},{"id":"c4837e9751144bbb5169ce2ffab50694b1aa9a01","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 18:58:13.000000000","message":"Patch Set 4:\n\nLamar: I was attempting to mirror what happens in xenapi.  My reading of the cleanup code in vm_ops was that there is a periodic check for stuck rebooting instances and a hard_reboot is automatically issued.  I want feature parity, so if this is incorrect, I will remove the fallback and just let it stay in rebooting","accounts_in_message":[],"_revision_number":4},{"id":"4f8601e3ec413054c2bdd5b05005e81726d5f69a","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2012-03-01 21:16:52.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\nGotcha. I wasn\u0027t even thinking about parity and while I think we\u0027ll end up re-visiting this from a customer perspective, feature parity is the right move.","accounts_in_message":[],"_revision_number":4},{"id":"b03932192b909172af515008cd00311d1f8754a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-01 21:37:01.000000000","message":"Patch Set 4: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1996/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1645/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1276/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3026/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"1fce93fcedaf88ad72e503008f88704194204ec3","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 21:59:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f8e3582bd9e3099e62fd7d7d6cf88c5c4423d639","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-01 22:00:22.000000000","message":"Patch Set 5:\n\nappears to be a temporary failure in jenkins, but I used the window to update the default timeout to 120 seconds.","accounts_in_message":[],"_revision_number":5},{"id":"15b6e178fe8f09424ff500b87af7984d4c5b503e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-01 22:17:50.000000000","message":"Patch Set 4:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1996/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1645/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3026/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1279/ : FAILURE","accounts_in_message":[],"_revision_number":4},{"id":"d1b82539fc0de0a65b5cb8ae658e29a742c44a24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-01 22:48:56.000000000","message":"Patch Set 4:\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1996/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1645/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3026/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1283/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"160295bbae7226caff4ef89802da7b98cc113375","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-03-02 14:57:07.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nI\u0027m happier the extra 100 seconds. cheers.","accounts_in_message":[],"_revision_number":5},{"id":"881d8f53e117e92dc9597118ff798b3e756bded0","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-03-02 16:37:41.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\nSomebody else can push this back in.","accounts_in_message":[],"_revision_number":5},{"id":"a4d276b9a74440a790961ddfadd4c2cc2389c419","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-02 23:28:30.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\nalready approved, but failed to merge due to transient jenkins error.  Sending in again.","accounts_in_message":[],"_revision_number":5},{"id":"2d71370860ac6fcaf4bf779f15db0f1f9e9e17e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-03 00:52:53.000000000","message":"Patch Set 5: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2048/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1670/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1303/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3051/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"6c36accca48703082557cb6dd1ab7fb78ec247f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-03 00:52:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"2efb017a06afeb10b474245455310ec21601a701","revisions":{"945e961b5aa4eda86b132b1ca9004e9d204ea2fe":{"kind":"REWORK","_number":1,"created":"2012-03-01 16:08:48.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/47/4747/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/4747/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/4747/1"}}},"commit":{"parents":[{"commit":"29d021ba9063a9db16b29a327af9581b58a8e2f7","subject":"Fixes lp931801 and a key_error","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29d021ba9063a9db16b29a327af9581b58a8e2f7"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 01:29:02.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 16:08:41.000000000","tz":-480},"subject":"Adds soft-reboot support to libvirt","message":"Adds soft-reboot support to libvirt\n\n * Falls back to hard reboot if guest doesn\u0027t respond\n * Fixed fake for test\n * Fixes bug 939557\n\nChange-Id: I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/945e961b5aa4eda86b132b1ca9004e9d204ea2fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/945e961b5aa4eda86b132b1ca9004e9d204ea2fe"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"29d021ba9063a9db16b29a327af9581b58a8e2f7","is_merged_in_target_branch":true,"change_id":"I8f533e8e54c5e4487614a61a73d9c8e2e756058d","change_number":4729,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7ed1e56e94d032c7fa9fc577c9ab61df34c565e7":{"kind":"REWORK","_number":2,"created":"2012-03-01 17:12:26.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/47/4747/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/4747/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/4747/2"}}},"commit":{"parents":[{"commit":"29d021ba9063a9db16b29a327af9581b58a8e2f7","subject":"Fixes lp931801 and a key_error","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29d021ba9063a9db16b29a327af9581b58a8e2f7"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 01:29:02.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 17:12:11.000000000","tz":-480},"subject":"Adds soft-reboot support to libvirt","message":"Adds soft-reboot support to libvirt\n\n * Falls back to hard reboot if guest doesn\u0027t respond\n * Fixed fake for test\n * Fixes bug 939557\n\nChange-Id: I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ed1e56e94d032c7fa9fc577c9ab61df34c565e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ed1e56e94d032c7fa9fc577c9ab61df34c565e7"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"29d021ba9063a9db16b29a327af9581b58a8e2f7","is_merged_in_target_branch":true,"change_id":"I8f533e8e54c5e4487614a61a73d9c8e2e756058d","change_number":4729,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"2b0de74ca1b240397a2668f121506309eee886b9":{"kind":"REWORK","_number":3,"created":"2012-03-01 17:17:13.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/47/4747/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/4747/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/4747/3"}}},"commit":{"parents":[{"commit":"29d021ba9063a9db16b29a327af9581b58a8e2f7","subject":"Fixes lp931801 and a key_error","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29d021ba9063a9db16b29a327af9581b58a8e2f7"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 01:29:02.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 17:16:23.000000000","tz":-480},"subject":"Adds soft-reboot support to libvirt","message":"Adds soft-reboot support to libvirt\n\n * Falls back to hard reboot if guest doesn\u0027t respond\n * Fixed fake for tests\n * Added a force hard reboot test to verify fallback works\n * Fixes bug 939557\n\nChange-Id: I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b0de74ca1b240397a2668f121506309eee886b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b0de74ca1b240397a2668f121506309eee886b9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"29d021ba9063a9db16b29a327af9581b58a8e2f7","is_merged_in_target_branch":true,"change_id":"I8f533e8e54c5e4487614a61a73d9c8e2e756058d","change_number":4729,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"bfd77654d45d02f286a9a5ab32c5b0095b591987":{"kind":"REWORK","_number":4,"created":"2012-03-01 17:41:10.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/47/4747/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/4747/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/4747/4"}}},"commit":{"parents":[{"commit":"777af73adde217a13fb7cf5237cdcda883b5546d","subject":"Merge \"sm vol driver: Fix regression in sm_backend_conf_update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/777af73adde217a13fb7cf5237cdcda883b5546d"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 01:29:02.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 17:41:04.000000000","tz":-480},"subject":"Adds soft-reboot support to libvirt","message":"Adds soft-reboot support to libvirt\n\n * Falls back to hard reboot if guest doesn\u0027t respond\n * Cleans up reboot/rescue/unrescue interaction\n * Fixed fake for tests\n * Added a force hard reboot test to verify fallback works\n * Fixes bug 939557\n\nChange-Id: I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bfd77654d45d02f286a9a5ab32c5b0095b591987"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bfd77654d45d02f286a9a5ab32c5b0095b591987"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"777af73adde217a13fb7cf5237cdcda883b5546d","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"2efb017a06afeb10b474245455310ec21601a701":{"kind":"REWORK","_number":5,"created":"2012-03-01 21:59:45.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/47/4747/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/4747/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/4747/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/4747/5"}}},"commit":{"parents":[{"commit":"34d50ed65fc6f68fa5efb524ab4d82eea8e499f0","subject":"Merge \"Remove unused imports and variables from OS API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34d50ed65fc6f68fa5efb524ab4d82eea8e499f0"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 01:29:02.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-03-01 21:59:35.000000000","tz":-480},"subject":"Adds soft-reboot support to libvirt","message":"Adds soft-reboot support to libvirt\n\n * Falls back to hard reboot if guest doesn\u0027t respond\n * Cleans up reboot/rescue/unrescue interaction\n * Fixed fake for tests\n * Added a force hard reboot test to verify fallback works\n * Fixes bug 939557\n\nChange-Id: I8d0c9a35725de5e5bfb8f13a2d869c6122ba44ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2efb017a06afeb10b474245455310ec21601a701"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2efb017a06afeb10b474245455310ec21601a701"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"34d50ed65fc6f68fa5efb524ab4d82eea8e499f0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}