)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c2661405b2704758dc37881fbb6f8c1f545884c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datapath type information to OVS vif objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new parameter to vif objects moleding OVS"},{"line_number":10,"context_line":"port profiles:"},{"line_number":11,"context_line":"  - VIFPortProfileOpenVSwitch"},{"line_number":12,"context_line":"  - VIFPortProfileFPOpenVSwitch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_26364d05","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":45},"updated":"2017-07-13 15:23:21.000000000","message":"for modelling the following","commit_id":"7be30db6db0c243343abca5bc3f14746241238fc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80897b5e86a10f728baae8ca9e7eb8049182777d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datapath type information to OVS vif objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new parameter to vif objects moleding OVS"},{"line_number":10,"context_line":"port profiles:"},{"line_number":11,"context_line":"  - VIFPortProfileOpenVSwitch"},{"line_number":12,"context_line":"  - VIFPortProfileFPOpenVSwitch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_21d87751","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":45},"in_reply_to":"1f1a1f67_26364d05","updated":"2017-07-13 15:31:40.000000000","message":"Too many gerunds! :)","commit_id":"7be30db6db0c243343abca5bc3f14746241238fc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c2661405b2704758dc37881fbb6f8c1f545884c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datapath type information to OVS vif objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new parameter to vif objects moleding OVS"},{"line_number":10,"context_line":"port profiles:"},{"line_number":11,"context_line":"  - VIFPortProfileOpenVSwitch"},{"line_number":12,"context_line":"  - VIFPortProfileFPOpenVSwitch"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This new parameter named \"datapath_type\" is a string"},{"line_number":15,"context_line":"coerced variable. The posible values stored in this"},{"line_number":16,"context_line":"field are defined in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_c62439c9","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":25},"updated":"2017-07-13 15:23:21.000000000","message":"Why do we need this? Can you provide a little more context","commit_id":"7be30db6db0c243343abca5bc3f14746241238fc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80897b5e86a10f728baae8ca9e7eb8049182777d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datapath type information to OVS vif objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new parameter to vif objects moleding OVS"},{"line_number":10,"context_line":"port profiles:"},{"line_number":11,"context_line":"  - VIFPortProfileOpenVSwitch"},{"line_number":12,"context_line":"  - VIFPortProfileFPOpenVSwitch"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This new parameter named \"datapath_type\" is a string"},{"line_number":15,"context_line":"coerced variable. The posible values stored in this"},{"line_number":16,"context_line":"field are defined in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f1a1f67_c1e66317","line":16,"range":{"start_line":9,"start_character":0,"end_line":16,"end_character":25},"in_reply_to":"1f1a1f67_c62439c9","updated":"2017-07-13 15:31:40.000000000","message":"I\u0027ll add a short description of the bug.","commit_id":"7be30db6db0c243343abca5bc3f14746241238fc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a8f77cf799cfbd3023abb3b1a484b1552f71f1c5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"field are defined in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This information is required by ``os-vif`` to define or ensure"},{"line_number":19,"context_line":"correctly the datapath type of the OVS bridge when plugin a"},{"line_number":20,"context_line":"port to this bridge. Currently the datapath type is hardcoded"},{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with other than kernel OVS"},{"line_number":22,"context_line":"versions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_0c45b315","line":19,"range":{"start_line":19,"start_character":51,"end_line":19,"end_character":57},"updated":"2017-09-04 14:35:32.000000000","message":"plugging","commit_id":"442ebad55da2f70434700b4f8be2d4e6a555b044"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"840220b67b8d041a10ec71c79d2eb175256b81cb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"field are defined in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This information is required by ``os-vif`` to define or ensure"},{"line_number":19,"context_line":"correctly the datapath type of the OVS bridge when plugin a"},{"line_number":20,"context_line":"port to this bridge. Currently the datapath type is hardcoded"},{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with other than kernel OVS"},{"line_number":22,"context_line":"versions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_172ed3a4","line":19,"range":{"start_line":19,"start_character":51,"end_line":19,"end_character":57},"in_reply_to":"7f287b81_0c45b315","updated":"2017-09-05 07:52:21.000000000","message":"Done","commit_id":"442ebad55da2f70434700b4f8be2d4e6a555b044"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a8f77cf799cfbd3023abb3b1a484b1552f71f1c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This information is required by ``os-vif`` to define or ensure"},{"line_number":19,"context_line":"correctly the datapath type of the OVS bridge when plugin a"},{"line_number":20,"context_line":"port to this bridge. Currently the datapath type is hardcoded"},{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with other than kernel OVS"},{"line_number":22,"context_line":"versions."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_8c62c3ac","line":21,"range":{"start_line":21,"start_character":31,"end_line":21,"end_character":53},"updated":"2017-09-04 14:35:32.000000000","message":"with anything other than the kernel...?","commit_id":"442ebad55da2f70434700b4f8be2d4e6a555b044"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"840220b67b8d041a10ec71c79d2eb175256b81cb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This information is required by ``os-vif`` to define or ensure"},{"line_number":19,"context_line":"correctly the datapath type of the OVS bridge when plugin a"},{"line_number":20,"context_line":"port to this bridge. Currently the datapath type is hardcoded"},{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with other than kernel OVS"},{"line_number":22,"context_line":"versions."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_d7196b88","line":21,"range":{"start_line":21,"start_character":31,"end_line":21,"end_character":53},"in_reply_to":"7f287b81_8c62c3ac","updated":"2017-09-05 07:52:21.000000000","message":"Done","commit_id":"442ebad55da2f70434700b4f8be2d4e6a555b044"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45c3e74a5df7b2b6ef3787e02871190825ba9d31","unresolved":false,"context_lines":[{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with anything other than the kernel"},{"line_number":22,"context_line":"OVS versions."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Depends-On: Ia813c39e2917ff373f8e1f85c75fc22d109c94d3"},{"line_number":27,"context_line":"Related-Bug: #1632372"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f515b1d_ef5f180c","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":123},"updated":"2017-09-22 14:47:24.000000000","message":"This appears to be out of date. Could you point to a tag?\n\n  https://github.com/openstack/neutron/blob/11.0.0/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L129","commit_id":"63cd15de5d8f3dfcf69f223fb9bf5acd8dc2034a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c45724d4959b8f38672cc34eeba7e2b96aea2f58","unresolved":false,"context_lines":[{"line_number":21,"context_line":"in ``os-vif`` and doesn\u0027t work with anything other than the kernel"},{"line_number":22,"context_line":"OVS versions."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L126"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Depends-On: Ia813c39e2917ff373f8e1f85c75fc22d109c94d3"},{"line_number":27,"context_line":"Related-Bug: #1632372"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f515b1d_8f59c4ff","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":123},"in_reply_to":"7f515b1d_ef5f180c","updated":"2017-09-22 14:49:35.000000000","message":"You are right!","commit_id":"63cd15de5d8f3dfcf69f223fb9bf5acd8dc2034a"}],"nova/network/model.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cbc95b469bf4851b71d2d4150005b2a5f455f419","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Open vSwitch datapath types."},{"line_number":94,"context_line":"VIF_DETAILS_OVS_DATAPATH_SYSTEM \u003d \u0027system\u0027"},{"line_number":95,"context_line":"VIF_DETAILS_OVS_DATAPATH_NETDEV \u003d \u0027netdev\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Define supported virtual NIC types. VNIC_TYPE_DIRECT and VNIC_TYPE_MACVTAP"},{"line_number":98,"context_line":"# are used for SR-IOV ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_14accb8a","line":95,"updated":"2017-09-22 14:32:15.000000000","message":"thanks :)","commit_id":"63cd15de5d8f3dfcf69f223fb9bf5acd8dc2034a"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7721009aefed41ba1af76739cc737bc4a058e7ec","unresolved":false,"context_lines":[{"line_number":280,"context_line":"def _nova_to_osvif_vif_ovs(vif):"},{"line_number":281,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":282,"context_line":"    profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":283,"context_line":"        interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":284,"context_line":"        datapath_type \u003d vif[\u0027details\u0027].get("},{"line_number":285,"context_line":"            model.VIF_DETAILS_OVS_DATAPATH_TYPE))"},{"line_number":286,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f5c4f37_3bc8d853","line":283,"updated":"2017-09-21 15:25:55.000000000","message":"Note for reviewers: the above is correct. It might seem that the code above would be better done like this:\n\n interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027, vif[\u0027id\u0027])\n\nhowever if we did that we could get an IndexError because vif[\u0027id\u0027] would always execute and we only want vif[\u0027id\u0027] lookup to execute when ovs_interfaceid key is not in vif.","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fb11f2135ba0ff13fb055d34e94866519cb16be7","unresolved":false,"context_lines":[{"line_number":280,"context_line":"def _nova_to_osvif_vif_ovs(vif):"},{"line_number":281,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":282,"context_line":"    profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":283,"context_line":"        interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":284,"context_line":"        datapath_type \u003d vif[\u0027details\u0027].get("},{"line_number":285,"context_line":"            model.VIF_DETAILS_OVS_DATAPATH_TYPE))"},{"line_number":286,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_3a6c5b35","line":283,"in_reply_to":"9f5c4f37_3bc8d853","updated":"2017-09-22 08:41:05.000000000","message":"Thanks for the comment!","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7721009aefed41ba1af76739cc737bc4a058e7ec","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":282,"context_line":"    profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":283,"context_line":"        interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":284,"context_line":"        datapath_type \u003d vif[\u0027details\u0027].get("},{"line_number":285,"context_line":"            model.VIF_DETAILS_OVS_DATAPATH_TYPE))"},{"line_number":286,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT:"},{"line_number":287,"context_line":"        profile \u003d objects.vif.VIFPortProfileOVSRepresentor("}],"source_content_type":"text/x-python","patch_set":9,"id":"9f5c4f37_1bdab416","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":24},"updated":"2017-09-21 15:25:55.000000000","message":"please remove spaces around kwarg key and value.","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fb11f2135ba0ff13fb055d34e94866519cb16be7","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":282,"context_line":"    profile \u003d objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":283,"context_line":"        interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":284,"context_line":"        datapath_type \u003d vif[\u0027details\u0027].get("},{"line_number":285,"context_line":"            model.VIF_DETAILS_OVS_DATAPATH_TYPE))"},{"line_number":286,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_DIRECT:"},{"line_number":287,"context_line":"        profile \u003d objects.vif.VIFPortProfileOVSRepresentor("}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_1a3bdf38","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":24},"in_reply_to":"9f5c4f37_1bdab416","updated":"2017-09-22 08:41:05.000000000","message":"Done","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"}],"nova/tests/unit/network/test_os_vif_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b7cc2218b93f3c883692f25395c78f9cdb5b53b","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                subnets\u003d[]),"},{"line_number":487,"context_line":"            details\u003d{"},{"line_number":488,"context_line":"                model.VIF_DETAILS_PORT_FILTER: True,"},{"line_number":489,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":490,"context_line":"            },"},{"line_number":491,"context_line":"        )"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_680b4e29","line":489,"range":{"start_line":489,"start_character":54,"end_line":489,"end_character":60},"updated":"2017-06-17 20:49:39.000000000","message":"for VIF_TYPE_OVS the datapath will normally be system except on bsd.","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"417e3bf91c05ecd85a84662ee594b8d6e213384b","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                subnets\u003d[]),"},{"line_number":487,"context_line":"            details\u003d{"},{"line_number":488,"context_line":"                model.VIF_DETAILS_PORT_FILTER: True,"},{"line_number":489,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":490,"context_line":"            },"},{"line_number":491,"context_line":"        )"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_737c2c72","line":489,"range":{"start_line":489,"start_character":54,"end_line":489,"end_character":60},"in_reply_to":"7f231b9d_680b4e29","updated":"2017-06-20 08:47:14.000000000","message":"Done","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b7cc2218b93f3c883692f25395c78f9cdb5b53b","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            plugin\u003d\"ovs\","},{"line_number":501,"context_line":"            port_profile\u003dosv_objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":502,"context_line":"                interface_id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":503,"context_line":"                datapath_type\u003d\u0027netdev\u0027),"},{"line_number":504,"context_line":"            preserve_on_delete\u003dFalse,"},{"line_number":505,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":506,"context_line":"            network\u003dosv_objects.network.Network("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_48065222","line":503,"range":{"start_line":503,"start_character":31,"end_line":503,"end_character":37},"updated":"2017-06-17 20:49:39.000000000","message":"system","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"417e3bf91c05ecd85a84662ee594b8d6e213384b","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            plugin\u003d\"ovs\","},{"line_number":501,"context_line":"            port_profile\u003dosv_objects.vif.VIFPortProfileOpenVSwitch("},{"line_number":502,"context_line":"                interface_id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":503,"context_line":"                datapath_type\u003d\u0027netdev\u0027),"},{"line_number":504,"context_line":"            preserve_on_delete\u003dFalse,"},{"line_number":505,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":506,"context_line":"            network\u003dosv_objects.network.Network("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_5381304a","line":503,"range":{"start_line":503,"start_character":31,"end_line":503,"end_character":37},"in_reply_to":"7f231b9d_48065222","updated":"2017-06-20 08:47:14.000000000","message":"Done","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b7cc2218b93f3c883692f25395c78f9cdb5b53b","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                subnets\u003d[]),"},{"line_number":525,"context_line":"            details\u003d{"},{"line_number":526,"context_line":"                model.VIF_DETAILS_PORT_FILTER: False,"},{"line_number":527,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":528,"context_line":"            },"},{"line_number":529,"context_line":"        )"},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_2801d606","line":527,"range":{"start_line":527,"start_character":54,"end_line":527,"end_character":60},"updated":"2017-06-17 20:49:39.000000000","message":"system","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"417e3bf91c05ecd85a84662ee594b8d6e213384b","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                subnets\u003d[]),"},{"line_number":525,"context_line":"            details\u003d{"},{"line_number":526,"context_line":"                model.VIF_DETAILS_PORT_FILTER: False,"},{"line_number":527,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":528,"context_line":"            },"},{"line_number":529,"context_line":"        )"},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_1393b8a5","line":527,"range":{"start_line":527,"start_character":54,"end_line":527,"end_character":60},"in_reply_to":"7f231b9d_2801d606","updated":"2017-06-20 08:47:14.000000000","message":"Done","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b7cc2218b93f3c883692f25395c78f9cdb5b53b","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                model.VIF_DETAILS_VHOSTUSER_OVS_PLUG: True,"},{"line_number":649,"context_line":"                model.VIF_DETAILS_OVS_HYBRID_PLUG: True,"},{"line_number":650,"context_line":"                model.VIF_DETAILS_PORT_FILTER: False,"},{"line_number":651,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":652,"context_line":"            },"},{"line_number":653,"context_line":"        )"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_9207f818","line":651,"range":{"start_line":651,"start_character":54,"end_line":651,"end_character":60},"updated":"2017-06-17 20:49:39.000000000","message":"i think for the fast path stack this would be system.\n\nit does not really matter because we are not actully using there ml2 dirver but ya i think this should be system","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"417e3bf91c05ecd85a84662ee594b8d6e213384b","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                model.VIF_DETAILS_VHOSTUSER_OVS_PLUG: True,"},{"line_number":649,"context_line":"                model.VIF_DETAILS_OVS_HYBRID_PLUG: True,"},{"line_number":650,"context_line":"                model.VIF_DETAILS_PORT_FILTER: False,"},{"line_number":651,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027netdev\u0027"},{"line_number":652,"context_line":"            },"},{"line_number":653,"context_line":"        )"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_f38f1c73","line":651,"range":{"start_line":651,"start_character":54,"end_line":651,"end_character":60},"in_reply_to":"7f231b9d_9207f818","updated":"2017-06-20 08:47:14.000000000","message":"Done","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b7cc2218b93f3c883692f25395c78f9cdb5b53b","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                interface_id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":664,"context_line":"                bridge_name\u003d\"qbrdc065497-3c\","},{"line_number":665,"context_line":"                hybrid_plug\u003dTrue,"},{"line_number":666,"context_line":"                datapath_type\u003d\u0027netdev\u0027),"},{"line_number":667,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":668,"context_line":"            path\u003d\u0027/fake/socket\u0027,"},{"line_number":669,"context_line":"            mode\u003d\u0027client\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_720a1c20","line":666,"range":{"start_line":666,"start_character":31,"end_line":666,"end_character":37},"updated":"2017-06-17 20:49:39.000000000","message":"system","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"417e3bf91c05ecd85a84662ee594b8d6e213384b","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                interface_id\u003d\"dc065497-3c8d-4f44-8fb4-e1d33c16a536\","},{"line_number":664,"context_line":"                bridge_name\u003d\"qbrdc065497-3c\","},{"line_number":665,"context_line":"                hybrid_plug\u003dTrue,"},{"line_number":666,"context_line":"                datapath_type\u003d\u0027netdev\u0027),"},{"line_number":667,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":668,"context_line":"            path\u003d\u0027/fake/socket\u0027,"},{"line_number":669,"context_line":"            mode\u003d\u0027client\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_d38c2081","line":666,"range":{"start_line":666,"start_character":31,"end_line":666,"end_character":37},"in_reply_to":"7f231b9d_720a1c20","updated":"2017-06-20 08:47:14.000000000","message":"Done","commit_id":"3a45bc75fefdefb5f45e6b4a2344ec85e2f9fb91"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7721009aefed41ba1af76739cc737bc4a058e7ec","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                subnets\u003d[]),"},{"line_number":608,"context_line":"            details\u003d{"},{"line_number":609,"context_line":"                model.VIF_DETAILS_PORT_FILTER: True,"},{"line_number":610,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027system\u0027"},{"line_number":611,"context_line":"            },"},{"line_number":612,"context_line":"        )"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9f5c4f37_db13fcb7","line":610,"range":{"start_line":610,"start_character":53,"end_line":610,"end_character":61},"updated":"2017-09-21 15:25:55.000000000","message":"Consider putting \"system\" and \"netdev\" into constant symbols.","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fb11f2135ba0ff13fb055d34e94866519cb16be7","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                subnets\u003d[]),"},{"line_number":608,"context_line":"            details\u003d{"},{"line_number":609,"context_line":"                model.VIF_DETAILS_PORT_FILTER: True,"},{"line_number":610,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE: \u0027system\u0027"},{"line_number":611,"context_line":"            },"},{"line_number":612,"context_line":"        )"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_7a5bf386","line":610,"range":{"start_line":610,"start_character":53,"end_line":610,"end_character":61},"in_reply_to":"9f5c4f37_db13fcb7","updated":"2017-09-22 08:41:05.000000000","message":"Done","commit_id":"fe3e879047aaba7d8202590e34d58772b2f793f6"}]}