)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"ba2f4bda5ed8d0eeb39a355de2cabeb734d7f0b9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                        \"adapter_type\": adapter_type,"},{"line_number":266,"context_line":"                        \"data_store_name\": data_store_name},"},{"line_number":267,"context_line":"                      instance\u003dinstance)"},{"line_number":268,"context_line":"            vmdk_create_spec \u003d self.get_copy_virtual_disk_spec(client_factory,"},{"line_number":269,"context_line":"                                    adapter_type,"},{"line_number":270,"context_line":"                                    disk_type)"},{"line_number":271,"context_line":"            vmdk_create_task \u003d self._session._call_method("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2Ffz0%3D","line":268,"updated":"2013-09-25 17:53:21.000000000","message":"You should not use a copy spec for disk creation. Probably related to why some tests are tripping","commit_id":"a6733bdd380a822a76e8143ba92a8cf4c05b23ec"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"13991c20cf6f57e534b68214b5f3363ee49d60ec","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                if root_gb_in_kb \u003e vmdk_file_size_in_kb:"},{"line_number":460,"context_line":"                    self._extend_virtual_disk(instance, root_gb_in_kb,"},{"line_number":461,"context_line":"                                              root_vmdk_path, dc_ref)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"                # If we are not using linked_clone, copy the image from"},{"line_number":464,"context_line":"                # the cache into the instance directory.  If we are using"},{"line_number":465,"context_line":"                # linked clone it is references from the cache directory"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2Fbng%3D","line":462,"updated":"2013-09-26 18:54:09.000000000","message":"This should be done before L458. Else extend disk will operate on the base image and will leave the root disk unchanged.","commit_id":"03408b1f9c19c7d75badb566643364ffb5238148"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"72cb7db3fed2e3d82ecac432a5cbb2dc3403656e","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                _copy_virtual_disk(uploaded_vmdk_path, dest_vmdk_path)"},{"line_number":468,"context_line":"                uploaded_vmdk_path \u003d dest_vmdk_path"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"                root_vmdk_path \u003d uploaded_vmdk_path"},{"line_number":471,"context_line":"                if root_gb_in_kb \u003e vmdk_file_size_in_kb:"},{"line_number":472,"context_line":"                    self._extend_virtual_disk(instance, root_gb_in_kb,"},{"line_number":473,"context_line":"                                              root_vmdk_path, dc_ref)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAS3%2F%2FaUU%3D","line":470,"updated":"2013-09-27 08:11:47.000000000","message":"I think that this should be:\nroot_vmdk_path \u003d dest_vmdk_path\n\nThat is, if I undestand correctly we load and image to the cache. This image is then copied from the cache to the detination directory. The image copied to the destination directory needs to be extended and not the original (that will cause a problem if someone is loading the same image with a different root disk size).","commit_id":"0037374f908034043a820368e0bc1dd3ae98eed6"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"4e1c9f99bb5d047e2b6088392e0de02c9c34846e","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                _copy_virtual_disk(uploaded_vmdk_path, dest_vmdk_path)"},{"line_number":468,"context_line":"                uploaded_vmdk_path \u003d dest_vmdk_path"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"                root_vmdk_path \u003d uploaded_vmdk_path"},{"line_number":471,"context_line":"                if root_gb_in_kb \u003e vmdk_file_size_in_kb:"},{"line_number":472,"context_line":"                    self._extend_virtual_disk(instance, root_gb_in_kb,"},{"line_number":473,"context_line":"                                              root_vmdk_path, dc_ref)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAS3%2F%2FZKE%3D","line":470,"in_reply_to":"AAAAS3%2F%2FaTs%3D","updated":"2013-09-27 15:58:13.000000000","message":"Since i had already set uploaded_vmdk_path to dest_vmdk_path it worked, but i removed that for clarity in this next patch","commit_id":"0037374f908034043a820368e0bc1dd3ae98eed6"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"80fef63e68a80d894daecdf80af4f74a8623b74e","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                _copy_virtual_disk(uploaded_vmdk_path, dest_vmdk_path)"},{"line_number":468,"context_line":"                uploaded_vmdk_path \u003d dest_vmdk_path"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"                root_vmdk_path \u003d uploaded_vmdk_path"},{"line_number":471,"context_line":"                if root_gb_in_kb \u003e vmdk_file_size_in_kb:"},{"line_number":472,"context_line":"                    self._extend_virtual_disk(instance, root_gb_in_kb,"},{"line_number":473,"context_line":"                                              root_vmdk_path, dc_ref)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAS3%2F%2FaTs%3D","line":470,"in_reply_to":"AAAAS3%2F%2FaUU%3D","updated":"2013-09-27 08:16:54.000000000","message":"Tracy\u0027s previous patchset had that issue. Here I think it\u0027s fine.  In the previous line L468, she replaces uploaded_vmdk_path \u003d dest_vmdk_path. In my opinion, she can get away with L470 and use root_vmdk_path \u003d dest_vmdk_path","commit_id":"0037374f908034043a820368e0bc1dd3ae98eed6"}]}
