)]}'
{"doc/notification_samples/instance-update.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b5b528cde1f03e856df1c1373c168e09c383080e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"tags\": [],"},{"line_number":73,"context_line":"            \"user_id\": \"fake\","},{"line_number":74,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":75,"context_line":"            \"updated_at\": null"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":78,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":13,"id":"3f1d235d_bb3a72ca","line":75,"updated":"2017-07-10 18:56:20.000000000","message":"Isn\u0027t it odd that the updated_at field is null in the instance.update notification?","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c784f6f3531e1b48bd37677b85181b2beff495cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"tags\": [],"},{"line_number":73,"context_line":"            \"user_id\": \"fake\","},{"line_number":74,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":75,"context_line":"            \"updated_at\": null"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":78,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":13,"id":"1f1a1f67_babc3c06","line":75,"in_reply_to":"1f1a1f67_a470a709","updated":"2017-07-18 05:53:29.000000000","message":"@Matt:This sample is used in test_create_delete_server_with_instance_update() test where the the first two instance.update notifications are sent without updated_at field set then when the instance gets scheduled (e.g. the host and node fields are set) the updated_at field is also set in the notification. See https://review.openstack.org/#/c/475276/13/nova/tests/functional/notification_sample_tests/test_instance.py@263\n\nThis behavior looks strange but I think it is not caused by this patch. I filed a bug report to fix this behavior separately https://bugs.launchpad.net/nova/+bug/1704928","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"068ebac51ce5ddfbcb1e9628e8be0575edaf8b61","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"tags\": [],"},{"line_number":73,"context_line":"            \"user_id\": \"fake\","},{"line_number":74,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":75,"context_line":"            \"updated_at\": null"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":78,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":13,"id":"1f1a1f67_4002c40b","line":75,"in_reply_to":"1f1a1f67_babc3c06","updated":"2017-07-18 17:14:53.000000000","message":"The updated_at field should be set via the TimestampMixin in oslo.db any time there is an update to the record in the DB, so I don\u0027t really understand why instance.updated_at wouldn\u0027t be set.","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"50519b08221404f399def627a9d6bf136621b314","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"tags\": [],"},{"line_number":73,"context_line":"            \"user_id\": \"fake\","},{"line_number":74,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":75,"context_line":"            \"updated_at\": null"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":78,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":13,"id":"1f1a1f67_a470a709","line":75,"in_reply_to":"3f1d235d_1b0966dc","updated":"2017-07-18 03:56:12.000000000","message":"The \u0027updated_at\u0027 field is set to \u0027updated_at\u0027 of instance object when payload initialization.\n\nhttps://github.com/openstack/nova/blob/247f9b8120fb901ec420a59a500db0db9dad445a/nova/notifications/base.py#L284-#L289","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"589d26ef7f3f2b98300eb97baec45abcc8be04b0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"tags\": [],"},{"line_number":73,"context_line":"            \"user_id\": \"fake\","},{"line_number":74,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":75,"context_line":"            \"updated_at\": null"},{"line_number":76,"context_line":"        },"},{"line_number":77,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":78,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":13,"id":"3f1d235d_1b0966dc","line":75,"in_reply_to":"3f1d235d_bb3a72ca","updated":"2017-07-10 19:05:50.000000000","message":"I figured this out. We send build the payload for the instance.update notification here:\n\nhttps://github.com/openstack/nova/blob/dcea3ff68793a28cd546805ebcb2c0ae6c9b684d/nova/notifications/base.py#L228\n\nAnd for whatever reason, that doesn\u0027t include the updated_at field:\n\nhttps://github.com/openstack/nova/blob/dcea3ff68793a28cd546805ebcb2c0ae6c9b684d/nova/notifications/base.py#L456-L463\n\nWe can\u0027t just add it to info_from_instance since that would change legacy notifications. But maybe we can add the updated_at field to the versioned payload here?\n\nhttps://github.com/openstack/nova/blob/dcea3ff68793a28cd546805ebcb2c0ae6c9b684d/nova/notifications/base.py#L266","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19109ba69a4054c4cbbc3d27e14a11eeb439942b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \"tags\": [],"},{"line_number":74,"context_line":"            \"user_id\": \"fake\","},{"line_number":75,"context_line":"            \"uuid\": \"c03c0bf9-f46e-4e4f-93f1-817568567ee2\","},{"line_number":76,"context_line":"            \"updated_at\": null"},{"line_number":77,"context_line":"        },"},{"line_number":78,"context_line":"        \"nova_object.name\": \"InstanceUpdatePayload\","},{"line_number":79,"context_line":"        \"nova_object.namespace\": \"nova\","}],"source_content_type":"application/json","patch_set":15,"id":"ff346bd7_7daa6071","line":76,"updated":"2017-07-26 18:21:59.000000000","message":"As noted before this is a known bug based on how instance_update_and_get_original works in our DB API.","commit_id":"bf17be9e8ffc393a3af1dbd88b0c0623658b0979"}],"releasenotes/notes/bug-1684860-6e226dc03bfa696a.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b5b528cde1f03e856df1c1373c168e09c383080e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added ``updated_at`` field in the instance notifications (instance.*)."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f1d235d_3b754299","line":2,"updated":"2017-07-10 18:56:20.000000000","message":"Do we really need an upgrade release note for this? We don\u0027t have upgrade release notes for all of the versioned notifications, not even the one that adds BDMs:\n\nhttps://review.openstack.org/#/c/448779/\n\nThis is fixing a bug because of a gap in the notification, so if anything it could go under the \u0027fixes\u0027 section. But if it were me I\u0027d just omit a release note for this.","commit_id":"6d90106c4a8e5d78bf886498d446e7bf65decf12"}]}