)]}'
{"doc/ext/versioned_notifications.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cac5afff7fe7ce233f9452c74d92e02f12c34b7c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from docutils import nodes"},{"line_number":24,"context_line":"import importlib"},{"line_number":25,"context_line":"from sphinx.util.compat import Directive"},{"line_number":26,"context_line":"import pkgutil"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_0bf19f95","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"updated":"2017-06-27 05:57:41.000000000","message":"nit: It does not follow the import order guideline.\n\nhttps://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"5a35a2b99e5ae81937a6a0cbf3d4274ff385a5e6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1de060c99755076c2ac2bae31633e7498a3c7c78","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from docutils import nodes"},{"line_number":24,"context_line":"import importlib"},{"line_number":25,"context_line":"from sphinx.util.compat import Directive"},{"line_number":26,"context_line":"import pkgutil"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_c775f365","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"in_reply_to":"3f1d235d_2cf7ee61","updated":"2017-07-05 08:38:03.000000000","message":"You are right. Unfortunately pep8 doesn\u0027t run on these files so it is hard to see when the order is broken. I will try to extend tox pep8 target to include this as well and then fix the violations.","commit_id":"5a35a2b99e5ae81937a6a0cbf3d4274ff385a5e6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3aebf17b4bea571dfc6dc2e785e7853b77b9b0c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from docutils import nodes"},{"line_number":24,"context_line":"import importlib"},{"line_number":25,"context_line":"from sphinx.util.compat import Directive"},{"line_number":26,"context_line":"import pkgutil"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_68a70fbf","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"in_reply_to":"3f1d235d_c775f365","updated":"2017-07-05 09:26:46.000000000","message":"Follow up is proposed here: https://review.openstack.org/#/c/480469/","commit_id":"5a35a2b99e5ae81937a6a0cbf3d4274ff385a5e6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3b982bb90ce601f1760f8290bb9db5c09ccf59a4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from docutils import nodes"},{"line_number":24,"context_line":"import importlib"},{"line_number":25,"context_line":"from sphinx.util.compat import Directive"},{"line_number":26,"context_line":"import pkgutil"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_2cf7ee61","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":16},"in_reply_to":"5f201791_0bf19f95","updated":"2017-07-05 08:27:37.000000000","message":"Well, you\u0027re right, those are part of the stdlib but I think we can change that in a follow-up change.","commit_id":"5a35a2b99e5ae81937a6a0cbf3d4274ff385a5e6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cac5afff7fe7ce233f9452c74d92e02f12c34b7c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from docutils import nodes"},{"line_number":24,"context_line":"import importlib"},{"line_number":25,"context_line":"from sphinx.util.compat import Directive"},{"line_number":26,"context_line":"import pkgutil"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import nova.notifications.objects"},{"line_number":29,"context_line":"from nova.notifications.objects import base as notification"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_8b324f5d","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"updated":"2017-06-27 05:57:41.000000000","message":"ditto","commit_id":"5a35a2b99e5ae81937a6a0cbf3d4274ff385a5e6"}]}