)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8e82f8a79e24aa1269d68e900749e238d02d485d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # raise a NoValidHosts."},{"line_number":175,"context_line":"        if not alloc_reqs:"},{"line_number":176,"context_line":"            return []"},{"line_number":177,"context_line":"        compute_uuids \u003d list(p_sums.keys())"},{"line_number":178,"context_line":"        return self.host_manager.get_host_states_by_uuids(context,"},{"line_number":179,"context_line":"                                                          compute_uuids,"},{"line_number":180,"context_line":"                                                          spec_obj)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_7a2518ab","line":177,"updated":"2017-06-20 13:11:09.000000000","message":"Those aren\u0027t all compute uuids, are they? Won\u0027t shared/nested provider uuids be included here, too? Or don\u0027t you care because they simply won\u0027t match anything in ComputeNodeList._db_compute_node_get_all_by_uuids()?","commit_id":"069add1a9ff517ccb44fee825b26c6c2566061c3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e391d89f78818ddf5df2b7186f745f47822dfdef","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # raise a NoValidHosts."},{"line_number":175,"context_line":"        if not alloc_reqs:"},{"line_number":176,"context_line":"            return []"},{"line_number":177,"context_line":"        compute_uuids \u003d list(p_sums.keys())"},{"line_number":178,"context_line":"        return self.host_manager.get_host_states_by_uuids(context,"},{"line_number":179,"context_line":"                                                          compute_uuids,"},{"line_number":180,"context_line":"                                                          spec_obj)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_4f563109","line":177,"in_reply_to":"5f201791_38834507","updated":"2017-06-20 15:37:36.000000000","message":"OK, thanks. Then I would suggest changing the name from \u0027compute_uuids\u0027 to \u0027provider_uuids\u0027, and adding a note explaining why it doesn\u0027t matter.","commit_id":"069add1a9ff517ccb44fee825b26c6c2566061c3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d01616568a744c4f0cf61c5d90b69a28a0feb51c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # raise a NoValidHosts."},{"line_number":175,"context_line":"        if not alloc_reqs:"},{"line_number":176,"context_line":"            return []"},{"line_number":177,"context_line":"        compute_uuids \u003d list(p_sums.keys())"},{"line_number":178,"context_line":"        return self.host_manager.get_host_states_by_uuids(context,"},{"line_number":179,"context_line":"                                                          compute_uuids,"},{"line_number":180,"context_line":"                                                          spec_obj)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_2fa3f551","line":177,"in_reply_to":"5f201791_4f563109","updated":"2017-06-20 15:54:24.000000000","message":"Done","commit_id":"069add1a9ff517ccb44fee825b26c6c2566061c3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e49572435867343f5f840d3ca09f006ad73f5c1a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # raise a NoValidHosts."},{"line_number":175,"context_line":"        if not alloc_reqs:"},{"line_number":176,"context_line":"            return []"},{"line_number":177,"context_line":"        compute_uuids \u003d list(p_sums.keys())"},{"line_number":178,"context_line":"        return self.host_manager.get_host_states_by_uuids(context,"},{"line_number":179,"context_line":"                                                          compute_uuids,"},{"line_number":180,"context_line":"                                                          spec_obj)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_38834507","line":177,"in_reply_to":"7f231b9d_7a2518ab","updated":"2017-06-20 13:41:39.000000000","message":"Yes, shared (and eventually child) providers will be included here. And yep, don\u0027t care because the compute node get all by uuids doesn\u0027t care. :)","commit_id":"069add1a9ff517ccb44fee825b26c6c2566061c3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"14a50924938cc44a5662251f2eef82c5201ec7eb","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # raise a NoValidHosts."},{"line_number":175,"context_line":"        if not alloc_reqs:"},{"line_number":176,"context_line":"            return []"},{"line_number":177,"context_line":"        # NOTE(jaypipes): This list contains more than just compute node UUIDs."},{"line_number":178,"context_line":"        # It contains UUIDs of sharing providers and, in the future, child"},{"line_number":179,"context_line":"        # providers. However, the get_host_states_by_uuids() call passes this"},{"line_number":180,"context_line":"        # list of UUIDs to ComputeNodeList.get_all_by_uuids() which passes the"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_07ffd901","line":177,"range":{"start_line":177,"start_character":10,"end_line":177,"end_character":25},"updated":"2017-06-21 17:54:04.000000000","message":"Thanks for adding this.","commit_id":"b858e4555c4f85b87d4f30b8acb1d249fbf13d5f"}]}