)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"02bba3a3790ff273f438431b33d27f09ba84d29b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yuanyue \u003cyyuanyuee@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-21 03:49:22 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the bug on boot failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instance fails to spawn, nova would just shutdown"},{"line_number":10,"context_line":"the instance, during which volumes would be detached."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_36e204d7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":27},"updated":"2017-06-21 22:29:34.000000000","message":"This is vague. The first line of the commit message should be a brief (\u003c\u003d 50 characters) sentence summarizing the change. For example: \"Cleanup volumes on boot failure\"","commit_id":"164dfdb015f9e9fb8eb03b0959f5a0bab46c79a0"}],"nova/compute/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"02bba3a3790ff273f438431b33d27f09ba84d29b","unresolved":false,"context_lines":[{"line_number":1820,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":1821,"context_line":"                    requested_networks)"},{"line_number":1822,"context_line":"                self._cleanup_volumes(context, instance.uuid,"},{"line_number":1823,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":1824,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":1825,"context_line":"                        instance, e, sys.exc_info(),"},{"line_number":1826,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_7673dc16","line":1823,"updated":"2017-06-21 22:29:34.000000000","message":"We need to unit test this code. I think it could be done in nova/tests/unit/compute/test_compute_mgr.py in the test_rescheduled_exception_without_retry function. An assertion can be added to verify self._cleanup_volumes is called with the expected arguments.","commit_id":"164dfdb015f9e9fb8eb03b0959f5a0bab46c79a0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"02bba3a3790ff273f438431b33d27f09ba84d29b","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"},{"line_number":1827,"context_line":"                self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1828,"context_line":"                self._set_instance_obj_error_state(context, instance,"},{"line_number":1829,"context_line":"                                                   clean_task_state\u003dTrue)"},{"line_number":1830,"context_line":"                return build_results.FAILED"},{"line_number":1831,"context_line":"            LOG.debug(e.format_message(), instance\u003dinstance)"},{"line_number":1832,"context_line":"            # This will be used for logging the exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_b6d734c0","line":1829,"updated":"2017-06-21 22:29:34.000000000","message":"Note: This sequence of cleanup calls (cleanup networks, volumes, add instance fault, nil out instance host and node and set instance error state) are used repetitively in this file. In a future patch, we should probably refactor them into a helper method and call that instead to prevent the different call sites going out-of-sync.","commit_id":"164dfdb015f9e9fb8eb03b0959f5a0bab46c79a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da601ff2ba9cdc8994d9e7c698758fefd03005a3","unresolved":false,"context_lines":[{"line_number":1819,"context_line":"                    instance\u003dinstance)"},{"line_number":1820,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":1821,"context_line":"                    requested_networks)"},{"line_number":1822,"context_line":"                self._cleanup_volumes(context, instance.uuid,"},{"line_number":1823,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":1824,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":1825,"context_line":"                        instance, e, sys.exc_info(),"},{"line_number":1826,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_df050ec4","line":1823,"range":{"start_line":1822,"start_character":0,"end_line":1823,"end_character":58},"updated":"2017-06-22 14:12:52.000000000","message":"Yup, stuff is being created as part of \u0027_build_resources\u0027, so we should be cleaning it up here","commit_id":"1a32bfd2ca1541af935b13b86728f124bba3d2c4"}]}