)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5320b23cdc37f75ad20a64a2f6b5d7a7ab9260f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maciej Kucia \u003cmaciej@kucia.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-14 16:06:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation to PCI whitelist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sanitize config input by providing schema. This change"},{"line_number":10,"context_line":"should make easier for developers to understand the format"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_3732c211","line":7,"in_reply_to":"","updated":"2017-07-14 23:57:39.000000000","message":"The white list strictly is not just a json dictionary. It is a multistropt filed that is aggregated. For examples lists of whitelist values are not supported with []\n\nIf you add suppor for lists that will fix kolla support for templateing this config option and make this less comber some to work with","commit_id":"1ff7772c87856c322ac2cffc58593143ea0869cc"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"4a6a7f32ba2f4b00d0025c8d8ea5d6396bb34b80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maciej Kucia \u003cmaciej@kucia.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-14 16:06:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation to PCI whitelist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sanitize config input by providing schema. This change"},{"line_number":10,"context_line":"should make easier for developers to understand the format"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_a970aedd","line":7,"in_reply_to":"1f1a1f67_3732c211","updated":"2017-07-15 21:13:46.000000000","message":"1. I guess the message could mention that indeed.\n2. Good idea, I might do it!","commit_id":"1ff7772c87856c322ac2cffc58593143ea0869cc"}],"nova/pci/whitelist.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5320b23cdc37f75ad20a64a2f6b5d7a7ab9260f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"devname\": {\"type\": \"string\"},"},{"line_number":48,"context_line":"        \"physical_network\": {\"type\": \"string\"},"},{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \"additionalProperties\": False,"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_da0cd33c","line":50,"updated":"2017-07-14 23:57:39.000000000","message":"I belive you are missing the alias field used for pci pass through","commit_id":"1ff7772c87856c322ac2cffc58593143ea0869cc"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"4a6a7f32ba2f4b00d0025c8d8ea5d6396bb34b80","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \"devname\": {\"type\": \"string\"},"},{"line_number":48,"context_line":"        \"physical_network\": {\"type\": \"string\"},"},{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    \"additionalProperties\": False,"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_29a7fe51","line":50,"in_reply_to":"1f1a1f67_da0cd33c","updated":"2017-07-15 21:13:46.000000000","message":"Alias is a separate config option. I have proposed a nova spec for PCI aliases per specific device (https://review.openstack.org/#/c/474218/). If implemented, this schema will need to be extended with `alias` field.","commit_id":"1ff7772c87856c322ac2cffc58593143ea0869cc"}]}