)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"plug_vif raise NotImplementedError instead of pass"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hyperv, vmware and powervm drivers raise NotImplementedError from"},{"line_number":10,"context_line":"the plug_vifs and unplug_vifs methods rather than pass."},{"line_number":11,"context_line":"The compute manager handles the NotImplementedError"},{"line_number":12,"context_line":"case when initializing the host."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"AAAAS3%2F%2FjZQ%3D","line":9,"updated":"2013-09-24 19:16:19.000000000","message":"Docker is in the list now too so I\u0027d add it to the commit message or remove the virt-specific names from the commit message and just make it generic, e.g. \"Some virt drivers raise NotImplementedError from plug_vifs...\".","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        net_info \u003d compute_utils.get_nw_info_for_instance(instance)"},{"line_number":666,"context_line":"        try:"},{"line_number":667,"context_line":"                self.driver.plug_vifs(instance, net_info)"},{"line_number":668,"context_line":"        except NotImplementedError:"},{"line_number":669,"context_line":"                LOG.warning(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":670,"context_line":"                              \u0027network injection\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqWM%3D","line":667,"updated":"2013-09-23 07:41:45.000000000","message":"the indentation here looks odd. it should be four spaces","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        try:"},{"line_number":667,"context_line":"            self.driver.plug_vifs(instance, net_info)"},{"line_number":668,"context_line":"        except NotImplementedError:"},{"line_number":669,"context_line":"            LOG.warning(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":670,"context_line":"                          \u0027network injection\u0027), instance\u003dinstance)"},{"line_number":671,"context_line":"            pass"},{"line_number":672,"context_line":"        if instance[\u0027task_state\u0027] \u003d\u003d task_states.RESIZE_MIGRATING:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjYg%3D","line":669,"updated":"2013-09-24 19:16:19.000000000","message":"Hmm, if you don\u0027t have the error in the log message it would probably be confusing for a user to all of a sudden see this warning without any context.  I\u0027d suggest adding the error message to the log for context and probably make this a debug level message rather than warning.  A warning is something I should care about.","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":4144,"context_line":"            try:"},{"line_number":4145,"context_line":"                self.driver.unplug_vifs(instance_ref, network_info)"},{"line_number":4146,"context_line":"            except NotImplementedError:"},{"line_number":4147,"context_line":"                LOG.warning(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":4148,"context_line":"                              \u0027network injection\u0027), instance\u003dinstance_ref)"},{"line_number":4149,"context_line":"                pass"},{"line_number":4150,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjYY%3D","line":4147,"updated":"2013-09-24 19:16:19.000000000","message":"Same comment here, there is no context.","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        except NotImplementedError as e:"},{"line_number":668,"context_line":"            LOG.debug(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":669,"context_line":"                        \u0027network injection: %s\u0027), e, instance\u003dinstance)"},{"line_number":670,"context_line":"            pass"},{"line_number":671,"context_line":"        if instance[\u0027task_state\u0027] \u003d\u003d task_states.RESIZE_MIGRATING:"},{"line_number":672,"context_line":"            # We crashed during resize/migration, so roll back for safety"},{"line_number":673,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2Fflo%3D","line":670,"updated":"2013-09-25 18:49:33.000000000","message":"I don\u0027t think the pass is needed here.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":4144,"context_line":"                self.driver.unplug_vifs(instance_ref, network_info)"},{"line_number":4145,"context_line":"            except NotImplementedError as e:"},{"line_number":4146,"context_line":"                LOG.debug(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":4147,"context_line":"                              \u0027network injection: %s\u0027),"},{"line_number":4148,"context_line":"                              e, instance\u003dinstance_ref)"},{"line_number":4149,"context_line":"                pass"},{"line_number":4150,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FflY%3D","line":4147,"updated":"2013-09-25 18:49:33.000000000","message":"Alignment is off.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":4146,"context_line":"                LOG.debug(_(\u0027Hypervisor driver does not support \u0027"},{"line_number":4147,"context_line":"                              \u0027network injection: %s\u0027),"},{"line_number":4148,"context_line":"                              e, instance\u003dinstance_ref)"},{"line_number":4149,"context_line":"                pass"},{"line_number":4150,"context_line":"        # NOTE(tr3buchet): tear down networks on source host"},{"line_number":4151,"context_line":"        self.network_api.setup_networks_on_host(ctxt, instance_ref,"},{"line_number":4152,"context_line":"                                                self.host, teardown\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FflU%3D","line":4149,"updated":"2013-09-25 18:49:33.000000000","message":"pass isn\u0027t needed since you\u0027re logging the error.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        self._test_snapshot()"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    def test_unplug_vifs(self):"},{"line_number":980,"context_line":"        # Check to make sure the method raises NotImplementedError."},{"line_number":981,"context_line":"        self._create_instance_in_the_db()"},{"line_number":982,"context_line":"        self.assertRaises(NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqWI%3D","line":979,"updated":"2013-09-23 07:41:45.000000000","message":"please add a test for plugging vifs","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"}],"nova/virt/docker/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":101,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":102,"context_line":"        msg \u003d _(\"network injection not supported by the docker driver\")"},{"line_number":103,"context_line":"        LOG.debug(msg, instance)"},{"line_number":104,"context_line":"        raise NotImplementedError(msg)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjX8%3D","line":102,"updated":"2013-09-24 19:16:19.000000000","message":"See comments in the powervm driver.","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff244deb3e3e6f93497eb9ff577e3741add8a96f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":106,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":107,"context_line":"        msg \u003d _(\"VIF plugging is not supported by the Docker driver.\")"},{"line_number":108,"context_line":"        raise NotImplementedError(msg)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def find_container_by_name(self, name):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAS3%2F%2Fb7I%3D","line":107,"updated":"2013-09-26 17:22:40.000000000","message":"Should probably be \u0027VIF unplugging...\u0027.","commit_id":"1147bfdc5adea4f5a22c4c116354417c752eb666"}],"nova/virt/hyperv/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        LOG.debug(_(\u0027Network injection is not supported by the \u0027"},{"line_number":156,"context_line":"                    \u0027Hyper-V driver.\u0027), instance)"},{"line_number":157,"context_line":"        msg \u003d _(\"network injection not supported by the hyper-v driver\")"},{"line_number":158,"context_line":"        raise NotImplementedError(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqV8%3D","line":155,"updated":"2013-09-23 07:41:45.000000000","message":"Consider:\nmsg \u003d _(\"network injection not supported by the hyper-v driver\")\nLOG.debug(msg)\nraise NotImplementedError(msg)","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        raise NotImplementedError(msg)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":161,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":162,"context_line":"        LOG.debug(_(\u0027Network injection is not supported by the \u0027"},{"line_number":163,"context_line":"                    \u0027Hyper-V driver.\u0027), instance)"},{"line_number":164,"context_line":"        msg \u003d _(\"network injection not supported by the hyper-v driver\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqV0%3D","line":161,"updated":"2013-09-23 07:41:45.000000000","message":"Same comment as above","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"network injection not supported by the hyper-v driver\")"},{"line_number":156,"context_line":"        LOG.debug(msg, instance)"},{"line_number":157,"context_line":"        raise NotImplementedError(msg)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjX0%3D","line":155,"updated":"2013-09-24 19:16:19.000000000","message":"See comments in the powervm driver.\n\nAlso, the hypervisor support matrix actually says the hyper-v driver supports network injection, so I\u0027m not sure if calling the plug_vifs method \u0027network injection\u0027 is accurate, or if the table in the wiki is wrong:\n\nhttps://wiki.openstack.org/wiki/HypervisorSupportMatrix","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"caa04444dc7ff5511f48065f992de9d544d4e573","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"network injection not supported by the hyper-v driver\")"},{"line_number":156,"context_line":"        LOG.debug(msg, instance)"},{"line_number":157,"context_line":"        raise NotImplementedError(msg)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FilU%3D","line":155,"in_reply_to":"AAAAS3%2F%2FjX0%3D","updated":"2013-09-25 00:12:17.000000000","message":"I\u0027d also go with adding the raise NotImplementedError() calls only.","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"0c2752d8ce29e2dad9ff36d3fbc5ae47b90706e0","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2Ffqw%3D","line":155,"updated":"2013-09-25 18:24:17.000000000","message":"As already pointed out by mriedem, I\u0027m not sure network injection is the correct term here. I\u0027d leave the previous message.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3208171701d7eece951bae39e191f422c0e9ac7c","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FfFE%3D","line":155,"in_reply_to":"AAAAS3%2F%2FfFY%3D","updated":"2013-09-25 21:46:39.000000000","message":"Ok, this make sense. I will update with \"VIF plugging is not supported by the XXX driver.\"\nThanks for your comments.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8738509de2ad97f0c5009b067c7d4eb3aa62cd37","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FfFY%3D","line":155,"in_reply_to":"AAAAS3%2F%2FfHk%3D","updated":"2013-09-25 21:44:15.000000000","message":"Agreed, looking at the libvirt driver, for example, this is used during live migration to unplug the network vif bridge from one instance and plug it into another (the migrated instance).  So it\u0027s not network injection, let\u0027s just keep the error message generic to the virt driver method and driver class.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"424e05209523a9a4a237c87c9d5bb950a5ee2ea4","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FfHk%3D","line":155,"in_reply_to":"AAAAS3%2F%2Ffl0%3D","updated":"2013-09-25 21:34:51.000000000","message":"I still don\u0027t get what network injection has to do with plugging and unplugging vifs. AFAIK those methods work also in cases in which guest injection is not performed. So unless I\u0027m wrong those log messages must be changed in something like \"VIF plugging is not supported by the Hyper-V driver\" or anything else.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2Ffl0%3D","line":155,"in_reply_to":"AAAAS3%2F%2Ffpc%3D","updated":"2013-09-25 18:49:33.000000000","message":"I\u0027m OK with what\u0027s in here now.  The previous debug log message for the hyper-v driver was when it was a no-op (pass), now it needs a usable message for the error.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"f2002148d960a102c8513746550598911369b89a","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":154,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":155,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":156,"context_line":"        raise NotImplementedError(msg)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2Ffpc%3D","line":155,"in_reply_to":"AAAAS3%2F%2Ffqw%3D","updated":"2013-09-25 18:30:05.000000000","message":"by previous message you mean: \"plug_vifs called\"?\nThe previous message for powervm was \"Network injection is not supported by the PowerVM driver.\"\nI want these messages to be consistent.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"424e05209523a9a4a237c87c9d5bb950a5ee2ea4","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":159,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":160,"context_line":"        msg \u003d _(\"Network injection is not supported by the Hyper-V driver.\")"},{"line_number":161,"context_line":"        raise NotImplementedError(msg)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def ensure_filtering_rules_for_instance(self, instance_ref, network_info):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FfHc%3D","line":160,"updated":"2013-09-25 21:34:51.000000000","message":"Ditto","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"}],"nova/virt/powervm/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":94,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":95,"context_line":"        LOG.debug(_(\u0027Network injection is not supported by the \u0027"},{"line_number":96,"context_line":"                    \u0027PowerVM driver.\u0027), instance)"},{"line_number":97,"context_line":"        msg \u003d _(\"network injection not supported by the powervm driver\")"},{"line_number":98,"context_line":"        raise NotImplementedError(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqVw%3D","line":95,"updated":"2013-09-23 07:41:45.000000000","message":"Same comment as before","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        raise NotImplementedError(msg)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":101,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":102,"context_line":"        LOG.debug(_(\u0027Network injection is not supported by the \u0027"},{"line_number":103,"context_line":"                    \u0027PowerVM driver.\u0027), instance)"},{"line_number":104,"context_line":"        msg \u003d _(\"network injection not supported by the powervm driver\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqVs%3D","line":101,"updated":"2013-09-23 07:41:45.000000000","message":"ditto","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":94,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":95,"context_line":"        msg \u003d _(\"network injection not supported by the powervm driver\")"},{"line_number":96,"context_line":"        LOG.debug(msg, instance)"},{"line_number":97,"context_line":"        raise NotImplementedError(msg)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjYE%3D","line":95,"updated":"2013-09-24 19:16:19.000000000","message":"Why did you change the message?  The existing message is better IMO.\n\nI actually don\u0027t see the need to log the message since an exception is being raised, the compute manager will catch the exception and log it, we don\u0027t need that twice.  See existing methods in the same class that do this (line 190 for the pause method).","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84580b9f28aa3b109ce085de7731e3facd19a920","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":371,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":372,"context_line":"        msg \u003d _(\"network injection not supported by the vmware driver\")"},{"line_number":373,"context_line":"        LOG.debug(msg, instance)"},{"line_number":374,"context_line":"        raise NotImplementedError(msg)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAS3%2F%2FjWw%3D","line":372,"updated":"2013-09-24 19:16:19.000000000","message":"See comments in the powervm driver.","commit_id":"34b2cfc0eab03f16e538f9499744a7aaf40baa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":371,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":372,"context_line":"        msg \u003d _(\"Network injection is not supported by the VMware driver.\")"},{"line_number":373,"context_line":"        raise NotImplementedError(msg)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":376,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FflE%3D","line":373,"updated":"2013-09-25 18:49:33.000000000","message":"You shouldn\u0027t be raising the error in the driver, you should be raising it in the vmops module.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81d65cc30f1187439beaeeeaa29857dc8d0ffd1a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":376,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":377,"context_line":"        msg \u003d _(\"Network injection is not supported by the VMware driver.\")"},{"line_number":378,"context_line":"        raise NotImplementedError(msg)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAS3%2F%2FflA%3D","line":378,"updated":"2013-09-25 18:49:33.000000000","message":"Same as above.","commit_id":"fefc6332c1ae54b133d2c03098f00fde89b49e8a"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d3cbec5b4a7643bc6ac590f3fd6ba7c5d8b91e8","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"        client_factory \u003d self._session._get_vim().client.factory"},{"line_number":1483,"context_line":"        self._set_machine_id(client_factory, instance, network_info)"},{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":1486,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":1487,"context_line":"        LOG.debug(_(\"Network injection is not supported by the \""},{"line_number":1488,"context_line":"                    \"VMware driver.\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2Fo9w%3D","line":1485,"updated":"2013-09-23 15:14:56.000000000","message":"I think that you should leave the code here unchnaged and jadd the exception to https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/driver.py#L370","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":"    def plug_vifs(self, instance, network_info):"},{"line_number":1486,"context_line":"        \"\"\"Plug VIFs into networks.\"\"\""},{"line_number":1487,"context_line":"        LOG.debug(_(\"Network injection is not supported by the \""},{"line_number":1488,"context_line":"                    \"VMware driver.\"), instance\u003dinstance)"},{"line_number":1489,"context_line":"        msg \u003d _(\"network injection not supported by the vmware driver\")"},{"line_number":1490,"context_line":"        raise NotImplementedError(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqVo%3D","line":1487,"updated":"2013-09-23 07:41:45.000000000","message":"ditto","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffbc2f71d7c00cf878954f77cf8973c037f0f968","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def unplug_vifs(self, instance, network_info):"},{"line_number":1493,"context_line":"        \"\"\"Unplug VIFs from networks.\"\"\""},{"line_number":1494,"context_line":"        LOG.debug(_(\"Network injection is not supported by the \""},{"line_number":1495,"context_line":"                    \"VMware driver.\"), instance\u003dinstance)"},{"line_number":1496,"context_line":"        msg \u003d _(\"network injection not supported by the vmware driver\")"},{"line_number":1497,"context_line":"        raise NotImplementedError(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAS3%2F%2FqVk%3D","line":1494,"updated":"2013-09-23 07:41:45.000000000","message":"ditto","commit_id":"1e73f065db1ba0e931cc0cd19266264a9af6ae3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94e90313347a7d9a054618e4e6bcfede3014b584","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        try:"},{"line_number":768,"context_line":"            self.plug_vifs(instance, network_info)"},{"line_number":769,"context_line":"        except NotImplementedError as e:"},{"line_number":770,"context_line":"            LOG.debug(e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAS3%2F%2FeBk%3D","line":767,"updated":"2013-09-26 08:12:35.000000000","message":"Please consider deleting these lines. It is better not have the code being called that to catch an exception of code purposely throwing an exception","commit_id":"cb991aca76876dc357464b5fa737274043d67592"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"576618bfdfa706781a4307c7b90f37c118a53d37","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        try:"},{"line_number":768,"context_line":"            self.plug_vifs(instance, network_info)"},{"line_number":769,"context_line":"        except NotImplementedError as e:"},{"line_number":770,"context_line":"            LOG.debug(e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAS3%2F%2FczA%3D","line":767,"in_reply_to":"AAAAS3%2F%2FeBk%3D","updated":"2013-09-26 14:29:34.000000000","message":"I don\u0027t think I agree with removing this.  Consider what happens when the vmware driver ever does need to implement the methods, it\u0027s now gone.  I understand not wanting to always log the error which you know is going to happen, but maybe a better thing would have just been to comment it out with a NOTE explaining that it\u0027s not implemented right now.","commit_id":"cb991aca76876dc357464b5fa737274043d67592"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94e90313347a7d9a054618e4e6bcfede3014b584","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                           \" while destroying the VM: %s\") % str(excep))"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"            if network_info:"},{"line_number":825,"context_line":"                try:"},{"line_number":826,"context_line":"                    self.unplug_vifs(instance, network_info)"},{"line_number":827,"context_line":"                except NotImplementedError as e:"},{"line_number":828,"context_line":"                    LOG.debug(e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAS3%2F%2FeBg%3D","line":825,"updated":"2013-09-26 08:12:35.000000000","message":"ditto","commit_id":"cb991aca76876dc357464b5fa737274043d67592"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94e90313347a7d9a054618e4e6bcfede3014b584","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                           \" while un-registering the VM: %s\") % str(excep))"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"            if network_info:"},{"line_number":873,"context_line":"                try:"},{"line_number":874,"context_line":"                    self.unplug_vifs(instance, network_info)"},{"line_number":875,"context_line":"                except NotImplementedError as e:"},{"line_number":876,"context_line":"                    LOG.debug(e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAS3%2F%2FeBc%3D","line":873,"updated":"2013-09-26 08:12:35.000000000","message":"ditto","commit_id":"cb991aca76876dc357464b5fa737274043d67592"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94e90313347a7d9a054618e4e6bcfede3014b584","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"                     \"exception while destroying the VM: %s\") % str(excep))"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        if network_info:"},{"line_number":1145,"context_line":"            try:"},{"line_number":1146,"context_line":"                self.unplug_vifs(instance, network_info)"},{"line_number":1147,"context_line":"            except NotImplementedError as e:"},{"line_number":1148,"context_line":"                LOG.debug(e, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAS3%2F%2FeBY%3D","line":1145,"updated":"2013-09-26 08:12:35.000000000","message":"ditto","commit_id":"cb991aca76876dc357464b5fa737274043d67592"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"759c32973de3fb3c82a78492495f81b1de18c9f2","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        self.plug_vifs(instance, network_info)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        lst_properties \u003d [\"summary.guest.toolsStatus\", \"runtime.powerState\","},{"line_number":770,"context_line":"                          \"summary.guest.toolsRunningStatus\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAS3%2F%2Fcys%3D","side":"PARENT","line":767,"updated":"2013-09-26 14:31:11.000000000","message":"See my comment in the previous patch, I think this should just be commented out with a NOTE that it\u0027s not implemented right now.  Removing it completely could make this difficult for anyone in the future that needs to implement the function.","commit_id":"c27d6e4c475042348517785d4fa537e6089d83a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff244deb3e3e6f93497eb9ff577e3741add8a96f","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        self.plug_vifs(instance, network_info)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        lst_properties \u003d [\"summary.guest.toolsStatus\", \"runtime.powerState\","},{"line_number":770,"context_line":"                          \"summary.guest.toolsRunningStatus\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAS3%2F%2Fb7M%3D","side":"PARENT","line":767,"in_reply_to":"AAAAS3%2F%2FcAU%3D","updated":"2013-09-26 17:22:40.000000000","message":"Yeah.","commit_id":"c27d6e4c475042348517785d4fa537e6089d83a2"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"8ed75fd43e498b2f1c6532c937f4074127b074d2","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        self.plug_vifs(instance, network_info)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        lst_properties \u003d [\"summary.guest.toolsStatus\", \"runtime.powerState\","},{"line_number":770,"context_line":"                          \"summary.guest.toolsRunningStatus\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAS3%2F%2FcAU%3D","side":"PARENT","line":767,"in_reply_to":"AAAAS3%2F%2FcO0%3D","updated":"2013-09-26 17:01:55.000000000","message":"Matt, are you OK with Gary\u0027s comment?","commit_id":"c27d6e4c475042348517785d4fa537e6089d83a2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5adc4b5b1ff64f0cc5c5056f9ae254a5ec9417a8","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    def reboot(self, instance, network_info):"},{"line_number":765,"context_line":"        \"\"\"Reboot a VM instance.\"\"\""},{"line_number":766,"context_line":"        vm_ref \u003d vm_util.get_vm_ref(self._session, instance)"},{"line_number":767,"context_line":"        self.plug_vifs(instance, network_info)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        lst_properties \u003d [\"summary.guest.toolsStatus\", \"runtime.powerState\","},{"line_number":770,"context_line":"                          \"summary.guest.toolsRunningStatus\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAS3%2F%2FcO0%3D","side":"PARENT","line":767,"in_reply_to":"AAAAS3%2F%2Fcys%3D","updated":"2013-09-26 16:11:41.000000000","message":"Matt, this code is not relevant at the moment hence it was removed. Please se the comments on the previous patch set. The vifs do not need to be pluuged when a VM is rebooted.","commit_id":"c27d6e4c475042348517785d4fa537e6089d83a2"}]}
