)]}'
{"nova/scheduler/filters/ram_filter.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"11ed5fe5634f853d38573ef7fcb7ae0ccd51ac5b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ram_allocation_ratio_opt \u003d cfg.FloatOpt(\"ram_allocation_ratio\","},{"line_number":25,"context_line":"        default\u003d1.5,"},{"line_number":26,"context_line":"        help\u003d\"virtual ram to physical ram allocation ratio\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"FLAGS \u003d flags.FLAGS"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzqU%3D","line":25,"updated":"2012-03-01 21:08:55.000000000","message":"not sure the point of this","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"822935c650b7fc5209516949d814015ea5e8a22e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ram_allocation_ratio_opt \u003d cfg.FloatOpt(\"ram_allocation_ratio\","},{"line_number":25,"context_line":"        default\u003d1.5,"},{"line_number":26,"context_line":"        help\u003d\"virtual ram to physical ram allocation ratio\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"FLAGS \u003d flags.FLAGS"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fzmo%3D","line":25,"in_reply_to":"AAAAEn%2F%2FzpY%3D","updated":"2012-03-01 21:47:31.000000000","message":"ok, I don\u0027t know why 1.5 is good, but it seems fine.","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a8c7ed4274593304a1cf84ae116936dc92632a4f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ram_allocation_ratio_opt \u003d cfg.FloatOpt(\"ram_allocation_ratio\","},{"line_number":25,"context_line":"        default\u003d1.5,"},{"line_number":26,"context_line":"        help\u003d\"virtual ram to physical ram allocation ratio\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"FLAGS \u003d flags.FLAGS"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzpY%3D","line":25,"in_reply_to":"AAAAEn%2F%2FzqU%3D","updated":"2012-03-01 21:30:53.000000000","message":"If this will be part of the default setup, we should set a \u0027good\u0027 default so demo nova installs won\u0027t a) trigger the OOM killer, b) throw errors since not enough memory due to too little memory oversubscription.  If using KVM, new linux kernels have KSM enabled making oversubscription safer.","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"}],"nova/tests/integrated/integrated_helpers.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"11ed5fe5634f853d38573ef7fcb7ae0ccd51ac5b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import nova.image.glance"},{"line_number":26,"context_line":"from nova.log import logging"},{"line_number":27,"context_line":"from nova import service"},{"line_number":28,"context_line":"from nova.scheduler import multi"},{"line_number":29,"context_line":"from nova import test  # For the flags"},{"line_number":30,"context_line":"from nova.tests.integrated.api import client"},{"line_number":31,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2Fzqc%3D","line":28,"updated":"2012-03-01 21:08:55.000000000","message":"why is this here?","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"822935c650b7fc5209516949d814015ea5e8a22e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import nova.image.glance"},{"line_number":26,"context_line":"from nova.log import logging"},{"line_number":27,"context_line":"from nova import service"},{"line_number":28,"context_line":"from nova.scheduler import multi"},{"line_number":29,"context_line":"from nova import test  # For the flags"},{"line_number":30,"context_line":"from nova.tests.integrated.api import client"},{"line_number":31,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzmM%3D","line":28,"in_reply_to":"AAAAEn%2F%2FzoQ%3D","updated":"2012-03-01 21:47:31.000000000","message":"don\u0027t move the flag, use flags.DECLARE(\u0027compute_scheduler_driver\u0027, \u0027nova.scheduler.multi\u0027)\ndown next to the log statement where flags are defined.","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a8c7ed4274593304a1cf84ae116936dc92632a4f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import nova.image.glance"},{"line_number":26,"context_line":"from nova.log import logging"},{"line_number":27,"context_line":"from nova import service"},{"line_number":28,"context_line":"from nova.scheduler import multi"},{"line_number":29,"context_line":"from nova import test  # For the flags"},{"line_number":30,"context_line":"from nova.tests.integrated.api import client"},{"line_number":31,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzoQ%3D","line":28,"in_reply_to":"AAAAEn%2F%2Fzqc%3D","updated":"2012-03-01 21:30:53.000000000","message":"So I can access the compute_scheduler_driver flag.  In retrospect I should have moved this into nova/flags.py\n\nPending your response I will make this change.","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"}],"nova/tests/scheduler/test_host_filters.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"11ed5fe5634f853d38573ef7fcb7ae0ccd51ac5b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def test_ram_filter_fails_on_memory(self):"},{"line_number":178,"context_line":"        self._stub_service_is_up(True)"},{"line_number":179,"context_line":"        filt_cls \u003d self.class_map[\u0027RamFilter\u0027]()"},{"line_number":180,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":181,"context_line":"        filter_properties \u003d {\u0027instance_type\u0027: {\u0027memory_mb\u0027: 1024}}"},{"line_number":182,"context_line":"        capabilities \u003d {\u0027enabled\u0027: True}"},{"line_number":183,"context_line":"        service \u003d {\u0027disabled\u0027: False}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzqI%3D","line":180,"updated":"2012-03-01 21:08:55.000000000","message":"and the reset here?","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a8c7ed4274593304a1cf84ae116936dc92632a4f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def test_ram_filter_fails_on_memory(self):"},{"line_number":178,"context_line":"        self._stub_service_is_up(True)"},{"line_number":179,"context_line":"        filt_cls \u003d self.class_map[\u0027RamFilter\u0027]()"},{"line_number":180,"context_line":"        self.flags(ram_allocation_ratio\u003d1.0)"},{"line_number":181,"context_line":"        filter_properties \u003d {\u0027instance_type\u0027: {\u0027memory_mb\u0027: 1024}}"},{"line_number":182,"context_line":"        capabilities \u003d {\u0027enabled\u0027: True}"},{"line_number":183,"context_line":"        service \u003d {\u0027disabled\u0027: False}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2FzpQ%3D","line":180,"in_reply_to":"AAAAEn%2F%2FzqI%3D","updated":"2012-03-01 21:30:53.000000000","message":"So the test will work independent of the default setting.","commit_id":"5274479aea2dde635f6992aa652cf709e1e1231c"}]}