)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"457f6595153deaa097dadd761bba26b75d9dfb95","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.vim \u003d self._vim_create()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _vim_create(self):"},{"line_number":76,"context_line":"        self.mox.StubOutWithMock(vim.Vim, \u0027retrieve_service_content\u0027)"},{"line_number":77,"context_line":"        self.mox.StubOutWithMock(suds.client, \u0027Client\u0027)"},{"line_number":78,"context_line":"        client \u003d mox.MockObject(suds.client.Client)"},{"line_number":79,"context_line":"        client.factory \u003d mox.MockObject(suds.client.Factory)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrfA%3D","line":76,"updated":"2013-10-11 10:22:56.000000000","message":"Really need to use mock now, rather than mox. To help in our road towards python 3.x compliance.","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"892b53aad94e3f2a569de39f63ebb4aeb59ae770","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.vim \u003d self._vim_create()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _vim_create(self):"},{"line_number":76,"context_line":"        self.mox.StubOutWithMock(vim.Vim, \u0027retrieve_service_content\u0027)"},{"line_number":77,"context_line":"        self.mox.StubOutWithMock(suds.client, \u0027Client\u0027)"},{"line_number":78,"context_line":"        client \u003d mox.MockObject(suds.client.Client)"},{"line_number":79,"context_line":"        client.factory \u003d mox.MockObject(suds.client.Factory)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrJQ%3D","line":76,"in_reply_to":"AAAATH%2F%2FrfA%3D","updated":"2013-10-11 11:59:08.000000000","message":"Done","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"02aaf5a4b540d32ac4202f55ecb857a3aa232cdb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.stubs.Set(vim.Vim, \u0027retrieve_service_content\u0027,"},{"line_number":81,"context_line":"                       fake_retrieve_service_content)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.mox.StubOutWithMock(suds.client, \u0027Client\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        client \u003d mox.MockObject(suds.client.Client)"},{"line_number":86,"context_line":"        client.factory \u003d mox.MockObject(suds.client.Factory)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FX6Y%3D","line":83,"updated":"2013-10-17 00:55:49.000000000","message":"I thought there is a agreement that using mock rather than mox on patchset 7. am I wrong?","commit_id":"53cc4e7f2adc15972c862dbedb36e214bcbcb457"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"742059fa135a45318ac7f057d78b3411b719aee1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.stubs.Set(vim.Vim, \u0027retrieve_service_content\u0027,"},{"line_number":81,"context_line":"                       fake_retrieve_service_content)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.mox.StubOutWithMock(suds.client, \u0027Client\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        client \u003d mox.MockObject(suds.client.Client)"},{"line_number":86,"context_line":"        client.factory \u003d mox.MockObject(suds.client.Factory)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FO3g%3D","line":83,"in_reply_to":"AAAATH%2F%2FX6Y%3D","updated":"2013-10-20 12:02:40.000000000","message":"Done","commit_id":"53cc4e7f2adc15972c862dbedb36e214bcbcb457"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"7ea354fcffee586947dc0d3dfebaef94dddcf103","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    def __del__(self):"},{"line_number":695,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":696,"context_line":"        if hasattr(self, \u0027vim\u0027):"},{"line_number":697,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    def _is_vim_object(self, module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FqhE%3D","line":696,"updated":"2013-09-23 05:24:22.000000000","message":"what about  self.vim \u003d None ?","commit_id":"56013a192a7d74e7efe13cfe404b67daca2392fd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ecb7933b82949c0b32ab728b733eb269858d3200","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    def __del__(self):"},{"line_number":695,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":696,"context_line":"        if hasattr(self, \u0027vim\u0027):"},{"line_number":697,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    def _is_vim_object(self, module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FqZc%3D","line":696,"in_reply_to":"AAAAS3%2F%2FqhE%3D","updated":"2013-09-23 06:51:20.000000000","message":"Good catch.\n\nThis change was added because of the following:\n2013-09-22 05:37:01.926 DEBUG nova.virt.vmwareapi.driver [req-8c58e23f-3970-4c4c-bfbf-39060c0da3ba demo demo] \u0027VMwareAPISession\u0027 object has no attribute \u0027vim\u0027 from (pid\u003d2206) __del__ /opt/stack/nova/nova/virt/vmwareapi/driver.py:705","commit_id":"56013a192a7d74e7efe13cfe404b67daca2392fd"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e17b5d85efad89fbc84ae33736f52c0c9bc00e63","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def __del__(self):"},{"line_number":696,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":697,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":698,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def _is_vim_object(self, module):"},{"line_number":701,"context_line":"        \"\"\"Check if the module is a VIM Object instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FoDU%3D","line":698,"updated":"2013-09-23 19:14:24.000000000","message":"The commit message only mentions changing the class that exceptions inherit from, so I\u0027m not sure what this part is.  Should it be in another patch?","commit_id":"f6ec5bbfcef2ed79029b31692c531afd91285367"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"11792eb0058c5dce04399cf389edcff50d1f84b7","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def __del__(self):"},{"line_number":696,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":697,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":698,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def _is_vim_object(self, module):"},{"line_number":701,"context_line":"        \"\"\"Check if the module is a VIM Object instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FoAU%3D","line":698,"in_reply_to":"AAAAS3%2F%2FoDU%3D","updated":"2013-09-23 19:26:13.000000000","message":"When the exception was received the following would appear:\n 2013-09-22 05:37:01.926 DEBUG nova.virt.vmwareapi.driver [req-8c58e23f-3970-4c4c-bfbf-39060c0da3ba demo demo] \u0027VMwareAPISession\u0027 object has no attribute \u0027vim\u0027 from (pid\u003d2206) __del__ /opt/stack/nova/nova/virt/vmwareapi/driver.py:705\n\nI\u0027ll update the commit message","commit_id":"f6ec5bbfcef2ed79029b31692c531afd91285367"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"50d6b838ccfda9af5f1ec0ecbd740cae111bd59b","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    def __del__(self):"},{"line_number":705,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":706,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":707,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _is_vim_object(self, module):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FnoY%3D","line":706,"updated":"2013-09-23 21:08:39.000000000","message":"__init__ sets self.vim to None... I don\u0027t see how this could not possibly be set.  There\u0027s no delattr on it anywhere, either.","commit_id":"a51c324a194d6f52e4d9072e10cae3a5b42a9cff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ed137dcb21eb7fc02c3f0d7112f7de540e459015","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    def __del__(self):"},{"line_number":705,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":706,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":707,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _is_vim_object(self, module):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fk4A%3D","line":706,"in_reply_to":"AAAAS3%2F%2FnoY%3D","updated":"2013-09-24 13:55:17.000000000","message":"This change was added because of the following: 2013-09-22 05:37:01.926 DEBUG nova.virt.vmwareapi.driver [req-8c58e23f-3970-4c4c-bfbf-39060c0da3ba demo demo] \u0027VMwareAPISession\u0027 object has no attribute \u0027vim\u0027 from (pid\u003d2206) __del__ /opt/stack/nova/nova/virt/vmwareapi/driver.py:705\nI think that is is due to the fact that the object are being removed from the stack with an exception.\nYou are correct, delattr is not called","commit_id":"a51c324a194d6f52e4d9072e10cae3a5b42a9cff"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"938fd22bc818f33ad6e149ce9f8b0c28fe15e201","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            # May not have been able to connect to VC, so vim is still None"},{"line_number":710,"context_line":"            if self.vim:"},{"line_number":711,"context_line":"                self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":712,"context_line":"        except Exception as excep:"},{"line_number":713,"context_line":"            # It is just cautionary on our part to do a logout in del just"},{"line_number":714,"context_line":"            # to ensure that the session is not left active."},{"line_number":715,"context_line":"            LOG.debug(excep)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FfOY%3D","side":"PARENT","line":712,"updated":"2013-09-25 21:16:09.000000000","message":"yeah, I never liked that anyway.","commit_id":"6163e808bdf9cb0014d6d12f28552bb8bc79042f"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"938fd22bc818f33ad6e149ce9f8b0c28fe15e201","unresolved":false,"context_lines":[{"line_number":704,"context_line":"    def __del__(self):"},{"line_number":705,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":706,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":707,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _is_vim_object(self, module):"},{"line_number":710,"context_line":"        \"\"\"Check if the module is a VIM Object instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FfOA%3D","line":707,"updated":"2013-09-25 21:16:09.000000000","message":"Tighter, better. Good.\n\nBut, does it belong here? Could this be a separate patch?","commit_id":"5e2dcb466e508995cc1b2432bab2784fcf909f63"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0e06b68f3909b58d37c3c54b013262d3c74ecd66","unresolved":false,"context_lines":[{"line_number":704,"context_line":"    def __del__(self):"},{"line_number":705,"context_line":"        \"\"\"Logs-out the session.\"\"\""},{"line_number":706,"context_line":"        if hasattr(self, \u0027vim\u0027) and self.vim:"},{"line_number":707,"context_line":"            self.vim.Logout(self.vim.get_service_content().sessionManager)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def _is_vim_object(self, module):"},{"line_number":710,"context_line":"        \"\"\"Check if the module is a VIM Object instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FV9A%3D","line":707,"in_reply_to":"AAAAS3%2F%2FfOA%3D","updated":"2013-09-29 12:40:42.000000000","message":"I think that is should be here. It is related to the exceptions and was evident when the problem being addressed was solved. Please let me know if you think I should add in another patch for this.","commit_id":"5e2dcb466e508995cc1b2432bab2784fcf909f63"}],"nova/virt/vmwareapi/error_util.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"50d6b838ccfda9af5f1ec0ecbd740cae111bd59b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class VimException(exception.NovaException):"},{"line_number":31,"context_line":"    \"\"\"The VIM Exception class.\"\"\""},{"line_number":32,"context_line":"    msg_fmt \u003d _(\"VMware Driver VimException.\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SessionOverLoadException(VimException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fnnk%3D","line":32,"updated":"2013-09-23 21:08:39.000000000","message":"I think you\u0027re creating a new bug?\n\nvim.py:\n\n194                     raise error_util.VimException(\n195                        _(\"Exception in %s \") % (attr_name), excep)\n\n2 arguments there.  But NovaException only takes 1 potential positional argument.","commit_id":"a51c324a194d6f52e4d9072e10cae3a5b42a9cff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ed137dcb21eb7fc02c3f0d7112f7de540e459015","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class VimException(exception.NovaException):"},{"line_number":31,"context_line":"    \"\"\"The VIM Exception class.\"\"\""},{"line_number":32,"context_line":"    msg_fmt \u003d _(\"VMware Driver VimException.\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SessionOverLoadException(VimException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fk4g%3D","line":32,"in_reply_to":"AAAAS3%2F%2Fnnk%3D","updated":"2013-09-24 13:55:17.000000000","message":"Very good catch. My bad here. I have now addressed the problem and the code here will remain unchanged.","commit_id":"a51c324a194d6f52e4d9072e10cae3a5b42a9cff"}],"nova/virt/vmwareapi/vim.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"938fd22bc818f33ad6e149ce9f8b0c28fe15e201","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    httplib.ResponseNotReady,"},{"line_number":178,"context_line":"                    httplib.CannotSendHeader) as excep:"},{"line_number":179,"context_line":"                raise error_util.SessionOverLoadException(_(\"httplib \""},{"line_number":180,"context_line":"                                \"error in %s: \") % (attr_name), excep)"},{"line_number":181,"context_line":"            except Exception as excep:"},{"line_number":182,"context_line":"                # Socket errors which need special handling for they"},{"line_number":183,"context_line":"                # might be caused by ESX API call overload"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FfMo%3D","line":180,"updated":"2013-09-25 21:16:09.000000000","message":"I know you aren\u0027t changing this, but I *really* hate this clause, it\u0027s far too broad. I wonder if this were a tighter clause you might be able to avoid needing to write line 196.","commit_id":"5e2dcb466e508995cc1b2432bab2784fcf909f63"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0e06b68f3909b58d37c3c54b013262d3c74ecd66","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    httplib.ResponseNotReady,"},{"line_number":178,"context_line":"                    httplib.CannotSendHeader) as excep:"},{"line_number":179,"context_line":"                raise error_util.SessionOverLoadException(_(\"httplib \""},{"line_number":180,"context_line":"                                \"error in %s: \") % (attr_name), excep)"},{"line_number":181,"context_line":"            except Exception as excep:"},{"line_number":182,"context_line":"                # Socket errors which need special handling for they"},{"line_number":183,"context_line":"                # might be caused by ESX API call overload"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FV3E%3D","line":180,"in_reply_to":"AAAAS3%2F%2FfMo%3D","updated":"2013-09-29 12:40:42.000000000","message":"This comment and Dan\u0027s had me digging a bit. I hope that I\u0027ll have this covered in the next patch","commit_id":"5e2dcb466e508995cc1b2432bab2784fcf909f63"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9c52540ef789e9cf379c4ddbe47420461becdf63","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                # Special handing for OpenStack exceptions when gettextutils"},{"line_number":194,"context_line":"                # invokes _save_parameters. In this specific case"},{"line_number":195,"context_line":"                # __deepcopy__ is not supported"},{"line_number":196,"context_line":"                elif str(excep).find(\u0027__deepcopy__\u0027) !\u003d -1:"},{"line_number":197,"context_line":"                    raise TypeError(_(\u0027__deepcopy__ not implemented\u0027))"},{"line_number":198,"context_line":"                else:"},{"line_number":199,"context_line":"                    raise error_util.VimException("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fix4%3D","line":196,"updated":"2013-09-24 22:15:43.000000000","message":"Is this catching something we could improve? This seems like there must be a better way.  I guess AttributeError is already taken, but what if we shrink the exposure so that we can catch AttributeError for this case specifically? Or, is there something we could implement __deepcopy__ on and raise a NotImplementedError or something?","commit_id":"5e2dcb466e508995cc1b2432bab2784fcf909f63"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"457f6595153deaa097dadd761bba26b75d9dfb95","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            # check of the SOAP response"},{"line_number":166,"context_line":"            except error_util.VimFaultException as excep:"},{"line_number":167,"context_line":"                raise"},{"line_number":168,"context_line":"            except suds.MethodNotFound:"},{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrfM%3D","line":168,"updated":"2013-10-11 10:22:56.000000000","message":"I agree we need this.","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f269c0696f68022e21193ba66e3d2bc389894242","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            except error_util.VimFaultException as excep:"},{"line_number":167,"context_line":"                raise"},{"line_number":168,"context_line":"            except suds.MethodNotFound:"},{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2F%2B88%3D","line":169,"updated":"2013-10-06 22:37:53.000000000","message":"looks like lines 169, 171,172 are unneeded.","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e3b1a133802de4ab9fc3e3cc18f607c591978a28","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            except error_util.VimFaultException as excep:"},{"line_number":167,"context_line":"                raise"},{"line_number":168,"context_line":"            except suds.MethodNotFound:"},{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2F9aE%3D","line":169,"in_reply_to":"AAAATH%2F%2F%2B88%3D","updated":"2013-10-07 13:43:20.000000000","message":"the underlying issue with the exception handing was that the common library would is not aware to the vim and suds exceptions.\nline 170 returns either the correct value or returns a recognized exception\nthe end result is that the actual exception thrown in the compute code is handled correctly and elevated (and not a __deepcopy__ not found exception)","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"892b53aad94e3f2a569de39f63ebb4aeb59ae770","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            except error_util.VimFaultException as excep:"},{"line_number":167,"context_line":"                raise"},{"line_number":168,"context_line":"            except suds.MethodNotFound:"},{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrKM%3D","line":169,"in_reply_to":"AAAATH%2F%2F4Z0%3D","updated":"2013-10-11 11:59:08.000000000","message":"From what I have seen in the traces when debugging the issue is that the exception handling would try and do a deepcopy of the data on the stack. this causes the exceptions that were seen in the stack trace on the bug description.\nmaybe here we need to try and raise a different exception","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"90aa99034c6d62ff3aa45c167292ed0b57c59c40","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            except error_util.VimFaultException as excep:"},{"line_number":167,"context_line":"                raise"},{"line_number":168,"context_line":"            except suds.MethodNotFound:"},{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2F4Z0%3D","line":169,"in_reply_to":"AAAATH%2F%2F9aE%3D","updated":"2013-10-08 14:55:15.000000000","message":"Well, looking at this...\nhttp://svn.fedorahosted.org/svn/suds/trunk/suds/__init__.py\n\nYou\u0027ll never run into an instance of suds.MethodNotFound that has the __deepcopy__ implemented unless we do some monkey patching somewhere.","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"457f6595153deaa097dadd761bba26b75d9dfb95","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"},{"line_number":173,"context_line":"            except suds.WebFault as excep:"},{"line_number":174,"context_line":"                doc \u003d excep.document"},{"line_number":175,"context_line":"                detail \u003d doc.childAtPath(\"/Envelope/Body/Fault/detail\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrfU%3D","line":172,"updated":"2013-10-11 10:22:56.000000000","message":"I am with Aaron, I can\u0027t see why we need the except clause here, that just raises everything. Given the greenlet bugs we have with loosing the exception context on greenlet thread switches, this is actually _worse_ than doing nothing :(","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"892b53aad94e3f2a569de39f63ebb4aeb59ae770","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                try:"},{"line_number":170,"context_line":"                    return super(Vim, self).__getattr__(attr_name)"},{"line_number":171,"context_line":"                except Exception:"},{"line_number":172,"context_line":"                    raise"},{"line_number":173,"context_line":"            except suds.WebFault as excep:"},{"line_number":174,"context_line":"                doc \u003d excep.document"},{"line_number":175,"context_line":"                detail \u003d doc.childAtPath(\"/Envelope/Body/Fault/detail\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FrJ8%3D","line":172,"in_reply_to":"AAAATH%2F%2FrfU%3D","updated":"2013-10-11 11:59:08.000000000","message":"Done","commit_id":"bb9def89b55503d7886342248dabfe3b2ddfc0e7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"ffdb6c13a9a1e0c7e9dd002f2b50d500824895a9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self._service_content \u003d self.retrieve_service_content()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def retrieve_service_content(self):"},{"line_number":98,"context_line":"        return self.RetrieveServiceContent(\"ServiceInstance\")"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def get_wsdl_url(protocol, host_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FSmg%3D","line":98,"updated":"2013-11-11 15:47:53.000000000","message":"This change seems unrelated AFAICT","commit_id":"96fad18749225673cea3b2ce57f97f4e08c91637"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"36cefc87277d3324714d5b644c3f2170ef25959f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self._service_content \u003d self.retrieve_service_content()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def retrieve_service_content(self):"},{"line_number":98,"context_line":"        return self.RetrieveServiceContent(\"ServiceInstance\")"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def get_wsdl_url(protocol, host_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2FSgE%3D","line":98,"in_reply_to":"AAAATn%2F%2FSmg%3D","updated":"2013-11-11 16:11:10.000000000","message":"This change was added to help with the unit tests - that is, we needed to mock this part out.","commit_id":"96fad18749225673cea3b2ce57f97f4e08c91637"}]}