)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9cbbcb21199cf697fc97085ee1bbefedf7974192","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add timeout to ovs-vsctl calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, or with a secs of 0, ovs−vsctl waits forever for a response"},{"line_number":10,"context_line":"from the database. This option limits runtime to approximately secs seconds."},{"line_number":11,"context_line":"If the timeout expires, ovs−vsctl will exit with a SIGALRM signal. (A"},{"line_number":12,"context_line":"timeout would normally happen only if the database cannot be contacted,"},{"line_number":13,"context_line":"or if the system is overloaded.)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FqRY%3D","line":10,"updated":"2013-09-23 08:17:58.000000000","message":"approximately 2 seconds?","commit_id":"a7dc76ef18a4a0ec8388ed537960ffba2d57ab59"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dc8d08fc4e9abb3abf735f7a0e2dcb322f5858b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-17 04:40:34 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add timeout to ovs-vsctl calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, or with a secs of 0, ovs−vsctl waits forever for a response"},{"line_number":10,"context_line":"from the database. This option limits runtime to approximately 5 seconds."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAATn%2F9CD0%3D","line":7,"updated":"2013-12-17 13:56:25.000000000","message":"Lets just expand this a little to \"Add configurable 120s timeout ovs-vsctl calls\"","commit_id":"a2d5d4af3f1f0b892c9f958d1f249a12a427ccd7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2da9521cf2b790d5766b4d63fb5927d9b9185847","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-17 04:40:34 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add timeout to ovs-vsctl calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, or with a secs of 0, ovs−vsctl waits forever for a response"},{"line_number":10,"context_line":"from the database. This option limits runtime to approximately 5 seconds."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAATn%2F9B1E%3D","line":7,"in_reply_to":"AAAATn%2F9CD0%3D","updated":"2013-12-17 14:49:05.000000000","message":"Done","commit_id":"a2d5d4af3f1f0b892c9f958d1f249a12a427ccd7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dc8d08fc4e9abb3abf735f7a0e2dcb322f5858b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add timeout to ovs-vsctl calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, or with a secs of 0, ovs−vsctl waits forever for a response"},{"line_number":10,"context_line":"from the database. This option limits runtime to approximately 5 seconds."},{"line_number":11,"context_line":"If the timeout expires, ovs−vsctl will exit with a SIGALRM signal. (A"},{"line_number":12,"context_line":"timeout would normally happen only if the database cannot be contacted,"},{"line_number":13,"context_line":"or if the system is overloaded.)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAATn%2F9CEA%3D","line":10,"updated":"2013-12-17 13:56:25.000000000","message":"Forgot to update this  s/5/120/","commit_id":"a2d5d4af3f1f0b892c9f958d1f249a12a427ccd7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2da9521cf2b790d5766b4d63fb5927d9b9185847","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add timeout to ovs-vsctl calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, or with a secs of 0, ovs−vsctl waits forever for a response"},{"line_number":10,"context_line":"from the database. This option limits runtime to approximately 5 seconds."},{"line_number":11,"context_line":"If the timeout expires, ovs−vsctl will exit with a SIGALRM signal. (A"},{"line_number":12,"context_line":"timeout would normally happen only if the database cannot be contacted,"},{"line_number":13,"context_line":"or if the system is overloaded.)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAATn%2F9B1A%3D","line":10,"in_reply_to":"AAAATn%2F9CEA%3D","updated":"2013-12-17 14:49:05.000000000","message":"Done","commit_id":"a2d5d4af3f1f0b892c9f958d1f249a12a427ccd7"}],"etc/nova/nova.conf.sample":[{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"089c154f073ce533ff83083145e7e71d04a22835","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"# dropped. (string value)"},{"line_number":1154,"context_line":"#iptables_drop_action\u003dDROP"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"# Amount of time ovs_vsctl should wait for a response from the"},{"line_number":1157,"context_line":"# database. 0 is to wait forever. (integer value)"},{"line_number":1158,"context_line":"#ovs_vsctl_timeout\u003d5"},{"line_number":1159,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAATn%2F9V4Y%3D","line":1156,"updated":"2013-12-12 13:47:36.000000000","message":"what is the time unit (seconds)? Please make it clear.","commit_id":"777553948f463d2c34e328aa982fecb1a34dcbf3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7ccb61810e43704f251cdf7cf67ae69b9d6caee","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"# dropped. (string value)"},{"line_number":1154,"context_line":"#iptables_drop_action\u003dDROP"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"# Amount of time ovs_vsctl should wait for a response from the"},{"line_number":1157,"context_line":"# database. 0 is to wait forever. (integer value)"},{"line_number":1158,"context_line":"#ovs_vsctl_timeout\u003d5"},{"line_number":1159,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAATn%2F9Vno%3D","line":1156,"in_reply_to":"AAAATn%2F9V4Y%3D","updated":"2013-12-12 14:26:12.000000000","message":"Done","commit_id":"777553948f463d2c34e328aa982fecb1a34dcbf3"}],"nova/network/linux_net.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a4d911bf743c0531a4cd8d6bd594ee17be0bcd7e","unresolved":false,"context_lines":[{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"def _ovs_vsctl(args):"},{"line_number":1273,"context_line":"    full_args \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d2\u0027] + args"},{"line_number":1274,"context_line":"    try:"},{"line_number":1275,"context_line":"        return utils.execute(*full_args, run_as_root\u003dTrue)"},{"line_number":1276,"context_line":"    except processutils.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FEtk%3D","line":1273,"updated":"2013-10-04 20:41:12.000000000","message":"Would it make sense to make the timeout configurable?","commit_id":"4f21e75818e64fdf786555f49a85ec1a8b33cd5f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce2f39500b1d4a99ce04cc4be54db7eda4e674ba","unresolved":false,"context_lines":[{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"def _ovs_vsctl(args):"},{"line_number":1273,"context_line":"    full_args \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d2\u0027] + args"},{"line_number":1274,"context_line":"    try:"},{"line_number":1275,"context_line":"        return utils.execute(*full_args, run_as_root\u003dTrue)"},{"line_number":1276,"context_line":"    except processutils.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2Fjs%3D","line":1273,"in_reply_to":"AAAAS3%2F%2FEtk%3D","updated":"2013-10-06 07:17:59.000000000","message":"Yes, the only reason we did not we that we had hoped that it would have made the H version. I\u0027ll do that.","commit_id":"4f21e75818e64fdf786555f49a85ec1a8b33cd5f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a4d911bf743c0531a4cd8d6bd594ee17be0bcd7e","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"        raise exception.AgentError(method\u003dfull_args)"},{"line_number":1280,"context_line":"    except Exception as e:"},{"line_number":1281,"context_line":"        LOG.error(_(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),"},{"line_number":1282,"context_line":"                  {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"def create_ovs_vif_port(bridge, dev, iface_id, mac, instance_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FEts%3D","line":1282,"updated":"2013-10-04 20:41:12.000000000","message":"This worries me a little bit that we log an error, but don\u0027t otherwise handle this case of failure.  I would expect that, at a minimum, the exception would be bubbled up or another exception raised.  Can you explain to me why this is the correct thing to do here?","commit_id":"4f21e75818e64fdf786555f49a85ec1a8b33cd5f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce2f39500b1d4a99ce04cc4be54db7eda4e674ba","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"        raise exception.AgentError(method\u003dfull_args)"},{"line_number":1280,"context_line":"    except Exception as e:"},{"line_number":1281,"context_line":"        LOG.error(_(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),"},{"line_number":1282,"context_line":"                  {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"def create_ovs_vif_port(bridge, dev, iface_id, mac, instance_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2Fjo%3D","line":1282,"in_reply_to":"AAAAS3%2F%2FEpE%3D","updated":"2013-10-06 07:17:59.000000000","message":"My bad. It should just have raised an exception","commit_id":"4f21e75818e64fdf786555f49a85ec1a8b33cd5f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8b8636310f1e2bf02c14d8f13ae7e97ffc9185b9","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"        raise exception.AgentError(method\u003dfull_args)"},{"line_number":1280,"context_line":"    except Exception as e:"},{"line_number":1281,"context_line":"        LOG.error(_(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),"},{"line_number":1282,"context_line":"                  {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"def create_ovs_vif_port(bridge, dev, iface_id, mac, instance_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FEpE%3D","line":1282,"in_reply_to":"AAAAS3%2F%2FEts%3D","updated":"2013-10-04 21:04:57.000000000","message":"Sorry, yes I think we should raise an exception here as well otherwise this could fail silently.","commit_id":"4f21e75818e64fdf786555f49a85ec1a8b33cd5f"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"089c154f073ce533ff83083145e7e71d04a22835","unresolved":false,"context_lines":[{"line_number":123,"context_line":"               default\u003d\u0027DROP\u0027,"},{"line_number":124,"context_line":"               help\u003d(\u0027The table that iptables to jump to when a packet is \u0027"},{"line_number":125,"context_line":"                     \u0027to be dropped.\u0027)),"},{"line_number":126,"context_line":"    cfg.IntOpt(\u0027ovs_vsctl_timeout\u0027,"},{"line_number":127,"context_line":"               default\u003d5,"},{"line_number":128,"context_line":"               help\u003d\u0027Amount of time ovs_vsctl should wait for a response from \u0027"},{"line_number":129,"context_line":"               \u0027the database. 0 is to wait forever.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9V4E%3D","line":126,"updated":"2013-12-12 13:47:36.000000000","message":"please specify time units","commit_id":"777553948f463d2c34e328aa982fecb1a34dcbf3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7ccb61810e43704f251cdf7cf67ae69b9d6caee","unresolved":false,"context_lines":[{"line_number":123,"context_line":"               default\u003d\u0027DROP\u0027,"},{"line_number":124,"context_line":"               help\u003d(\u0027The table that iptables to jump to when a packet is \u0027"},{"line_number":125,"context_line":"                     \u0027to be dropped.\u0027)),"},{"line_number":126,"context_line":"    cfg.IntOpt(\u0027ovs_vsctl_timeout\u0027,"},{"line_number":127,"context_line":"               default\u003d5,"},{"line_number":128,"context_line":"               help\u003d\u0027Amount of time ovs_vsctl should wait for a response from \u0027"},{"line_number":129,"context_line":"               \u0027the database. 0 is to wait forever.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9Vns%3D","line":126,"in_reply_to":"AAAATn%2F9V4E%3D","updated":"2013-12-12 14:26:12.000000000","message":"Done","commit_id":"777553948f463d2c34e328aa982fecb1a34dcbf3"}]}