)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5faefaa86f9e21348737cf080fe51da49fb86a42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address UnboundLocalError while deleting instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch deal with the problem with minimal impact."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Ideally the issue could be addressed by ensuring"},{"line_number":12,"context_line":"that neutron returned more than just network id\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATH%2F%2Fpt4%3D","line":9,"updated":"2013-10-11 17:45:10.000000000","message":"deal \u003d\u003e deals","commit_id":"c9e067117d2691983308fa393e431bc0d4cf1974"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"ea9ea6953a540c59ff08a282e7956a15472c5772","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FoQc%3D","line":943,"updated":"2013-09-23 18:20:28.000000000","message":"I don\u0027t understand, just a variable how can this fix the issue?","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0979201542973a85e0226a15323ba3aaa52db18f","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Ffq8%3D","line":943,"in_reply_to":"AAAAS3%2F%2FhrQ%3D","updated":"2013-09-25 18:23:42.000000000","message":"got it, I initially thought under the \u0027for\u0027 as in the other branch of the if. That makes sense","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8d6136afdb448dfae5fd1290268809c200410529","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FgSo%3D","line":943,"in_reply_to":"AAAAS3%2F%2FhrQ%3D","updated":"2013-09-25 15:32:50.000000000","message":"what if there is no match? what I meant was the worst case.","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5ddb83e84e500f4c78320f9a66bb251afc385ae0","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FhrQ%3D","line":943,"in_reply_to":"AAAAS3%2F%2FoM4%3D","updated":"2013-09-25 08:17:44.000000000","message":"not really - it would be done only if for loop doesn\u0027t happen","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2debbd06a4da0a0de004afe9eeb9a15b5926ce0b","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FoM4%3D","line":943,"in_reply_to":"AAAAS3%2F%2FoNQ%3D","updated":"2013-09-23 18:36:10.000000000","message":"that would be done as M-1 times where M \u003d len(networks), no?","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"bfd930ca56df8da2dd86733e218627b9225820e9","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FoNQ%3D","line":943,"in_reply_to":"AAAAS3%2F%2FoO4%3D","updated":"2013-09-23 18:34:26.000000000","message":"Could also do:  else: network_name \u003d \"\" under the \u0027for\u0027.","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"55f31b451a257c66187092c7a2994b25756073ef","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        # impact on the current logic; alternatively we would need to"},{"line_number":941,"context_line":"        # make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful."},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":946,"context_line":"                network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FoO4%3D","line":943,"in_reply_to":"AAAAS3%2F%2FoQc%3D","updated":"2013-09-23 18:24:22.000000000","message":"http://lmgtfy.com/?q\u003dunboundlocalerror+python","commit_id":"8e21cf922702f4a0e0992abdadd6c1bcfcdd9217"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d7a8818e96b68321b5c2360473afe0367856815d","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        # initialize network_name to an empty string. An empty network_name"},{"line_number":940,"context_line":"        # has no impact on the current logic; alternatively we would need"},{"line_number":941,"context_line":"        # to make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful"},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FhpY%3D","line":942,"updated":"2013-09-25 08:18:03.000000000","message":"I am against comments like this in general. They are too verbose and tend to go stale quickly. I am OK with them if they explain a workaround that should be fixed later - but in this case - this seems like a valid scenario that needs no explanation. The bug was just not properly initializing local variables - it does not need a 10 line comment.","commit_id":"51a73af224e3841ce18cbc8983a08284976ee0b4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fa9408cd9d6bac5a52d729f018210e8367add638","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        # initialize network_name to an empty string. An empty network_name"},{"line_number":940,"context_line":"        # has no impact on the current logic; alternatively we would need"},{"line_number":941,"context_line":"        # to make an extra call to neutron just to determine a symbolic"},{"line_number":942,"context_line":"        # name, which sounds rather wasteful"},{"line_number":943,"context_line":"        network_name \u003d \"\""},{"line_number":944,"context_line":"        for net in networks:"},{"line_number":945,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FgSc%3D","line":942,"in_reply_to":"AAAAS3%2F%2FhpY%3D","updated":"2013-09-25 15:35:47.000000000","message":"ok, what do you suggest we trim? I think an explanation was due just because the previous comment was saying the exact opposite.","commit_id":"51a73af224e3841ce18cbc8983a08284976ee0b4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d7a8818e96b68321b5c2360473afe0367856815d","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            net_ids \u003d [iface[\u0027network\u0027][\u0027id\u0027] for iface in network_cache]"},{"line_number":996,"context_line":"            # TODO(armando-migliaccio): in case the user is an admin"},{"line_number":997,"context_line":"            # networks below might not include net_ids; see LP bug"},{"line_number":998,"context_line":"            # 1227337 for more details"},{"line_number":999,"context_line":"            networks \u003d self._get_available_networks(context,"},{"line_number":1000,"context_line":"                                                    instance[\u0027project_id\u0027])"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FhpQ%3D","line":998,"updated":"2013-09-25 08:18:03.000000000","message":"Also I don\u0027t see much value in this comment? How is it a TODO? what is actionable?","commit_id":"51a73af224e3841ce18cbc8983a08284976ee0b4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fa9408cd9d6bac5a52d729f018210e8367add638","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            net_ids \u003d [iface[\u0027network\u0027][\u0027id\u0027] for iface in network_cache]"},{"line_number":996,"context_line":"            # TODO(armando-migliaccio): in case the user is an admin"},{"line_number":997,"context_line":"            # networks below might not include net_ids; see LP bug"},{"line_number":998,"context_line":"            # 1227337 for more details"},{"line_number":999,"context_line":"            networks \u003d self._get_available_networks(context,"},{"line_number":1000,"context_line":"                                                    instance[\u0027project_id\u0027])"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FgSQ%3D","line":998,"in_reply_to":"AAAAS3%2F%2FhpQ%3D","updated":"2013-09-25 15:35:47.000000000","message":"ok","commit_id":"51a73af224e3841ce18cbc8983a08284976ee0b4"}]}