)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1020bd29bbcfe74047cf626415ce71cd3094145d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use URIOpt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace StrOpt with URIOpt."},{"line_number":10,"context_line":"But \u0027serial_port_service_uri\u0027 in nova/conf/vmware.py"},{"line_number":11,"context_line":"is excluded because it can be non URI format(*1)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"*1: https://github.com/openstack/vmware-vspc/blob/master/README.rst"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_fff7bdf4","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":49},"updated":"2017-06-30 13:22:02.000000000","message":"Can you add a note above this option to prevent people making this mistake in the future?","commit_id":"699c10619a92f200802f29481849cff03e0a3984"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ecd30bc505334a783091a5ed53f21feac28f0fe1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use URIOpt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace StrOpt with URIOpt."},{"line_number":10,"context_line":"But \u0027serial_port_service_uri\u0027 in nova/conf/vmware.py"},{"line_number":11,"context_line":"is excluded because it can be non URI format(*1)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"*1: https://github.com/openstack/vmware-vspc/blob/master/README.rst"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_97a1b4ac","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":49},"in_reply_to":"3f1d235d_fff7bdf4","updated":"2017-07-03 02:15:43.000000000","message":"Done","commit_id":"699c10619a92f200802f29481849cff03e0a3984"}],"nova/conf/ironic.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1020bd29bbcfe74047cf626415ce71cd3094145d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"ironic_options \u003d ["},{"line_number":35,"context_line":"    cfg.URIOpt("},{"line_number":36,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":37,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":38,"context_line":"        help\u003d\u0027URL override for the Ironic API endpoint.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_3f89b574","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":14},"updated":"2017-06-30 13:22:02.000000000","message":"nit: You could probably make this even stronger by adding the \u0027schemes\u003d[\u0027http\u0027, \u0027https\u0027]\u0027 parameter","commit_id":"699c10619a92f200802f29481849cff03e0a3984"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ecd30bc505334a783091a5ed53f21feac28f0fe1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"ironic_options \u003d ["},{"line_number":35,"context_line":"    cfg.URIOpt("},{"line_number":36,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":37,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":38,"context_line":"        help\u003d\u0027URL override for the Ironic API endpoint.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_17a364a0","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":14},"in_reply_to":"3f1d235d_3f89b574","updated":"2017-07-03 02:15:43.000000000","message":"Done","commit_id":"699c10619a92f200802f29481849cff03e0a3984"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"68348552f8f4d7d86b81f302154d7333053c9bc2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"ironic_options \u003d ["},{"line_number":35,"context_line":"    cfg.URIOpt("},{"line_number":36,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":37,"context_line":"        schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":38,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":39,"context_line":"        help\u003d\u0027URL override for the Ironic API endpoint.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_e7a561a3","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":34},"updated":"2017-07-06 08:55:07.000000000","message":"just curious, why only this one has schemes while others in this patch don\u0027t have?","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d5b7a6fb0b915bc77e0001dde4dd84f6dc078569","unresolved":false,"context_lines":[{"line_number":34,"context_line":"ironic_options \u003d ["},{"line_number":35,"context_line":"    cfg.URIOpt("},{"line_number":36,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":37,"context_line":"        schemes\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":38,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":39,"context_line":"        help\u003d\u0027URL override for the Ironic API endpoint.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_87d46dea","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":34},"in_reply_to":"3f1d235d_e7a561a3","updated":"2017-07-06 08:56:22.000000000","message":"Yeah, that probably be extended to the other ones too","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"}],"nova/conf/mks.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe9273bdfc5d33e6dd1b058f2b5389e18de8203f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"mks_opts \u003d ["},{"line_number":32,"context_line":"    cfg.URIOpt(\u0027mksproxy_base_url\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027http://127.0.0.1:6090/\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"Location of MKS web console proxy"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_3ec47f3f","line":32,"updated":"2017-07-06 10:31:48.000000000","message":"From the looks of random docs, this looks like it should be [\u0027http\u0027, \u0027https\u0027] - this is a web console proxy which means it\u0027s for use in browsers\n\nhttp://docs.embotics.com/open_vm_console.htm","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e0b628bbcba164e510e3d66cedc31f53062f675f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"mks_opts \u003d ["},{"line_number":32,"context_line":"    cfg.URIOpt(\u0027mksproxy_base_url\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027http://127.0.0.1:6090/\u0027,"},{"line_number":34,"context_line":"               help\u003d\"\"\""},{"line_number":35,"context_line":"Location of MKS web console proxy"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_3f39f2f0","line":32,"in_reply_to":"3f1d235d_3ec47f3f","updated":"2017-07-07 09:33:42.000000000","message":"Done","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"}],"nova/conf/rdp.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe9273bdfc5d33e6dd1b058f2b5389e18de8203f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.URIOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":50,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The URL an end user would use to connect to the RDP HTML5 console proxy."},{"line_number":53,"context_line":"The console proxy service is called with this token-embedded URL and"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_9ee833b3","line":50,"updated":"2017-07-06 10:31:48.000000000","message":"This should ostensibly be [\u0027http\u0027, \u0027https\u0027], given that its for use in browsers","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e0b628bbcba164e510e3d66cedc31f53062f675f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.URIOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":50,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The URL an end user would use to connect to the RDP HTML5 console proxy."},{"line_number":53,"context_line":"The console proxy service is called with this token-embedded URL and"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_026c9dcb","line":50,"in_reply_to":"3f1d235d_9ee833b3","updated":"2017-07-07 09:33:42.000000000","message":"Done","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"}],"nova/conf/vmware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1020bd29bbcfe74047cf626415ce71cd3094145d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"is avoided as it creates copy of the virtual machine that shares"},{"line_number":190,"context_line":"virtual disks with its parent VM."},{"line_number":191,"context_line":"\"\"\"),"},{"line_number":192,"context_line":"    cfg.URIOpt(\u0027wsdl_location\u0027,"},{"line_number":193,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":194,"context_line":"               deprecated_reason\u003d\u0027Only vCenter versions earlier than 5.1 \u0027"},{"line_number":195,"context_line":"                                 \u0027require this option and the current \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_df976190","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":31},"updated":"2017-06-30 13:22:02.000000000","message":"Don\u0027t bother modifying this - it\u0027s deprecated","commit_id":"699c10619a92f200802f29481849cff03e0a3984"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ecd30bc505334a783091a5ed53f21feac28f0fe1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"is avoided as it creates copy of the virtual machine that shares"},{"line_number":190,"context_line":"virtual disks with its parent VM."},{"line_number":191,"context_line":"\"\"\"),"},{"line_number":192,"context_line":"    cfg.URIOpt(\u0027wsdl_location\u0027,"},{"line_number":193,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":194,"context_line":"               deprecated_reason\u003d\u0027Only vCenter versions earlier than 5.1 \u0027"},{"line_number":195,"context_line":"                                 \u0027require this option and the current \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_b7a710a8","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":31},"in_reply_to":"3f1d235d_df976190","updated":"2017-07-03 02:15:43.000000000","message":"Done","commit_id":"699c10619a92f200802f29481849cff03e0a3984"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe9273bdfc5d33e6dd1b058f2b5389e18de8203f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    # NOTE(takashin): \u0027serial_port_service_uri\u0027 can be non URI format."},{"line_number":66,"context_line":"    # See https://github.com/openstack/vmware-vspc/blob/master/README.rst"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":68,"context_line":"               help\u003d\"\"\""},{"line_number":69,"context_line":"Identifies the remote system where the serial port traffic will"},{"line_number":70,"context_line":"be sent."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_fef2876f","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":39},"updated":"2017-07-06 10:31:48.000000000","message":"This maps to \u0027backing.serviceURI\u0027 [1], which has lots of possible schemes including no scheme [2]. However, seeing as we\u0027re not using URIOpt, it doesn\u0027t really matter :)\n\n[1] https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L304-L305\n[2] https://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.vm.device.VirtualSerialPort.URIBackingInfo.html","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"99028dee067d412c1134c44200a5a9d7304a3113","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    # NOTE(takashin): \u0027serial_port_service_uri\u0027 can be non URI format."},{"line_number":66,"context_line":"    # See https://github.com/openstack/vmware-vspc/blob/master/README.rst"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":68,"context_line":"               help\u003d\"\"\""},{"line_number":69,"context_line":"Identifies the remote system where the serial port traffic will"},{"line_number":70,"context_line":"be sent."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_93411da9","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":39},"in_reply_to":"3f1d235d_02801df4","updated":"2017-07-07 10:51:50.000000000","message":"Sorry, I wasn\u0027t clear. You said that it was possible for this option to have no scheme. The document I linked says the same thing. I was agreeing with your statement as it is correct :)","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e0b628bbcba164e510e3d66cedc31f53062f675f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    # NOTE(takashin): \u0027serial_port_service_uri\u0027 can be non URI format."},{"line_number":66,"context_line":"    # See https://github.com/openstack/vmware-vspc/blob/master/README.rst"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":68,"context_line":"               help\u003d\"\"\""},{"line_number":69,"context_line":"Identifies the remote system where the serial port traffic will"},{"line_number":70,"context_line":"be sent."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_02801df4","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":39},"in_reply_to":"3f1d235d_fef2876f","updated":"2017-07-07 09:33:42.000000000","message":"If schema does not exist, an exception is raised.\nIt can be that \u0027serial_port_service_uri\u0027 does not have its scheme. \nSo it is not changed to URIOpt.\n\nhttps://github.com/openstack/oslo.config/blob/e19ca8a49391b4b4ca29435304efb83af2ea7ad3/oslo_config/types.py#L836","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fe9273bdfc5d33e6dd1b058f2b5389e18de8203f","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Any valid URI"},{"line_number":80,"context_line":"\"\"\"),"},{"line_number":81,"context_line":"    cfg.URIOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":82,"context_line":"               help\u003d\"\"\""},{"line_number":83,"context_line":"Identifies a proxy service that provides network access to the"},{"line_number":84,"context_line":"serial_port_service_uri."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_7e58b786","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":37},"updated":"2017-07-06 10:31:48.000000000","message":"This maps to \u0027backing.proxyURI\u0027 [1], which looks to be either \u0027telnet\u0027 or \u0027telnets\u0027 [2]\n\n[1] https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L304-L305\n[2] https://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.vm.device.VirtualSerialPort.URIBackingInfo.html","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e0b628bbcba164e510e3d66cedc31f53062f675f","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Any valid URI"},{"line_number":80,"context_line":"\"\"\"),"},{"line_number":81,"context_line":"    cfg.URIOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":82,"context_line":"               help\u003d\"\"\""},{"line_number":83,"context_line":"Identifies a proxy service that provides network access to the"},{"line_number":84,"context_line":"serial_port_service_uri."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_62e231d7","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":37},"in_reply_to":"3f1d235d_7e58b786","updated":"2017-07-07 09:33:42.000000000","message":"Done","commit_id":"f3168d156c62b514bf65c6124bab2b0bcaf782ea"}]}