)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"386c078b7cb246c24a1327ffc75514b5bbdfcb58","unresolved":false,"context_lines":[{"line_number":10,"context_line":"previous test cleaned up the DB without resetting the sync flag and we fixed"},{"line_number":11,"context_line":"that in I5dc0220310986c5b9fe5b71013c573c3d98cb9aa"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately, fixtures we use in Placement functional tree don\u0027t inherit from"},{"line_number":14,"context_line":"general test cases (for obvious reasons) so we need to also reset the flag"},{"line_number":15,"context_line":"there."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_56919746","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":6},"updated":"2017-07-05 07:20:51.000000000","message":"++, \\o/ that killed me a few hours","commit_id":"07d82cf8ef47d249193b2cb16fd13a94a5678468"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4cd8b5a1a6abd1818a057f2f478070345817bb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"general test cases (for obvious reasons) so we need to also reset the flag"},{"line_number":15,"context_line":"there."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib7019db36ce90bf6d762a6d37697c3a215e091b4"},{"line_number":20,"context_line":"Closes-Bug: #1702304"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_0c267269","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":49},"updated":"2017-07-05 08:16:39.000000000","message":"This isn\u0027t necessary - the authorship is set to you (correctly so IMO, given that it\u0027s a totally new patch)","commit_id":"07d82cf8ef47d249193b2cb16fd13a94a5678468"}],"nova/tests/functional/api/openstack/placement/fixtures.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"56a14322c24e2291c8d40dd619a6f8bd388f53b8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # TODO(alex_xu): we should get the traits from the DB directl, since"},{"line_number":280,"context_line":"        # it is standard traits from os-traits library. But it doesn\u0027t work"},{"line_number":281,"context_line":"        # since this bug https://bugs.launchpad.net/nova/+bug/1702304"},{"line_number":282,"context_line":"        t \u003d objects.Trait(self.context, name\u003d\"MISC_SHARES_VIA_AGGREGATE\")"},{"line_number":283,"context_line":"        t.create()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        ss.set_traits(objects.TraitList(objects\u003d[t]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_6ba16294","line":282,"updated":"2017-07-04 14:06:02.000000000","message":"As that trait was provided by os-traits\u003d\u003d0.3.1 https://github.com/openstack/os-traits/blob/0.3.1/os_traits/misc/__init__.py and as Nova is getting last version of it https://github.com/openstack/nova/blob/master/requirements.txt#L56 I don\u0027t see for us a need of adding that trait directly.\n\nWe should rather fix the root cause that is, for some reason, that this trait is not populated when we use functional tests.","commit_id":"0decc2e87dea6b76572402d254218d403cc37e6c"}],"nova/tests/functional/api/openstack/placement/gabbits/allocation-candidates.yaml":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"386c078b7cb246c24a1327ffc75514b5bbdfcb58","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#  os.environ[\u0027SS_UUID\u0027] \u003d \u0027dddddddd-61a6-472e-b8c1-74796e803066\u0027"},{"line_number":21,"context_line":"#  os.environ[\u0027AGG_UUID\u0027] \u003d \u0027aaaaaaaa-04b3-458c-9e9f-361aad56f41c\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: list traits"},{"line_number":24,"context_line":"  GET: /traits"},{"line_number":25,"context_line":"  status: 200"},{"line_number":26,"context_line":"  response_strings:"},{"line_number":27,"context_line":"    # We at least want to make sure that this trait is supported."},{"line_number":28,"context_line":"    - MISC_SHARES_VIA_AGGREGATE"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: get allocation candidates before microversion"},{"line_number":31,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_f69b0363","line":28,"range":{"start_line":23,"start_character":0,"end_line":28,"end_character":31},"updated":"2017-07-05 07:20:51.000000000","message":"Why we need this case at here? The sync already triggered in the fixture.","commit_id":"07d82cf8ef47d249193b2cb16fd13a94a5678468"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3d70de64a15c7fde0aa68d63e084e31184beae70","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#  os.environ[\u0027SS_UUID\u0027] \u003d \u0027dddddddd-61a6-472e-b8c1-74796e803066\u0027"},{"line_number":21,"context_line":"#  os.environ[\u0027AGG_UUID\u0027] \u003d \u0027aaaaaaaa-04b3-458c-9e9f-361aad56f41c\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: list traits"},{"line_number":24,"context_line":"  GET: /traits"},{"line_number":25,"context_line":"  status: 200"},{"line_number":26,"context_line":"  response_strings:"},{"line_number":27,"context_line":"    # We at least want to make sure that this trait is supported."},{"line_number":28,"context_line":"    - MISC_SHARES_VIA_AGGREGATE"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: get allocation candidates before microversion"},{"line_number":31,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_f1ad4d9b","line":28,"range":{"start_line":23,"start_character":0,"end_line":28,"end_character":31},"in_reply_to":"3f1d235d_f69b0363","updated":"2017-07-05 07:53:18.000000000","message":"I preferred to be explicit here given we don\u0027t test the fixtures... :(","commit_id":"07d82cf8ef47d249193b2cb16fd13a94a5678468"}]}