)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8af86ceed700cddc210c948229f87ac50e12648","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Store dns_domain value from neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron returns an optional \u0027dns_domain\u0027 value as part of a network"},{"line_number":10,"context_line":"model. Start storing this in the meta field of"},{"line_number":11,"context_line":"\u0027nova.network.model.Network\u0027, which we will be able to use elsewhere"},{"line_number":12,"context_line":"later."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic171eafe6eee7b2d54f6a3de1bcd264cf0b80e27"},{"line_number":15,"context_line":"Partial-Bug: #1698010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f287b81_1bc292ea","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":6},"updated":"2017-09-04 10:23:44.000000000","message":"looking at https://docs.openstack.org/mitaka/networking-guide/config-dns-int.html\n\nthe neutron port has optional dns_assignment and dns_name fields\n\nit may be better to store the dns_assignment dictionary in the nova.network.model.VIF object instead?\n\n$ neutron port-create my-net --dns_name my-port\nCreated a new port:\n+-----------------------+-----------------------------------------------------------------------------------+\n| Field                 | Value                                                                             |\n+-----------------------+-----------------------------------------------------------------------------------+\n| admin_state_up        | True                                                                              |\n| allowed_address_pairs |                                                                                   |\n| binding:vnic_type     | normal                                                                            |\n| device_id             |                                                                                   |\n| device_owner          |                                                                                   |\n| dns_assignment        | {\"hostname\": \"my-port\", \"ip_address\": \"10.0.1.3\", \"fqdn\": \"my-port.example.org.\"} |\n| dns_name              | my-port                                                                           |\n| fixed_ips             | {\"subnet_id\":\"6141b474-56cd-430f-b731-71660bb79b79\", \"ip_address\": \"10.0.1.3\"}    |\n| id                    | fb3c10f4-017e-420c-9be1-8f8c557ae21f                                              |\n| mac_address           | fa:16:3e:aa:9b:e1                                                                 |\n| name                  |                                                                                   |\n| network_id            | bf2802a0-99a0-4e8c-91e4-107d03f158ea                                              |\n| port_security_enabled | True                                                                              |\n| security_groups       | 1f0ddd73-7e3c-48bd-a64c-7ded4fe0e635                                              |\n| status                | DOWN                                                                              |\n| tenant_id             | d5660cb1e6934612a01b4fb2fb630725                                                  |\n+-----------------------+-----------------------------------------------------------------------------------+","commit_id":"f28ade799236c2fb120697710f8ff651f5924ddf"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"65609f516f388012ace90e5218b133c998f0ffa4","unresolved":false,"context_lines":[{"line_number":2146,"context_line":"                tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":2147,"context_line":"                network_mtu \u003d net.get(\u0027mtu\u0027)"},{"line_number":2148,"context_line":"                if self._has_dns_extension(context):"},{"line_number":2149,"context_line":"                    dns_domain \u003d net.get(\u0027dns_domain\u0027)"},{"line_number":2150,"context_line":"                break"},{"line_number":2151,"context_line":"        else:"},{"line_number":2152,"context_line":"            tenant_id \u003d port[\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_9b103a59","line":2149,"range":{"start_line":2149,"start_character":33,"end_line":2149,"end_character":54},"updated":"2017-07-06 14:35:10.000000000","message":"looking at http://paste.openstack.org/show/614486/\ni do not see a dns_domain field.\n\ni think you want to store fqdn field form the  dns_assignment dictionary.","commit_id":"7287a1a50c48729fc4d7c3d5a168569c4ed3e46b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"65609f516f388012ace90e5218b133c998f0ffa4","unresolved":false,"context_lines":[{"line_number":2197,"context_line":"            label\u003dnetwork_name,"},{"line_number":2198,"context_line":"            tenant_id\u003dtenant_id,"},{"line_number":2199,"context_line":"            mtu\u003dnetwork_mtu,"},{"line_number":2200,"context_line":"            dns_domain\u003ddns_domain,"},{"line_number":2201,"context_line":"            )"},{"line_number":2202,"context_line":"        network[\u0027subnets\u0027] \u003d subnets"},{"line_number":2203,"context_line":"        port_profile \u003d port.get(BINDING_PROFILE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_de07c017","line":2200,"range":{"start_line":2200,"start_character":12,"end_line":2200,"end_character":34},"updated":"2017-07-06 14:35:10.000000000","message":"if my previous comment is correct then it may be better to call this new filed fqdn also.","commit_id":"7287a1a50c48729fc4d7c3d5a168569c4ed3e46b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7901dbf1d70da271a9a0bcdf51bffe8143164b38","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"                network_name \u003d net[\u0027name\u0027]"},{"line_number":2167,"context_line":"                tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":2168,"context_line":"                network_mtu \u003d net.get(\u0027mtu\u0027)"},{"line_number":2169,"context_line":"                if self._has_dns_extension(context):"},{"line_number":2170,"context_line":"                    dns_domain \u003d net.get(\u0027dns_domain\u0027)"},{"line_number":2171,"context_line":"                break"},{"line_number":2172,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_77ae6999","line":2169,"range":{"start_line":2169,"start_character":16,"end_line":2169,"end_character":52},"updated":"2017-09-01 16:11:55.000000000","message":"Do we even need to check for the DNS extension? You\u0027re doing a get() on a dict so if it\u0027s not there it\u0027s just going to return None anyway, so why does it matter if the extension is enabled or not?","commit_id":"f28ade799236c2fb120697710f8ff651f5924ddf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a1eef168494cc33a73ff99df9cf4214296617487","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"                network_name \u003d net[\u0027name\u0027]"},{"line_number":2167,"context_line":"                tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":2168,"context_line":"                network_mtu \u003d net.get(\u0027mtu\u0027)"},{"line_number":2169,"context_line":"                if self._has_dns_extension(context):"},{"line_number":2170,"context_line":"                    dns_domain \u003d net.get(\u0027dns_domain\u0027)"},{"line_number":2171,"context_line":"                break"},{"line_number":2172,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_dbcf6aae","line":2169,"range":{"start_line":2169,"start_character":16,"end_line":2169,"end_character":52},"in_reply_to":"7f287b81_77ae6999","updated":"2017-09-08 08:50:42.000000000","message":"Oh, good point. Done","commit_id":"f28ade799236c2fb120697710f8ff651f5924ddf"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7901dbf1d70da271a9a0bcdf51bffe8143164b38","unresolved":false,"context_lines":[{"line_number":2728,"context_line":"            self.context, fake_port, fake_nets, fake_subnets)"},{"line_number":2729,"context_line":"        self.assertEqual(fake_subnets, net[\u0027subnets\u0027])"},{"line_number":2730,"context_line":"        self.assertEqual(\u0027net-id1\u0027, net[\u0027id\u0027])"},{"line_number":2731,"context_line":"        self.assertEqual(\u0027tenant\u0027, net[\u0027meta\u0027][\u0027tenant_id\u0027])"},{"line_number":2732,"context_line":""},{"line_number":2733,"context_line":"    def test_nw_info_build_network_vhostuser(self):"},{"line_number":2734,"context_line":"        fake_port \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_577c8d1f","line":2731,"range":{"start_line":2731,"start_character":8,"end_line":2731,"end_character":60},"updated":"2017-09-01 16:11:55.000000000","message":"Assert that dns_domain \u003d\u003d None.","commit_id":"f28ade799236c2fb120697710f8ff651f5924ddf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a1eef168494cc33a73ff99df9cf4214296617487","unresolved":false,"context_lines":[{"line_number":2728,"context_line":"            self.context, fake_port, fake_nets, fake_subnets)"},{"line_number":2729,"context_line":"        self.assertEqual(fake_subnets, net[\u0027subnets\u0027])"},{"line_number":2730,"context_line":"        self.assertEqual(\u0027net-id1\u0027, net[\u0027id\u0027])"},{"line_number":2731,"context_line":"        self.assertEqual(\u0027tenant\u0027, net[\u0027meta\u0027][\u0027tenant_id\u0027])"},{"line_number":2732,"context_line":""},{"line_number":2733,"context_line":"    def test_nw_info_build_network_vhostuser(self):"},{"line_number":2734,"context_line":"        fake_port \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_7b53d6e3","line":2731,"range":{"start_line":2731,"start_character":8,"end_line":2731,"end_character":60},"in_reply_to":"7f287b81_577c8d1f","updated":"2017-09-08 08:50:42.000000000","message":"Done","commit_id":"f28ade799236c2fb120697710f8ff651f5924ddf"}]}