)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"854a7ea0d134fb57230be0fac5eef23f69a027b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tasks needs extra environment setup that might affect the stability"},{"line_number":15,"context_line":"of other test cases."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The instance usage audit periodic task uses the oslo default 60 seconds"},{"line_number":18,"context_line":"spacing which cannot be redefined for our test. This makes the execution"},{"line_number":19,"context_line":"of this test longer than usual but it still finishes in 60 seconds."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: bp versioned-notification-transformation-queens"},{"line_number":22,"context_line":"Change-Id: I4319b8378cbe74400bb929bb046481e84c3df3a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bf8cb3f7_f2185bd4","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":67},"updated":"2017-12-21 12:07:28.000000000","message":"Is this not configurable? Is there a policy about mucking with configuration options or something?","commit_id":"3ceb3279a0e02afae872a8d824681d8de01bcf20"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d16d564ec09c08c976833501d3624b5b7b9cbddd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tasks needs extra environment setup that might affect the stability"},{"line_number":15,"context_line":"of other test cases."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The instance usage audit periodic task uses the oslo default 60 seconds"},{"line_number":18,"context_line":"spacing which cannot be redefined for our test. This makes the execution"},{"line_number":19,"context_line":"of this test longer than usual but it still finishes in 60 seconds."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: bp versioned-notification-transformation-queens"},{"line_number":22,"context_line":"Change-Id: I4319b8378cbe74400bb929bb046481e84c3df3a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9f91af0f_599dc357","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":67},"in_reply_to":"bf8cb3f7_f2185bd4","updated":"2017-12-28 11:22:31.000000000","message":"The _instance_usage_audit() periodic task [1] does not have the \u0027spacing\u0027  parameter defined in the decorator therefore the spacing is not configured from nova. Based on docs of oslo.service this means that the periodic tasks runs 60 seconds by default [2][3][4].\nI tried to override the value at [4] from the test setup but I failed so I left a TODO in the test code instead.\n\n[1] https://github.com/openstack/nova/blob/c1c64537665794235e508d3faaf9403038658106/nova/compute/manager.py#L6768\n[2] https://github.com/openstack/oslo.service/blob/97044dc5aeaf3ee613bdda16cc2c65836ada4e62/oslo_service/periodic_task.py#L46\n[3] https://github.com/openstack/oslo.service/blob/97044dc5aeaf3ee613bdda16cc2c65836ada4e62/oslo_service/periodic_task.py#L122\n[4]https://github.com/openstack/oslo.service/blob/97044dc5aeaf3ee613bdda16cc2c65836ada4e62/oslo_service/periodic_task.py#L29","commit_id":"3ceb3279a0e02afae872a8d824681d8de01bcf20"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"27374e7b9e592b10ab96e1a2150c5f77edd814fa","unresolved":false,"context_lines":[{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"    def setUp(self):"},{"line_number":1187,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":1188,"context_line":"        self.flags(bdms_in_notifications\u003d\u0027True\u0027, group\u003d\u0027notifications\u0027)"},{"line_number":1189,"context_line":"        # make sure that periodic instance audit is turned on"},{"line_number":1190,"context_line":"        self.flags(periodic_enable\u003dTrue)"},{"line_number":1191,"context_line":"        self.flags(instance_usage_audit\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f5c4f37_d38d2a7c","line":1188,"range":{"start_line":1188,"start_character":41,"end_line":1188,"end_character":47},"updated":"2017-09-21 13:14:47.000000000","message":"Why is it string? It can be boolean(True instead of \u0027True\u0027).","commit_id":"4de70be90e16c12d5d6639cb83d22e33ac49a8cd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"870107b0b0cfe043c6b6cc66684782b7e695c7dc","unresolved":false,"context_lines":[{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"    def setUp(self):"},{"line_number":1187,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":1188,"context_line":"        self.flags(bdms_in_notifications\u003d\u0027True\u0027, group\u003d\u0027notifications\u0027)"},{"line_number":1189,"context_line":"        # make sure that periodic instance audit is turned on"},{"line_number":1190,"context_line":"        self.flags(periodic_enable\u003dTrue)"},{"line_number":1191,"context_line":"        self.flags(instance_usage_audit\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_e1948446","line":1188,"range":{"start_line":1188,"start_character":41,"end_line":1188,"end_character":47},"in_reply_to":"9f5c4f37_d38d2a7c","updated":"2017-10-06 11:19:10.000000000","message":"Done","commit_id":"4de70be90e16c12d5d6639cb83d22e33ac49a8cd"}]}